Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 20, 2019, 11:26 a.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217315 --- Fix it, then Ship it!

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Chun-Hung Hsiao
> On Aug. 9, 2019, 7:41 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Line 752 (original), 811 (patched) > > > > > > As commented in the previous patch, since we're having two

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217295 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier
> On Aug. 9, 2019, 9:41 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Line 752 (original), 811 (patched) > > > > > > As commented in the previous patch, since we're having two

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 19, 2019, 1:58 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217217 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 15, 2019, 3:31 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217143 --- Fix it, then Ship it!

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217106 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-06 Thread Benjamin Bannier
> On Aug. 2, 2019, 9:59 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Lines 749-768 (patched) > > > > > > ``` > > loop( > > self(), > > std::bind(::after,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 6, 2019, 4:27 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217087 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 5, 2019, 10:15 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217049 --- src/resource_provider/storage/provider.cpp Lines 749-768

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217031 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review216909 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated July 29, 2019, 10:56 a.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review216879 --- Bad patch! Reviews applied: [71143, 71144, 71145, 71146, 71147,

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review216825 --- Bad patch! Reviews applied: [71143, 71144, 71145, 71146, 71147,

Review Request 71151: Performed periodic storage local provider reconciliations.

2019-07-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9254