Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216964 --- Ship it! Ship It! - Joseph Wu On July 30, 2019, 2:08 a.m.,

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Benjamin Bannier
> On July 30, 2019, 1:33 p.m., Joseph Wu wrote: > > What problem/warning is surfacing when this flag is present? Assuming your are asking out of curiosity as we would never want to build any bundled dependency with `-Werror` since we have no intention of fixing these projects. I attached the

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216960 --- What problem/warning is surfacing when this flag is present? -

Re: Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/#review216952 --- Ship it! Ship It! - Jan Schlicht On July 30, 2019, 11:08

Review Request 71200: Removed `-Werror` from libarchive's cmake build.

2019-07-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71200/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description