Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 19, 2019, 2:08 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217292 --- Fix it, then Ship it! * I think another bug was introduced

Re: Review Request 71269: Added a role tree class in the allocator.

> On Aug. 17, 2019, 11:19 a.m., Benjamin Mahler wrote: > > Nice! I was going to give a ship it but I think there's a bug in tryRemove, > > see below. > > > > Also, made a suggestion about using a `[]` operator to simplify things a > > bit. Great point, thanks! > On Aug. 17, 2019, 11:19

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 18, 2019, 12:09 p.m.) Review request for mesos, Andrei

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217260 --- Nice! I was going to give a ship it but I think there's a bug in

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 16, 2019, 3:31 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

> On Aug. 16, 2019, 9:41 a.m., Benjamin Mahler wrote: > > I think the biggest thing to consider here is that the current interface > > still allows the caller to easily break the tracking invariants: the caller > > has to ensure that it always calls tryRemove whenever making a modification >

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 16, 2019, 1:40 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217222 --- I think the biggest thing to consider here is that the current

Re: Review Request 71269: Added a role tree class in the allocator.

> On Aug. 13, 2019, 7:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 231 (patched) > > > > > > This can be `hashmap` which would avoid the > > potential leak of forgetting

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 15, 2019, 8:36 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

> On Aug. 14, 2019, 2:58 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 212-215 (patched) > > > > > > Ditto here, it seems at the overall explanation of the RoleTree > >

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217211 --- Bad review! Reviews applied: [71269, 71258, 71257, 71255, 71254]

Re: Review Request 71269: Added a role tree class in the allocator.

> On Aug. 13, 2019, 7:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 198-199 (patched) > > > > > > The comment isn't adding value here IMO > > > > s/getR/r/ > >

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 14, 2019, 2:45 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217192 --- Nice to see this, and looking forward to it tracking quota

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217190 --- Bad review! Reviews applied: [71269, 71258, 71257, 71255, 71254]

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 13, 2019, 3:05 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217161 --- I wonder if we could do a bit to avoid incorrect updates of the

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217152 --- Bad review! Reviews applied: [71269, 71258, 71257, 71255, 71254]

Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: