Re: Review Request 71299: Added separate script to install developer setup.

2019-08-27 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217460 --- Ship it! Ship It! - Joseph Wu On Aug. 20, 2019, 4:48 a.m.,

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-27 Thread Benjamin Bannier
> On Aug. 26, 2019, 8:50 p.m., Till Toenshoff wrote: > > support/setup-dev.sh > > Lines 29-48 (patched) > > > > > > These still are rather unfortunate, I feel. This will go away with r/71205. - Benjamin

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217434 --- Ship it! Excellent structure - pretty much a move code only

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-21 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217371 --- Ship it! Ship It! - James Peach On Aug. 20, 2019, 11:48

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/ --- (Updated Aug. 20, 2019, 1:48 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier
> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote: > > docs/advanced-contribution.md > > Line 69 (original), 69 (patched) > > > > > > This became a bit ambiguous now, i.e. is only the second step or the > > whole

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217278 --- Fix it, then Ship it! docs/advanced-contribution.md Line 69

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/ --- (Updated Aug. 19, 2019, 9:19 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217264 --- Fix it, then Ship it! support/setup_dev.sh Lines 1 (patched)

Review Request 71299: Added separate script to install developer setup.

2019-08-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/ --- Review request for mesos, Benno Evers and Till Toenshoff. Bugs: MESOS-9360