Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217370 --- Won't we need the allocated amount for each framework (leaf node)

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217341 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217328 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 9:44 a.m., Benjamin Mahler wrote: > > What's the thinking on taking the allocator's framework struct? Why not > > just take the information we need so that we can keep the interface > > self-contained? One of the goals of this refactoring is to eliminate state duplication

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217301 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217293 --- What's the thinking on taking the allocator's framework struct?

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217263 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217256 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Review Request 71303: Tracked frameworks in the role sorter.

2019-08-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: