Re: Review Request 71315: Refactored master draining test setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/#review217437 --- Ship it! Ship It! - Greg Mann On Aug. 22, 2019, 6:31 p.m.,

Re: Review Request 71315: Refactored master draining test setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/ --- (Updated Aug. 22, 2019, 11:31 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71315: Refactored master draining test setup.

> On Aug. 21, 2019, 3:59 p.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 206 (patched) > > > > > > Should we make this value larger? We advance the clock by the agent > > reregistration

Re: Review Request 71315: Refactored master draining test setup.

> On Aug. 21, 2019, 3:59 p.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 249 (patched) > > > > > > Do we need to parametrize these by content type? I suspect we have > > enough coverage of

Re: Review Request 71315: Refactored master draining test setup.

> On Aug. 21, 2019, 8:59 a.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 206 (patched) > > > > > > Should we make this value larger? We advance the clock by the agent > > reregistration

Re: Review Request 71315: Refactored master draining test setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/#review217355 --- Nice refactor!! Love it src/tests/master_draining_tests.cpp

Review Request 71315: Refactored master draining test setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892