Re: Review Request 71316: Added draining tests for empty agents.

2019-08-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/#review217436 --- Ship it! Ship It! - Greg Mann On Aug. 23, 2019, 7:22 p.m.,

Re: Review Request 71316: Added draining tests for empty agents.

2019-08-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- (Updated Aug. 23, 2019, 12:22 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71316: Added draining tests for empty agents.

2019-08-22 Thread Joseph Wu
> On Aug. 21, 2019, 2:28 p.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 178 (patched) > > > > > > In this case, we probably want to either not set the max grace period, > > or set it to

Re: Review Request 71316: Added draining tests for empty agents.

2019-08-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- (Updated Aug. 22, 2019, 11:34 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71316: Added draining tests for empty agents.

2019-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/#review217362 --- src/tests/master_draining_tests.cpp Lines 178 (patched)

Review Request 71316: Added draining tests for empty agents.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892