Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-11-06 Thread Benjamin Bannier
> On Nov. 6, 2019, 2:35 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 1988 (patched) > > > > > > Should this be an Option? Since it isn't, it seems like we will set the > > `source` field to a

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-11-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/#review218541 --- Ship it! Ship It! - Benjamin Bannier On Nov. 5, 2019, 2:25

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-11-06 Thread Benno Evers
> On Nov. 6, 2019, 1:35 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 1988 (patched) > > > > > > Should this be an Option? Since it isn't, it seems like we will set the > > `source` field to a

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-11-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/#review218519 --- src/master/http.cpp Lines 1988 (patched)

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-11-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/ --- (Updated Nov. 5, 2019, 1:25 p.m.) Review request for mesos and Benjamin

Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

2019-10-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9987 and MESOS-9989