Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/#review219470 --- Ship it! Ship It! - Qian Zhang On Feb. 3, 2020, 9:35 p.m., A

Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/ --- (Updated Фев. 3, 2020, 1:35 п.п.) Review request for mesos, Andrei Sekretenko,

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Jan. 30, 2020, 10:31 a.m., Qian Zhang wrote: > > src/docker/executor.cpp > > Lines 779-788 (original), 779-789 (patched) > > > > > > This seems a bit redundant to me, I'd suggest to only have: > > ``` > >

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Jan. 29, 2020, 6:28 p.m., Qian Zhang wrote: > > The commit message seems not accurate to me: > > > This could lead to termination of the executor before receiving all > > > status update acknowledgments from the agent. > > > > I think the issue that we wanted to mitigate is, executor may s

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 29, 2020, 10:28 д.п., Qian Zhang wrote: > > The commit message seems not accurate to me: > > > This could lead to termination of the executor before receiving all > > > status update acknowledgments from the agent. > > > > I think the issue that we wanted to mitigate is, executor may

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 30, 2020, 2:31 д.п., Qian Zhang wrote: > > src/docker/executor.cpp > > Lines 779-788 (original), 779-789 (patched) > > > > > > This seems a bit redundant to me, I'd suggest to only have: > > ``` > >

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 30, 2020, 12:18 д.п., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 781-783 (original), 781-783 (patched) > > > > > > Is there a reason to have a failsafe here, but not in the default > > executor

Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/#review219431 --- src/docker/executor.cpp Lines 779-788 (original), 779-789 (patche

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Jan. 29, 2020, 6:28 p.m., Qian Zhang wrote: > > The commit message seems not accurate to me: > > > This could lead to termination of the executor before receiving all > > > status update acknowledgments from the agent. > > > > I think the issue that we wanted to mitigate is, executor may s

Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/#review219427 --- src/docker/executor.cpp Lines 781-783 (original), 781-783 (patche

Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/#review219424 --- Patch looks great! Reviews applied: [72055] Passed command: expo

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 29, 2020, 10:28 д.п., Qian Zhang wrote: > > The commit message seems not accurate to me: > > > This could lead to termination of the executor before receiving all > > > status update acknowledgments from the agent. > > > > I think the issue that we wanted to mitigate is, executor may

Re: Review Request 72055: Changed termination logic of the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/ --- (Updated Янв. 29, 2020, 4:23 п.п.) Review request for mesos, Andrei Sekretenko,