Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221535 --- Ship it! Ship It! - Greg Mann On Aug. 8, 2020, 3:58 p.m.,

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 8, 2020, 11:58 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 6, 2020, 5:18 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

> On Aug. 4, 2020, 10:39 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 17-22 (patched) > > > > > > Missing includes for types used in this file like `string`,

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 5, 2020, 4:13 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 5, 2020, 3:10 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

> On Aug. 5, 2020, 6:39 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 17-22 (patched) > > > > > > Missing includes for types used in this file like `string`,

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221468 --- src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 4, 2020, 4:18 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 4, 2020, 3:18 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated Aug. 4, 2020, 9:12 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221456 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72683, 72690]

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221348 --- Patch looks great! Reviews applied: [72660, 72661, 72672, 72683,

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated July 24, 2020, 10:47 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221308 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72683, 72690]

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

> On July 20, 2020, 11:11 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > > Lines 43 (patched) > > > > > > I don't think that this isolator needs a secret generator; just

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221276 --- Patch looks great! Reviews applied: [72660, 72661, 72672, 72683,

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated July 21, 2020, 11:08 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

> On July 21, 2020, 7:11 a.m., Greg Mann wrote: > > src/CMakeLists.txt > > Lines 338 (patched) > > > > > > Why put the csi isolator implementation in a separate subdirectory, > > while the other volume isolators

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221272 --- src/CMakeLists.txt Lines 338 (patched)

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221271 --- Patch looks great! Reviews applied: [72660, 72661, 72672, 72683,

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- (Updated July 20, 2020, 4 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

> On July 17, 2020, 11:22 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 106 (patched) > > > > > > Why don't we return an error here? If an operator makes a

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221251 --- src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221248 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72683, 72690]

Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10152