Re: Review Request 72707: Added interface for the CSI server.

2020-07-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- (Updated July 31, 2020, 6:53 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72707: Added interface for the CSI server.

2020-07-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- (Updated July 31, 2020, 6:48 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72707: Added interface for the CSI server.

2020-07-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221403 --- Fix it, then Ship it! src/slave/csi_server.hpp Lines 21

Re: Review Request 72707: Added interface for the CSI server.

2020-07-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- (Updated July 28, 2020, 9:37 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72707: Added interface for the CSI server.

2020-07-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221375 --- Fix it, then Ship it! src/slave/csi_server.hpp Line 42

Re: Review Request 72707: Added interface for the CSI server.

2020-07-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221374 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72707] Failed

Re: Review Request 72707: Added interface for the CSI server.

2020-07-26 Thread Greg Mann
> On July 24, 2020, 8:50 a.m., Qian Zhang wrote: > > src/CMakeLists.txt > > Lines 165 (patched) > > > > > > I think we should put this line to L153 under > > `slave/container_logger.cpp`. Agreed. I just removed

Re: Review Request 72707: Added interface for the CSI server.

2020-07-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- (Updated July 27, 2020, 5:37 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72707: Added interface for the CSI server.

2020-07-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221357 --- Patch looks great! Reviews applied: [72660, 72707] Passed

Re: Review Request 72707: Added interface for the CSI server.

2020-07-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221352 --- src/CMakeLists.txt Lines 165 (patched)

Re: Review Request 72707: Added interface for the CSI server.

2020-07-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- (Updated July 24, 2020, 6 a.m.) Review request for mesos, Andrei Budnik and

Review Request 72707: Added interface for the CSI server.

2020-07-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10163