Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-18 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ --- (Updated Aug. 18, 2020, 5:59 p.m.) Review request for mesos and Benjamin

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/#review221606 --- include/mesos/scheduler/scheduler.proto Lines 261-264 (patched)

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-14 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ --- (Updated Aug. 14, 2020, 4:36 p.m.) Review request for mesos and Benjamin

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-13 Thread Andrei Sekretenko
> On Aug. 11, 2020, 7:16 p.m., Benjamin Mahler wrote: > > src/internal/devolve.cpp > > Lines 248-249 (original), 248-249 (patched) > > > > > > Just to double check, I assume you found this by searching for > >

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-13 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ --- (Updated Aug. 13, 2020, 6:54 p.m.) Review request for mesos and Benjamin

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/#review221547 --- Ship it! Overall structure looks good! I just left a

Review Request 72738: Added protobuf messages for constraints-based offer filtering.

2020-08-06 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10171