Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? > > Andrei

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 43-56 (patched) > > > > > > We should check that they aren't both set? > > Andrei Sekretenko wrote: >

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? Changed to

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- (Updated Aug. 18, 2020, 6:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 43-56 (patched) > > > > > > We should check that they aren't both set? > > Andrei Sekretenko wrote: >

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/#review221607 --- Fix it, then Ship it! include/mesos/allocator/allocator.hpp

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- (Updated Aug. 14, 2020, 5:48 p.m.) Review request for mesos and Benjamin

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 43-56 (patched) > > > > > > We should check that they aren't both set? > > Andrei Sekretenko wrote: >

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- (Updated Aug. 14, 2020, 5:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 64 (patched) > > > > > > This is a little confusing to me since we already have a predicate type > > from

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- (Updated Aug. 14, 2020, 4:42 p.m.) Review request for mesos and Benjamin

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 13, 2020, 9:22 p.m., Benjamin Mahler wrote: > > src/master/offer_constraints_filter.cpp > > Lines 43-56 (patched) > > > > > > We should check that they aren't both set? `oneof` guarantees that only one is

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/#review221571 --- src/master/offer_constraints_filter.cpp Lines 43-56 (patched)

Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10171