Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- (Updated Aug. 19, 2020, 10:52 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221628 --- Bad patch! Reviews applied: [72759] Failed command: ['bash',

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221621 --- Ship it! Ship It! - Greg Mann On Aug. 18, 2020, 4:22 p.m.,

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- (Updated Aug. 19, 2020, 12:22 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Greg Mann
> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? > > Qian Zhang wrote: > Orginially I