Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-18 Thread Qian Zhang
> On Aug. 14, 2020, 6:21 a.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? > > Qian Zhang wrote: > Orginially I

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-17 Thread Greg Mann
> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? > > Qian Zhang wrote: > Orginially I

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-13 Thread Qian Zhang
> On Aug. 14, 2020, 6:21 a.m., Greg Mann wrote: > > src/csi/service_manager.cpp > > Lines 740 (patched) > > > > > > Where does this env var name come from, 'MESOS_NODE_ID'? Orginially I wanted to just name it

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221574 --- src/csi/service_manager.cpp Lines 740 (patched)

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221557 --- Patch looks great! Reviews applied: [72759] Passed command:

Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10175