Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 21, 2020, 4:07 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221652 --- Ship it! Ship It! - Qian Zhang On Aug. 20, 2020, 5:48 a.m.,

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 19, 2020, 9:48 p.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221637 --- Ship it! Ship It! - Qian Zhang On Aug. 19, 2020, 2:16 p.m.,

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 19, 2020, 3:01 a.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 1747 (patched) > > > > > > As we discussed in https://reviews.apache.org/r/72759/#comment310644 , > > this should be

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 19, 2020, 6:16 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221632 --- src/slave/slave.cpp Lines 1747 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 18, 2020, 2:39 a.m., Qian Zhang wrote: > > src/slave/main.cpp > > Lines 583 (patched) > > > > > > I think it should be `--ip_discovery_command` or `--ip` flag, right? > > > >

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 18, 2020, 6:31 a.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 1746-1749 (original), 1746-1751 (patched) > > > > > > So do you want to implement `CSIServer::start()` in the way that I > >

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221616 --- src/slave/slave.cpp Lines 1746-1749 (original), 1746-1751

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 18, 2020, 5:13 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221611 --- src/slave/main.cpp Lines 583 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 18, 2020, 1:25 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 13, 2020, 7 a.m., Qian Zhang wrote: > > src/slave/main.cpp > > Lines 570 (patched) > > > > > > This line cannot compile: > > ``` > > ../../src/slave/main.cpp: In function ‘int main(int, char**)’: >

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 13, 2020, 10:42 a.m., Qian Zhang wrote: > > src/slave/slave.hpp > > Lines 892 (patched) > > > > > > Why does slave need CSI server as its member? I think slave needs to call the `start()` method of CSI

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221563 --- src/slave/main.cpp Lines 570 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221560 --- src/slave/main.cpp Lines 577 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 12, 2020, 7:19 p.m.) Review request for mesos and Qian Zhang.

Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-10163