Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72789/#review221687 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72789/#review221684 --- Bad patch! Reviews applied: [72789] Failed command: cd .. && /us

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72789/ --- (Updated Aug. 23, 2020, 10:33 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-23 Thread Qian Zhang
> On Aug. 22, 2020, 12:28 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Line 201 (original), 201 (patched) > > > > > > Can we do `state::read(volumesPath)` here so tha

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72789/ --- (Updated Aug. 23, 2020, 10:32 p.m.) Review request for mesos, Andrei Budnik and