On May 20, 2015, 7:18 a.m., Joerg Schad wrote:
docs/powered-by-mesos.md, line 28
https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28
Is that dropped by a rebase or by you?
Same below
Thanks for fixing this so quickly :-).
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/
---
(Updated May 20, 2015, 8:41 a.m.)
Review request for mesos, Isabel Jimenez,
On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
include/mesos/executor/executor.proto, line 117
https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line117
No corresponding Type for this?
Also, how and when is this used?
Alexander Rojas wrote:
I had
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/
---
(Updated May 20, 2015, 9:46 a.m.)
Review request for mesos, Adam B, Benjamin
On May 20, 2015, 5:10 a.m., Nikita Vetoshkin wrote:
3rdparty/libprocess/include/process/http.hpp, line 352
https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352
strftime formatting is locale dependent. This example
```
#include locale.h
#include
On May 20, 2015, 7:10 a.m., Nikita Vetoshkin wrote:
3rdparty/libprocess/include/process/http.hpp, line 352
https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352
strftime formatting is locale dependent. This example
```
#include locale.h
#include
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84507
---
Ship it!
Ship It!
- Alexander Rojas
On May 18, 2015, 12:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34362/#review84501
---
Ship it!
Ship It!
- Alexander Rojas
On May 18, 2015, 7:41 p.m.,
On May 19, 2015, 10:13 p.m., Vinod Kone wrote:
src/cli/mesos.cpp, line 31
https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31
So basename can never return an error? When did ::basename() return
NULL?
I checked in the `::basename` docs (`man 3 basename`) and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/#review84508
---
Ship it!
Ship It!
- Alexander Rojas
On April 22, 2015, 8:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review84502
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
On May 12, 2015, 11:28 p.m., Michael Park wrote:
Looks good overall!
I think found one more:
`src/process.cpp`
```cpp
2717: const string name = tokens.size() 1 ? tokens[1] : ;
```
I didn't even know you could capture by reference in this case!
- Alexander
On May 7, 2015, 8:55 p.m., Joerg Schad wrote:
Maybe we could use benchmark to ensure the overall change does not cause a
noticable performance penalty (don't think so, but numbers are always good
to verify)
While nice to have benchmarks, I don't think this changes are optional
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34428/
---
(Updated May 20, 2015, 3:58 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34431/#review84523
---
Bad patch!
Reviews applied: [34321, 34321]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/
---
(Updated May 20, 2015, 6:56 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34483/#review84568
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 6:04 p.m., Jie
On May 20, 2015, 8:04 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines
383-387
https://reviews.apache.org/r/34193/diff/2-3/?file=963013#file963013line383
What about:
```
programName_ = argc 0 ?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193/#review84567
---
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34432/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review84597
---
docs/mesos-c++-style-guide.md
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 633
https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line633
Did you substitute the `std::endl` with `\n\n` on purpose? Why not stay
On May 20, 2015, 5:50 p.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157
https://reviews.apache.org/r/34319/diff/3/?file=962168#file962168line157
Btw after looking at your other patches, I realize we don't really need
hasenv anymore right?
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511
https://reviews.apache.org/r/34193/diff/2/?file=963014#file963014line511
Since we're in an implementation file, we can `using
std::ostringstream;` and then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34431/
---
(Updated May 20, 2015, 9:01 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 20, 2015, 7:04 p.m.)
Review request for mesos, Alexander Rojas
On May 19, 2015, 8:05 p.m., Ben Mahler wrote:
Thanks for the test! I left some comments that are relevant to
https://reviews.apache.org/r/33793/ as well, so be sure to update that
review too.
@arojas @bmahler Thank you very much for your reviews. I update the patch,
could you help me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34483/#review84557
---
Patch looks great!
Reviews applied: [34483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34317/#review84556
---
src/cli/mesos.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 20, 2015, 6:51 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/#review84566
---
Patch looks great!
Reviews applied: [34483, 34485, 34488]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated May 20, 2015, 5:55 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 20, 2015, 7:08 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34482/#review84552
---
Ship it!
Ship It!
- Vinod Kone
On May 20, 2015, 5:48 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review84553
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34317/#review84551
---
src/examples/balloon_framework.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34485/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793/
---
(Updated May 20, 2015, 7:09 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34428/
---
(Updated May 20, 2015, 6:19 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 20, 2015, 6:40 p.m.)
Review request for mesos, Alexander Rojas
On May 20, 2015, 6:04 p.m., Timothy Chen wrote:
src/cli/mesos.cpp, line 22
https://reviews.apache.org/r/34317/diff/1/?file=962095#file962095line22
optionally you can avoid the extra check by calling
os::getenv(PATH).get()
I would guess that we can rely on PATH being set, but
On May 20, 2015, 9:27 p.m., Vinod Kone wrote:
support/post-reviews.py, line 200
https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200
if someone specifies --tracking-branch on the command line, does that
mean it'll be passed to 'rbt' twice?
This is the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/
---
(Updated May 20, 2015, 10:36 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/
---
(Updated May 20, 2015, 10:36 p.m.)
Review request for mesos, Bernd Mathiske,
On May 20, 2015, 9:27 p.m., Vinod Kone wrote:
support/post-reviews.py, line 200
https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200
if someone specifies --tracking-branch on the command line, does that
mean it'll be passed to 'rbt' twice?
Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/
---
(Updated May 20, 2015, 11:31 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/
---
(Updated May 21, 2015, 12:18 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34488/#review84634
---
Patch looks great!
Reviews applied: [34483, 34485, 34488]
All
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote:
This is a very good point, my original change had the values set as local
variables, but when I read through the task again it seemed like it was asking
for predefined constants. I'll make the changes and put them up during my
morning
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/
---
(Updated May 21, 2015, 12:36 a.m.)
Review request for mesos, Jie Yu and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34432/#review84609
---
Bad patch!
Reviews applied: [34321, 34426, 34321]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193/
---
(Updated May 20, 2015, 11:22 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/#review84626
---
Ship it!
Ship It!
- Jie Yu
On May 20, 2015, 11:13 p.m., Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34304/
---
(Updated May 21, 2015, 12:34 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/
---
(Updated May 21, 2015, 12:42 a.m.)
Review request for mesos, Jie Yu and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/
---
Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/#review84608
---
support/post-reviews.py
On May 20, 2015, 11 p.m., Ian Downes wrote:
support/post-reviews.py, line 31
https://reviews.apache.org/r/34503/diff/1/?file=965856#file965856line31
Not yours, but perhaps from subprocess import Popen?
and call, PIPE and STDOUT.
On May 20, 2015, 11 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/
---
(Updated May 20, 2015, 11:13 p.m.)
Review request for mesos, Cody Maloney, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/#review84620
---
Ship it!
Ship It!
- Michael Park
On May 20, 2015, 10:36 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated May 20, 2015, 11:44 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84603
---
Patch looks great!
Reviews applied: [33792, 34068]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33275/#review84623
---
Patch looks great!
Reviews applied: [33271, 33272, 33275]
All
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 45
https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line45
It is best practice to make base class constructors protected to
prevent
65 matches
Mail list logo
