Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review101466 --- Ship it! Regarding the "`ABORT` or `Try<>`" discussion, I agree

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-05 Thread Alexander Rukletsov
> On Sept. 29, 2015, 10:43 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 773-774 > > > > > > Could you please help me understand why this check is

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread haosdent huang
> On Oct. 5, 2015, 10:03 a.m., Jan Schlicht wrote: > > src/health-check/main.cpp, line 208 > > > > > > Following the JIRA discussion, this change seems to be in line with > > Gabriels sentence "It's fine that the

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101459 --- Ship it! src/health-check/main.cpp (line 208)

Re: Review Request 37996: Added property manager

2015-10-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 4:46 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37996: Added property manager

2015-10-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101476 ---

Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/#review101375 --- docs/networking.md (line 16)

Re: Review Request 37996: Added property manager

2015-10-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 5:57 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 5, 2015, 3:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 37996: Added property manager

2015-10-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 5, 2015, 6:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38822: Added default upgrade steps to 0.24.X to 0.25.X section

2015-10-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38822/#review101485 --- Ship it! Ship It! - Michael Park On Oct. 5, 2015, 4:36 p.m.,

Re: Review Request 37996: Added property manager

2015-10-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101483 ---

Re: Review Request 38750: Updated changelog for 0.25.0

2015-10-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38750/#review101484 --- Ship it! CHANGELOG (line 47)

Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese
> On Oct. 2, 2015, 11:16 p.m., Ben Mahler wrote: > > src/slave/containerizer/provisioner/docker/registry_client.hpp, lines 36-40 > > > > > > Hm.. any reason the registry client is nested within the containerizer? > >

<    1   2