Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105881
---

Ship it!



src/hdfs/hdfs.hpp (lines 205 - 210)


Indent with an extra space, like
```
/**
 * Foo
 * 
 * Bar to describe foo.
 */
```



src/hdfs/hdfs.hpp (line 206)


Each line of a doxygen comment should start with '*'.



src/slave/containerizer/fetcher.cpp (line 248)


Indent with 4 spaces.



src/slave/containerizer/fetcher.cpp (line 325)


Indent with 4 spaces.



src/slave/containerizer/fetcher.cpp (line 935)


Indent with 4 spaces.


- Jan Schlicht


On Nov. 10, 2015, 2:45 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Nov. 10, 2015, 2:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> 0b676f43e8529c6790824c8cf82e21a81d885ef1 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/
---

(Updated Nov. 10, 2015, 4:14 p.m.)


Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.


Changes
---

More fixes for trivial clang-format misformats (NFC).


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

Also added function to query mtime of HDFS resource.


Diffs (updated)
-

  src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 

Diff: https://reviews.apache.org/r/39595/diff/


Testing
---

make check


Thanks,

Benjamin Bannier



Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review105885
---



src/tests/hierarchical_allocator_tests.cpp (line 1150)


Also the simple case of correct behavior with several frameworks in one 
role would be interesting.



src/tests/hierarchical_allocator_tests.cpp (line 1173)


Does it make sense to refelect that in the role name?



src/tests/hierarchical_allocator_tests.cpp (line 1618)


This describes more the user story, should we maybe focus on what the test 
itself intends to test?


- Joerg Schad


On Nov. 5, 2015, 6:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> ---
> 
> (Updated Nov. 5, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 
> 
> Diff: https://reviews.apache.org/r/39450/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/#review105877
---

Ship it!


Ship It!

- haosdent huang


On Nov. 10, 2015, 1:21 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40107/
> ---
> 
> (Updated Nov. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused checks in command executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 
> 
> Diff: https://reviews.apache.org/r/40107/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/
---

(Updated Nov. 10, 2015, 4:19 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Joris' comments.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Processing quota request consists of several stages: request validation, sanity 
check and so on. This patch creates a basic workflow for quota requests, while 
the stages are implemented in subsequent patches.


Diffs (updated)
-

  src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38059/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/
---

(Updated Nov. 10, 2015, 4:19 p.m.)


Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.


Changes
---

[fixup] More fixes for trivial clang-format misformats (NFC).


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

Also added function to query mtime of HDFS resource.


Diffs (updated)
-

  src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 

Diff: https://reviews.apache.org/r/39595/diff/


Testing
---

make check


Thanks,

Benjamin Bannier



Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 10, 2015, 7:26 a.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 48
> > 
> >
> > Let's sync this to a `Try` to avoid confusion.

I think I'd better remove the whole function alltogether.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105801
---


On Nov. 9, 2015, 11:14 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 9, 2015, 11:14 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 
>   src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-11-10 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38399/#review105884
---



docs/authorization.md (line 12)


s/maintenance machine(s)/maintain machine(s)/


- Greg Mann


On Sept. 23, 2015, 5:16 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38399/
> ---
> 
> (Updated Sept. 23, 2015, 5:16 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: mesos-
> https://issues.apache.org/jira/browse/mesos-
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add ACLs for the maintenance HTTP endpoints
> 
> The design doc: 
> https://docs.google.com/document/d/1sG28ASH-5MDygR2igackOb5x-Lt5nXyIUMcwrrbk4cE/edit?usp=sharing
> 
> 
> Diffs
> -
> 
>   docs/authentication.md 1c22c5416caf66b28238fc181a255e51ed16d867 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38399/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
---

(Updated Nov. 10, 2015, 5:51 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Corrected include order.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
d422448606403fb39b077513ff73c6b9d41d2765 

Diff: https://reviews.apache.org/r/39450/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Vinod Kone
joerg, can you please make sure these reviews have linear dependencies? i'm
seeing some reviews that block multiple reviews!? are you not using the
post-reviews script?

On Tue, Nov 10, 2015 at 10:20 AM, Joerg Schad  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
>
> (Updated Nov. 10, 2015, 6:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris
> Van Remoortere.
>
>
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added Quota Request Validation.
>
>
> Diffs (updated)
> -
>
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
>   src/master/quota.hpp PRE-CREATION
>   src/master/quota.cpp PRE-CREATION
>   src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39285/diff/
>
>
> Testing
> ---
>
> make test
>
>
> Thanks,
>
> Joerg Schad
>
>


Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/
---

(Updated Nov. 10, 2015, 7:02 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Removed extra logging.


Bugs: MESOS-3074
https://issues.apache.org/jira/browse/MESOS-3074


Repository: mesos


Description
---

Performs a check whether a quota request is reasonable and can be satisfied at 
the moment. A precise answer is impossible here, but a sanity check is still 
helpful, because it allows us to filter knowingly unsatisfiable requests.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38110/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/
---

(Updated Nov. 10, 2015, 5:22 p.m.)


Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Corrected include order for gtest and gmock according to Styleguide.


Diffs (updated)
-

  src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
  src/tests/common/recordio_tests.cpp db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
  src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
  src/tests/containerizer/composing_containerizer_tests.cpp 
d66f5198114c7bd67107ee056c2062d3118d1b4c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
4bb65afd0ee61cafef68e064a697fdce65d60058 
  src/tests/containerizer/external_containerizer_test.cpp 
4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
  src/tests/containerizer/isolator_tests.cpp 
a7072124c7e5cf38ed41779c2d9e023e089bf28f 
  src/tests/containerizer/port_mapping_tests.cpp 
73634f88b3fc46fce66b17259c5f90b8d1c86f86 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/containerizer/sched_tests.cpp 
00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
  src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
  src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
  src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
  src/tests/fault_tolerance_tests.cpp 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
  src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
  src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
  src/tests/hierarchical_allocator_tests.cpp 
d422448606403fb39b077513ff73c6b9d41d2765 
  src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
  src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
  src/tests/master_allocator_tests.cpp 52fa472cbf764e0ed1dd334336f69774eb8c702b 
  src/tests/master_authorization_tests.cpp 
0d1f2b5d9ce1a998651798624238f635aeac4995 
  src/tests/master_contender_detector_tests.cpp 
84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
  src/tests/master_slave_reconciliation_tests.cpp 
7b0b983cae090ca5166d9fb1905fff88d3f21600 
  src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
  src/tests/master_validation_tests.cpp 
1dff6a353442cabe2eed9c136f30668d01305e25 
  src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
  src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
  src/tests/registrar_zookeeper_tests.cpp 
29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
  src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
  src/tests/scheduler_event_call_tests.cpp 
898cbbb58ac5391b8bd0cb94012410014cc3a606 
  src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
  src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
  src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
  src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
  src/tests/status_update_manager_tests.cpp 
82a985518276ac1015056a450634429840607524 
  src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
  src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
  src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
  src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 

Diff: https://reviews.apache.org/r/40142/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review105926
---

Ship it!


Double-checked non-Windows build.

- Joseph Wu


On Nov. 2, 2015, 11:56 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39851/
> ---
> 
> (Updated Nov. 2, 2015, 11:56 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: fixed ambiguousity error in `process/owned.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/owned.hpp 
> 1b41477d555ce567c58033f8993dc2ae0ac80a05 
> 
> Diff: https://reviews.apache.org/r/39851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review105898
---

Ship it!


Ship It!

- Jan Schlicht


On Nov. 10, 2015, 6:14 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 6:14 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 1dff6a353442cabe2eed9c136f30668d01305e25 
>   src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
>   src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
>   src/tests/registrar_zookeeper_tests.cpp 
> 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
>   src/tests/scheduler_event_call_tests.cpp 
> 898cbbb58ac5391b8bd0cb94012410014cc3a606 
>   src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
>   src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
>   src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
>   src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
>   src/tests/status_update_manager_tests.cpp 
> 82a985518276ac1015056a450634429840607524 
>   src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
>   src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
>   src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
>   src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 
> 
> Diff: https://reviews.apache.org/r/40142/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/
---

(Updated Nov. 10, 2015, 5:14 p.m.)


Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Corrected include order for gtest and gmock according to Styleguide.


Diffs
-

  src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
  src/tests/common/recordio_tests.cpp db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
  src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
  src/tests/containerizer/composing_containerizer_tests.cpp 
d66f5198114c7bd67107ee056c2062d3118d1b4c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
4bb65afd0ee61cafef68e064a697fdce65d60058 
  src/tests/containerizer/external_containerizer_test.cpp 
4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
  src/tests/containerizer/isolator_tests.cpp 
a7072124c7e5cf38ed41779c2d9e023e089bf28f 
  src/tests/containerizer/port_mapping_tests.cpp 
73634f88b3fc46fce66b17259c5f90b8d1c86f86 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/containerizer/sched_tests.cpp 
00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
  src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
  src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
  src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
  src/tests/fault_tolerance_tests.cpp 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
  src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
  src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
  src/tests/hierarchical_allocator_tests.cpp 
d422448606403fb39b077513ff73c6b9d41d2765 
  src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
  src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
  src/tests/master_allocator_tests.cpp 52fa472cbf764e0ed1dd334336f69774eb8c702b 
  src/tests/master_authorization_tests.cpp 
0d1f2b5d9ce1a998651798624238f635aeac4995 
  src/tests/master_contender_detector_tests.cpp 
84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
  src/tests/master_slave_reconciliation_tests.cpp 
7b0b983cae090ca5166d9fb1905fff88d3f21600 
  src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
  src/tests/master_validation_tests.cpp 
1dff6a353442cabe2eed9c136f30668d01305e25 
  src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
  src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
  src/tests/registrar_zookeeper_tests.cpp 
29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
  src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
  src/tests/scheduler_event_call_tests.cpp 
898cbbb58ac5391b8bd0cb94012410014cc3a606 
  src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
  src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
  src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
  src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
  src/tests/status_update_manager_tests.cpp 
82a985518276ac1015056a450634429840607524 
  src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
  src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
  src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
  src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 

Diff: https://reviews.apache.org/r/40142/diff/


Testing (updated)
---

make check


Thanks,

Joerg Schad



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/
---

(Updated Nov. 10, 2015, 5:13 p.m.)


Review request for mesos and Jan Schlicht.


Repository: mesos


Description
---

Corrected include order for gtest and gmock according to Styleguide.


Diffs (updated)
-

  src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
  src/tests/common/recordio_tests.cpp db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
  src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
  src/tests/containerizer/composing_containerizer_tests.cpp 
d66f5198114c7bd67107ee056c2062d3118d1b4c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
4bb65afd0ee61cafef68e064a697fdce65d60058 
  src/tests/containerizer/external_containerizer_test.cpp 
4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
  src/tests/containerizer/isolator_tests.cpp 
a7072124c7e5cf38ed41779c2d9e023e089bf28f 
  src/tests/containerizer/port_mapping_tests.cpp 
73634f88b3fc46fce66b17259c5f90b8d1c86f86 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/containerizer/sched_tests.cpp 
00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
  src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
  src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
  src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
  src/tests/fault_tolerance_tests.cpp 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
  src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
  src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
  src/tests/hierarchical_allocator_tests.cpp 
d422448606403fb39b077513ff73c6b9d41d2765 
  src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
  src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
  src/tests/master_allocator_tests.cpp 52fa472cbf764e0ed1dd334336f69774eb8c702b 
  src/tests/master_authorization_tests.cpp 
0d1f2b5d9ce1a998651798624238f635aeac4995 
  src/tests/master_contender_detector_tests.cpp 
84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
  src/tests/master_slave_reconciliation_tests.cpp 
7b0b983cae090ca5166d9fb1905fff88d3f21600 
  src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
  src/tests/master_validation_tests.cpp 
1dff6a353442cabe2eed9c136f30668d01305e25 
  src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
  src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
  src/tests/registrar_zookeeper_tests.cpp 
29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
  src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
  src/tests/scheduler_event_call_tests.cpp 
898cbbb58ac5391b8bd0cb94012410014cc3a606 
  src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
  src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
  src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
  src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
  src/tests/status_update_manager_tests.cpp 
82a985518276ac1015056a450634429840607524 
  src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
  src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
  src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
  src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 

Diff: https://reviews.apache.org/r/40142/diff/


Testing
---


Thanks,

Joerg Schad



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105913
---



src/master/quota.cpp (line 36)


Should we add a blank line here?
Code base seems inconsistent about it...


- Joerg Schad


On Nov. 10, 2015, 6:10 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Nov. 10, 2015, 6:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 10, 2015, 6:10 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/
---

(Updated Nov. 10, 2015, 6:30 p.m.)


Review request for mesos and Jan Schlicht.


Bugs: MESOS-3879
https://issues.apache.org/jira/browse/MESOS-3879


Repository: mesos


Description
---

Corrected include order for gtest and gmock according to Styleguide.


Diffs
-

  src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
  src/tests/common/recordio_tests.cpp db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
  src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
  src/tests/containerizer/composing_containerizer_tests.cpp 
d66f5198114c7bd67107ee056c2062d3118d1b4c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
4bb65afd0ee61cafef68e064a697fdce65d60058 
  src/tests/containerizer/external_containerizer_test.cpp 
4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
  src/tests/containerizer/isolator_tests.cpp 
a7072124c7e5cf38ed41779c2d9e023e089bf28f 
  src/tests/containerizer/port_mapping_tests.cpp 
73634f88b3fc46fce66b17259c5f90b8d1c86f86 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/containerizer/sched_tests.cpp 
00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
  src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
  src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
  src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
  src/tests/fault_tolerance_tests.cpp 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
  src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
  src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
  src/tests/hierarchical_allocator_tests.cpp 
d422448606403fb39b077513ff73c6b9d41d2765 
  src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
  src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
  src/tests/master_allocator_tests.cpp 52fa472cbf764e0ed1dd334336f69774eb8c702b 
  src/tests/master_authorization_tests.cpp 
0d1f2b5d9ce1a998651798624238f635aeac4995 
  src/tests/master_contender_detector_tests.cpp 
84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
  src/tests/master_slave_reconciliation_tests.cpp 
7b0b983cae090ca5166d9fb1905fff88d3f21600 
  src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
  src/tests/master_validation_tests.cpp 
1dff6a353442cabe2eed9c136f30668d01305e25 
  src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
  src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
  src/tests/registrar_zookeeper_tests.cpp 
29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
  src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
  src/tests/scheduler_event_call_tests.cpp 
898cbbb58ac5391b8bd0cb94012410014cc3a606 
  src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
  src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
  src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
  src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
  src/tests/status_update_manager_tests.cpp 
82a985518276ac1015056a450634429840607524 
  src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
  src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
  src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
  src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 

Diff: https://reviews.apache.org/r/40142/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 10, 2015, 6:20 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad



Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review105930
---


Bad patch!

Reviews applied: [39484]

Failed command: ./support/apply-review.sh -n -r 39484

Error:
 2015-11-10 19:26:22 URL:https://reviews.apache.org/r/39484/diff/raw/ 
[2788/2788] -> "39484.patch" [1]
error: docs/containerizer.md: does not exist in index
error: patch failed: docs/docker-containerizer.md:77
error: docs/docker-containerizer.md: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 7:17 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Nov. 10, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review105904
---


Bad patch!

Reviews applied: [40142]

Failed command: ./support/apply-review.sh -n -r 40142

Error:
 2015-11-10 17:33:47 URL:https://reviews.apache.org/r/40142/diff/raw/ 
[20939/20939] -> "40142.patch" [1]
error: src/tests/containerizer/provisioner_docker_tests.cpp: does not exist in 
index
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 5:22 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 1dff6a353442cabe2eed9c136f30668d01305e25 
>   src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
>   src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
>   src/tests/registrar_zookeeper_tests.cpp 
> 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
>   src/tests/scheduler_event_call_tests.cpp 
> 898cbbb58ac5391b8bd0cb94012410014cc3a606 
>   src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
>   src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
>   src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
>   src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
>   src/tests/status_update_manager_tests.cpp 
> 82a985518276ac1015056a450634429840607524 
>   src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
>   src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
>   src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
>   src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 
> 
> Diff: https://reviews.apache.org/r/40142/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review105910
---


Patch looks great!

Reviews applied: [40142]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 5:22 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 1dff6a353442cabe2eed9c136f30668d01305e25 
>   src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
>   src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
>   src/tests/registrar_zookeeper_tests.cpp 
> 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
>   src/tests/scheduler_event_call_tests.cpp 
> 898cbbb58ac5391b8bd0cb94012410014cc3a606 
>   src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
>   src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
>   src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
>   src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
>   src/tests/status_update_manager_tests.cpp 
> 82a985518276ac1015056a450634429840607524 
>   src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
>   src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
>   src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
>   src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 
> 
> Diff: https://reviews.apache.org/r/40142/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joseph Wu
The tree structure of the reviews is intentional (at the moment).
It's currently roughly split into components like:

  / Registrar   / POST
Protobufs - /quota endpoint - Authentication
  \ Allocator \ \ GET
   \- DELETE

~Joseph

On Tue, Nov 10, 2015 at 10:25 AM, Vinod Kone  wrote:

> joerg, can you please make sure these reviews have linear dependencies? i'm
> seeing some reviews that block multiple reviews!? are you not using the
> post-reviews script?
>
> On Tue, Nov 10, 2015 at 10:20 AM, Joerg Schad  wrote:
>
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/39285/
> > ---
> >
> > (Updated Nov. 10, 2015, 6:20 p.m.)
> >
> >
> > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris
> > Van Remoortere.
> >
> >
> > Bugs: MESOS-3199
> > https://issues.apache.org/jira/browse/MESOS-3199
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > ---
> >
> > Added Quota Request Validation.
> >
> >
> > Diffs (updated)
> > -
> >
> >   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
> >   src/master/quota.hpp PRE-CREATION
> >   src/master/quota.cpp PRE-CREATION
> >   src/master/quota_handler.cpp PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/39285/diff/
> >
> >
> > Testing
> > ---
> >
> > make test
> >
> >
> > Thanks,
> >
> > Joerg Schad
> >
> >
>


Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/
---

(Updated Nov. 10, 2015, 11:17 a.m.)


Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and Timothy 
Chen.


Bugs: MESOS-3113
https://issues.apache.org/jira/browse/MESOS-3113


Repository: mesos


Description
---

Add resource usage section to MesosContainerizer and DockerContainerizer 
documentation


Diffs (updated)
-

  docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
  docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 

Diff: https://reviews.apache.org/r/39484/diff/


Testing
---

Github gist


Thanks,

Gilbert Song



Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 147-148
> > 
> >
> > Rather than re-defining this, can you populate it via the result of 
> > `MesosTest::CreateSlaveFlags().resources`?

Do you suggest to call `MesosTest::CreateSlaveFlags()` in the `SetUp()` in 
order to use just the `.resources` artifact? Or you think I should make 
`defaultAgentResources` local in every test?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 10, 2015, 1:22 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 10, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-10 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review105962
---



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 136)


Actually we don't need to check exists before mkdir, so you can remove this 
check.



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 240)


This is not right, you need to put the removing from the pulling hashmap in 
the onAny block in line 230, because this is block is not called if no one 
requests the same image in the same time, and will leave it in the hashmap.


- Timothy Chen


On Nov. 9, 2015, 7:26 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39331/
> ---
> 
> (Updated Nov. 9, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3736
> https://issues.apache.org/jira/browse/MESOS-3736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support docker local store pull image simultaneously
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 95e46b9914c018b3e2472f98a54bc33ff9a46e17 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> bb02d650e16d45fcf337a7954f7a26143fb2c69f 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> fe6a90fe32364eec8ef923a000db19183603c338 
> 
> Diff: https://reviews.apache.org/r/39331/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> *This is not ready to be merged.
> *Still considering two question:
>  1. Handling simultaneous failure. If the first request is called and is 
> written into the hashmap. All the other requests will be waiting for the 
> future of the first request. But because its return type is 
> 'Future', if its future status is 'FAILED/DISCARDED', the 
> other requests will be waiting forever. 
> Solved by logic check: if it is the first call to get() Image_A, promise 
> associate with metadateManager->get(). If not, check whether that promised 
> future failed/discarded. If yes, over write to the hashmap.
> 
>  2. The current hashmap uses 'stringify(image::name)' as key, but it may not 
> be unique because there is chance that layer_ids can be changed. 
> One solution is to have 'stringify(image)' as key.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40146/#review105938
---


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559]

Failed command: ./support/apply-review.sh -n -r 39559

Error:
 2015-11-10 20:16:27 URL:https://reviews.apache.org/r/39559/diff/raw/ 
[10306/10306] -> "39559.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:65
error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does not 
apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:83
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 8:14 p.m., Steve Butler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40146/
> ---
> 
> (Updated Nov. 10, 2015, 8:14 p.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Bugs: MESOS-3881
> https://issues.apache.org/jira/browse/MESOS-3881
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Unifies POSIX and Windows PSTree implementations
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 741639a942971e48e2dac42db238d423e61cac21 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp 
> fd0192ca021eb0211b293eb2f4e521d588aff04f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 
> 9baa2fbfafa310517b70d54f190167f1cccbad6a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp 
> f75a77fc58db09fadf80409f506852e48a7df7c4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/40146/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Butler
> 
>



Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

2015-11-10 Thread Steve Butler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40146/
---

(Updated Nov. 10, 2015, 8:14 p.m.)


Review request for mesos and Alex Clemmer.


Changes
---

Fixed up review comments and suggestions


Bugs: MESOS-3881
https://issues.apache.org/jira/browse/MESOS-3881


Repository: mesos


Description
---

Windows: Unifies POSIX and Windows PSTree implementations


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
741639a942971e48e2dac42db238d423e61cac21 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp 
fd0192ca021eb0211b293eb2f4e521d588aff04f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 
9baa2fbfafa310517b70d54f190167f1cccbad6a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp 
f75a77fc58db09fadf80409f506852e48a7df7c4 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/40146/diff/


Testing
---


Thanks,

Steve Butler



Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39289/#review105954
---


Looks good overall.


docs/authorization.md (line 35)


Can you also change the "framework" (in `Resource roles that framework 
can`) to plural?



src/master/quota_handler.cpp (line 318)


Can you add a comment here (or somewhere describing this helper) about how 
`validateQuotaRequest` will always set the role?  Otherwise, it looks like 
you're checking one optional field, but not this one.


- Joseph Wu


On Nov. 10, 2015, 4:56 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39289/
> ---
> 
> (Updated Nov. 10, 2015, 4:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authorization of quota requests.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   include/mesos/quota/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/39289/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>



Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-10 Thread Marco Massenzio


> On Nov. 7, 2015, 1:06 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 91
> > 
> >
> > How come `Invocation` is within `Subprocess::Result`? Wouldn't it make 
> > more sense for it to be at the `Subprocess` level to be 
> > `Subprocess::Invocation`?

I probably misunderstood your earlier comment.
Moved one level up, into `Subprocess`.


> On Nov. 7, 2015, 1:06 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 278
> > 
> >
> > We tend to not use `getX()` style naming for accessors. How about 
> > `outData()`?

great point (wasn't sure, as it's not spelled out in our style guide - and it's 
not truly a "getter" in the Google sytle sense: `foo_` -> `foo()`)
also renamed `stderr_` to `errData` and `getStderr()` to `errData()` - please 
let me know if that was "overreach"!


> On Nov. 7, 2015, 1:06 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 340
> > 
> >
> > I think this violates our use of `auto` rule. Could you please spell 
> > out the type?

I would disagree here... the type is `Try` and 
adding that, I don't think makes the code any more readable (on the contrary).
In fact, we don't really make use of any of that - all we care is that no error 
is returned: it could very well be a `Try` for all we care :)

This seems to me a poster child of the use-case for `auto`... anyways, no 
biggie, I've added the type.


> On Nov. 7, 2015, 1:06 a.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 202-203
> > 
> >
> > Why do we need the `promise` stuff here?
> > 
> > Does something like the following not work?
> > 
> > ```cpp
> > Future, Future, Future>> 
> > result =
> >   await(status(), getStdout(), getStderr());
> > 
> > return result.then([=](...) { ... })
> >  .onFailed([=](...) { ... })
> >  .onDiscard([this]() { cleanup(); });
> > ```

I don't quite remember what it was that I came across originally when I tried 
the above (sans Promise) then Joris suggested the pattern that you see here 
now, and this works. IIRC I could never get the `onFailed` to get invoked for 
failed commands, so the pending process never got cleaned up.

If you feel strongly this should not be here (and/or are confident the pattern 
above works) I'm happy to have another go at it.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/#review105544
---


On Nov. 6, 2015, 6:24 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37336/
> ---
> 
> (Updated Nov. 6, 2015, 6:24 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-3035
> https://issues.apache.org/jira/browse/MESOS-3035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The original API for `process::Subprocess` still left a lot of legwork
> to do for the caller; we have now added an `execute()` method
> that returns a `Future`.
>  
> `Subprocess::Result`, also introduced with this patch, contains useful 
> information
> about the command invocation (an `Invocation` struct); the exit code; 
> `stdout`;
> and, optionally, `stderr` too.
>  
> Once the Future completes, if successful, the caller will be able to retrieve
> stdout/stderr; whether the command was successful; and whether it received a 
> signal
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> f17816e813d5efce1d3bb1ff1e850eeda3ba 
>   3rdparty/libprocess/src/subprocess.cpp 
> efe0018d0414c4137fd833c153eb262232e712bc 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> ac600a551fb1a7782ff33cce204b7819497ef54a 
> 
> Diff: https://reviews.apache.org/r/37336/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> (also tested functionality with an anonymous module that exposes an 
> `/execute` endpoint and runs arbitrary commands, asynchronously,
> on an Agent)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>



Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40129/#review105943
---

Ship it!



support/apply-review.sh 


do we even need this script anymore? is this for backwards compatiblity 
with existing tooling? is that plan to kill this eventually? worth adding some 
comments/TODO/JIRA for this.


- Vinod Kone


On Nov. 10, 2015, 8:02 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40129/
> ---
> 
> (Updated Nov. 10, 2015, 8:02 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-3868
> https://issues.apache.org/jira/browse/MESOS-3868
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated apply-review.sh to use apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
> 
> Diff: https://reviews.apache.org/r/40129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/#review105960
---


Patch looks great!

Reviews applied: [37336]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 8:51 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37336/
> ---
> 
> (Updated Nov. 10, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-3035
> https://issues.apache.org/jira/browse/MESOS-3035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The original API for `process::Subprocess` still left a lot of legwork
> to do for the caller; we have now added an `execute()` method
> that returns a `Future`.
>  
> `Subprocess::Result`, also introduced with this patch, contains useful 
> information
> about the command invocation (an `Invocation` struct); the exit code; 
> `stdout`;
> and, optionally, `stderr` too.
>  
> Once the Future completes, if successful, the caller will be able to retrieve
> stdout/stderr; whether the command was successful; and whether it received a 
> signal
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> f17816e813d5efce1d3bb1ff1e850eeda3ba 
>   3rdparty/libprocess/src/subprocess.cpp 
> efe0018d0414c4137fd833c153eb262232e712bc 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> ac600a551fb1a7782ff33cce204b7819497ef54a 
> 
> Diff: https://reviews.apache.org/r/37336/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> (also tested functionality with an anonymous module that exposes an 
> `/execute` endpoint and runs arbitrary commands, asynchronously,
> on an Agent)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>



Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105941
---

Ship it!



support/apply-reviews.py (line 320)


not always right? want to update this comment?



support/apply-reviews.py (line 321)


pull this comment inside?


- Vinod Kone


On Nov. 10, 2015, 8:03 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Nov. 10, 2015, 8:03 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--chain' option to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - With and without '-c'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-10 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
---

(Updated Nov. 10, 2015, 8:51 p.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Addressed mpark's comments


Summary (updated)
-

Added `execute()` method to process::Subprocess


Bugs: MESOS-3035
https://issues.apache.org/jira/browse/MESOS-3035


Repository: mesos


Description
---

The original API for `process::Subprocess` still left a lot of legwork
to do for the caller; we have now added an `execute()` method
that returns a `Future`.
 
`Subprocess::Result`, also introduced with this patch, contains useful 
information
about the command invocation (an `Invocation` struct); the exit code; `stdout`;
and, optionally, `stderr` too.
 
Once the Future completes, if successful, the caller will be able to retrieve
stdout/stderr; whether the command was successful; and whether it received a 
signal


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
f17816e813d5efce1d3bb1ff1e850eeda3ba 
  3rdparty/libprocess/src/subprocess.cpp 
efe0018d0414c4137fd833c153eb262232e712bc 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
ac600a551fb1a7782ff33cce204b7819497ef54a 

Diff: https://reviews.apache.org/r/37336/diff/


Testing
---

make check

(also tested functionality with an anonymous module that exposes an `/execute` 
endpoint and runs arbitrary commands, asynchronously,
on an Agent)


Thanks,

Marco Massenzio



Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Joseph Wu


> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?
> 
> Alexander Rukletsov wrote:
> One of the comments I got earlier from Bernd is that it is hard to track 
> what resources are available, hence I decided to re-introduce the resources 
> explicitly.

Can you add a comment about this to the test?


> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 147-148
> > 
> >
> > Rather than re-defining this, can you populate it via the result of 
> > `MesosTest::CreateSlaveFlags().resources`?
> 
> Alexander Rukletsov wrote:
> Do you suggest to call `MesosTest::CreateSlaveFlags()` in the `SetUp()` 
> in order to use just the `.resources` artifact? Or you think I should make 
> `defaultAgentResources` local in every test?

This ties in with the above issue.  Given what Bernd/you said, what you have is 
probably ok.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 10, 2015, 2 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 10, 2015, 2 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review105981
---



src/tests/containerizer.hpp (line 19)


I see that we have some discussion in mail list, can you please add more 
detail for what we discussed in the "Description" section so that everyone will 
know how we order the include files in the future.


- Guangya Liu


On Nov. 10, 2015, 6:30 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-3879
> https://issues.apache.org/jira/browse/MESOS-3879
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 1dff6a353442cabe2eed9c136f30668d01305e25 
>   src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
>   src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
>   src/tests/registrar_zookeeper_tests.cpp 
> 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
>   src/tests/scheduler_event_call_tests.cpp 
> 898cbbb58ac5391b8bd0cb94012410014cc3a606 
>   src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
>   src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
>   src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
>   src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
>   src/tests/status_update_manager_tests.cpp 
> 82a985518276ac1015056a450634429840607524 
>   src/tests/teardown_tests.cpp 89eb3144b458c8d3fe2b9bca03f93ac352f99f4b 
>   src/tests/zookeeper.hpp ed341125595f3cb766af3d2c05e57b306a9e464e 
>   src/tests/zookeeper.cpp 6ce008fbd1dda1fce10cd45e2d4d6051e1fc5a41 
>   src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85 
> 
> Diff: https://reviews.apache.org/r/40142/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 925
> > 
> >
> > Do you want to -symetrically to your todu when setting quota- print the 
> > actual quota removed?

I was thinking about it, do you think it adds extra value?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105817
---


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 140
> > 
> >
> > Maybe s/Introduce/Consider introducing/
> > Are we sure we want to do this?

A very good point. I actually think each `TODO` which states something should 
have been converted to code. The only reason to leave a `TODO` is because there 
is a certain level of uncertainty.


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 894
> > 
> >
> > let's clarify `just updates the numbers`. Also missing a period.

Will do, please check if this helps.


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 906
> > 
> >
> > A comment as to why we want to `allocate()` here would be useful.

Will do, please check if this helps.


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 927
> > 
> >
> > A comment here would be helpful as well.

Will do, please check if this helps.


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 225
> > 
> >
> > I think we can add an equivalent comment as above this for loop (not 
> > your fault):
> > `// Update the allocation to this framework.`

Will do, please verify if this is what you would like to see here.


> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 330
> > 
> >
> > same as above. let's add a comment here.

Will do, please verify if this is what you would like to see here.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105816
---


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/
---

(Updated Nov. 10, 2015, 11:06 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
cd0d3e0bd234fcf4db9af2e376ea311937204f75 
  src/master/allocator/mesos/hierarchical.cpp 
14fef63714721fcda7cea3c28704766efda6d007 

Diff: https://reviews.apache.org/r/39400/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad


> On Nov. 10, 2015, 10:41 p.m., Guangya Liu wrote:
> > src/tests/containerizer.hpp, line 19
> > 
> >
> > I see that we have some discussion in mail list, can you please add 
> > more detail for what we discussed in the "Description" section so that 
> > everyone will know how we order the include files in the future.

Hi, the discussion on the mailing list is actually more general and the review 
in discussion contains a large example. This is not the complete fix for the 
entire discussion on the mailing list, but more about a) consistency (as 
currently these includes are ordered very inconsistent across files) and b) the 
fact that  is a custom .h header (hence it is clearly specified 
by our styleguide how they should be ordered). So in general you should order 
your includes as specified in the Google Styleguide (and Jan's review will give 
more examples for that).


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review105981
---


On Nov. 10, 2015, 6:30 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-3879
> https://issues.apache.org/jira/browse/MESOS-3879
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 1dff6a353442cabe2eed9c136f30668d01305e25 
>   src/tests/partition_tests.cpp 6a6524e98d552b8107a765563e1c3f4140805bc3 
>   src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 
>   src/tests/registrar_zookeeper_tests.cpp 
> 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 
>   src/tests/reservation_tests.cpp 4bc2b313572a8cd76fa798ac745c319a7c11df0e 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
>   src/tests/scheduler_event_call_tests.cpp 
> 898cbbb58ac5391b8bd0cb94012410014cc3a606 
>   src/tests/scheduler_tests.cpp 0afeca377dd422865cc9615c85a14b65512dfa6a 
>   src/tests/slave_recovery_tests.cpp 648babec6307127ff28692de7c4868af3ac123a3 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
>   src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af 
>   src/tests/state_tests.cpp 7cee17ddeeb0bf6a9f08d990031e2fbb14a10126 
>   src/tests/status_update_manager_tests.cpp 
> 82a985518276ac1015056a450634429840607524 
>   

Re: Review Request 40162: Updated docker build script to install libev package.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40162/#review106001
---


Patch looks great!

Reviews applied: [39953, 39954, 39914, 40162]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 11:47 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40162/
> ---
> 
> (Updated Nov. 10, 2015, 11:47 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker build script to install libev package.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
> 
> Diff: https://reviews.apache.org/r/40162/diff/
> 
> 
> Testing
> ---
> 
> tested locally and on jenkins.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-10 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review105965
---



src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 136)


Wondering if you need to pass "recursive" (true) to mkdir. This flag 
ensures that the the whole path of dierctory is created as needed. If its 
already existing, it wont create one.


- Jojy Varghese


On Nov. 9, 2015, 7:26 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39331/
> ---
> 
> (Updated Nov. 9, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3736
> https://issues.apache.org/jira/browse/MESOS-3736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support docker local store pull image simultaneously
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 95e46b9914c018b3e2472f98a54bc33ff9a46e17 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> bb02d650e16d45fcf337a7954f7a26143fb2c69f 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> fe6a90fe32364eec8ef923a000db19183603c338 
> 
> Diff: https://reviews.apache.org/r/39331/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> *This is not ready to be merged.
> *Still considering two question:
>  1. Handling simultaneous failure. If the first request is called and is 
> written into the hashmap. All the other requests will be waiting for the 
> future of the first request. But because its return type is 
> 'Future', if its future status is 'FAILED/DISCARDED', the 
> other requests will be waiting forever. 
> Solved by logic check: if it is the first call to get() Image_A, promise 
> associate with metadateManager->get(). If not, check whether that promised 
> future failed/discarded. If yes, over write to the hashmap.
> 
>  2. The current hashmap uses 'stringify(image::name)' as key, but it may not 
> be unique because there is chance that layer_ids can be changed. 
> One solution is to have 'stringify(image)' as key.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 10, 2015, 10 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 337
> > 
> >
> > let's pull fixes like this out separately. I'll gladly commit it as a 
> > distinct patch.

I would argue that this review is actually that distinct patch. It is not 
directly related to quota, shall I remove "quota" from the description and move 
that single comment to the next review for clarity?


> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 130
> > 
> >
> > Can you split out the removal of the namespaces (e.g. `std::` and 
> > `mesos::master::`) in to a separate review so that we can keep the quota 
> > specific changes concise?

As I mentioned above, this review is a basic refactoring, which removes 
namespaces and wrap role related stuff in a dedicated type.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39399/#review105806
---


On Nov. 5, 2015, 6:23 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39399/
> ---
> 
> (Updated Nov. 5, 2015, 6:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39399/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 359
> > 
> >
> > s/the/this

Re-phrasing it a bit deeper.


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 360
> > 
> >
> > Quota is satisfied before fair share, ...

Chose different phrasing.


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 137
> > 
> >
> > `Resources`

This is neither a type, nor an instance, but a proper english word.


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 416
> > 
> >
> > `resources`

This is neither a type, nor an instance, but a proper english word.


> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 582
> > 
> >
> > `resources`

This is neither a type, nor an instance, but a proper english word.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105817
---


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 40162: Updated docker build script to install libev package.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40162/#review105996
---


Bad patch!

Reviews applied: [39953, 39954, 39914]

Failed command: ./support/apply-review.sh -n -r 39914

Error:
 2015-11-10 23:48:16 URL:https://reviews.apache.org/r/39914/diff/raw/ [908/908] 
-> "39914.patch" [1]
error: patch failed: support/verify_reviews.py:115
error: support/verify_reviews.py: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 11:47 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40162/
> ---
> 
> (Updated Nov. 10, 2015, 11:47 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker build script to install libev package.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
> 
> Diff: https://reviews.apache.org/r/40162/diff/
> 
> 
> Testing
> ---
> 
> tested locally and on jenkins.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-10 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 11, 2015, 12:14 a.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

updated description.


Repository: mesos


Description (updated)
---

reviewbot builds dont use docker today. This change would make reviewbot 
environment to be same as mesos builds on jenkins which  uses docker.


Diffs
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese



Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/
---

(Updated Nov. 10, 2015, 10:27 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

see Summary.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39223/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 39628: Clear the suppressed flag when deactive a framework

2015-11-10 Thread Vinod Kone


> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote:
> > Can you please add a test that would have caught this issue?
> 
> Guangya Liu wrote:
> I think this is a bug, I tested without my code change, the test also 
> failed sometimes. Shall we file a bug for this?
> 
> Vinod Kone wrote:
> the failed test looks unrelated. please do file a bug. also, please write 
> a test for this change.
> 
> Guangya Liu wrote:
> JIRA ticket for this https://issues.apache.org/jira/browse/MESOS-3813
> 
> Guangya Liu wrote:
> Vinod, I found that the unit test can not cover this part as the test 
> framework cannot get the variable values in hierarchical.cpp. 
> 
> What I want to test is make sure the value of 
> frameworks[frameworkId].suppressed is false, but the problem is that the test 
> framework cannot get this value. Comments?
> 
> Guangya Liu wrote:
> Vinod, any comments on this? Thanks!

But you can test that a re-activated framework gets offers right? in other 
words, restart the framework after it calls suppress and make sure it gets 
offers.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review103957
---


On Oct. 30, 2015, 6:52 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> ---
> 
> (Updated Oct. 30, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clear the suppressed flag when deactive a framework
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39628/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make 
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-10 Thread Qian Zhang


> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1005
> > 
> >
> > For this TODO, what do we plan to do in future? Include the dynamic 
> > reserved resources for this role on this agent in 
> > ```roleConsumedResources```? And what about the static reserved resources?
> 
> Alexander Rukletsov wrote:
> Dynamic reservations should account towards role's quota. [Note about 
> static 
> reservations](https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?pli=1#heading=h.xumvch9xiky2)
> 
> Qian Zhang wrote:
> So when we check if a role's quota is satisfied or not, we will add the 
> role's allocated resources with the role's dynamically reserved resources, 
> and check if the sum contains the role's quota. But for role's statically 
> reserved resources, we will consider they are part of quota. So in future 
> (after these TODOs are handled) when we check if a role's quota is satified 
> or not, the formula should be ```(role's allocated resource + role's 
> dynamically reserved resources) > (role's quota + role's statically reserved 
> resources)```, right?

Alex, any comments for my question above? :-)


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review104656
---


On Nov. 10, 2015, 6:01 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> ---
> 
> (Updated Nov. 10, 2015, 6:01 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 14fef63714721fcda7cea3c28704766efda6d007 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-11-10 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review105805
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 10, 2015, 4:01 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Nov. 10, 2015, 4:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40129/
---

Review request for mesos, Joris Van Remoortere and Vinod Kone.


Bugs: MESOS-3868
https://issues.apache.org/jira/browse/MESOS-3868


Repository: mesos


Description
---

Updated apply-review.sh to use apply-reviews.py.


Diffs
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 

Diff: https://reviews.apache.org/r/40129/diff/


Testing
---


Thanks,

Artem Harutyunyan



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 10, 2015, 8:37 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad



Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Nov. 10, 2015, 12:03 a.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Summary (updated)
-

Added '--chain' option to apply-reviews.py.


Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859


Repository: mesos


Description
---

Added '--chain' option to apply-reviews.py.


Diffs
-

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- With and without '-c'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan



Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-10 Thread David Forsythe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 10, 2015, 8:33 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
  src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
103fe4b435e115857e2ebb071b6d88e2776736b5 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
9b2b8126f39d2b4014cfb637202670e6a06cdf56 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
e4202550af4deb0d355ca9ae6d71b40623f9 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
70501f1811fde5b636e5dcf751ef9356b8c7caef 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
3fd84e380f9393a6d46544fb7fc7d24bcb6256ac 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
f6ae9e8919fbd010c16918ddc78aa126b9da0062 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
2445c8132ee4af07482422f8563b408459c676b2 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
e883b402c32df4d7ed5edb906231500615a00da5 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
6fdb85b3d55339556b0982598d2e5258f6159466 
  src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 
  src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe



Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-10 Thread David Forsythe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39636/
---

(Updated Nov. 10, 2015, 8:33 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Add basic support to stout


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
fc2df6831ae2cb1a91c7a8cc92965939576e575d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
e9b05ef3b59fd068137cb12e36591de2d4a801a1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
0a98e9e310d3931c2341053595b7d62f68214783 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
8a8ede325cfe8f024e1be4db24b0c8118d18f359 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39636/diff/


Testing
---

make check on ubuntu 14.04

gmake check on FreeBSD 10.2 (failing, log attached)


File Attachments


check.log
  
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log


Thanks,

David Forsythe



Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

2015-11-10 Thread David Forsythe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
---

(Updated Nov. 10, 2015, 8:33 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
b73196cfa18e0d270e2533fbf733ad91e0559286 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
---

make check on ubuntu


Thanks,

David Forsythe



Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

2015-11-10 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38876/#review105807
---

Ship it!


Thanks, just some small cleanups and we should be all set. Would you mind 
adding a bit more context to the description to explain more specifically what 
the marker is used for?


src/slave/paths.hpp (line 185)


How about getExecutorHttpMarkerPath per my other suggestion?



src/slave/paths.cpp (line 53)


How about just HTTP_MARKER_FILE and "http.marker" to make this more 
symettric with the libprocess pid file stuff?


- Ben Mahler


On Nov. 7, 2015, 1:07 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38876/
> ---
> 
> (Updated Nov. 7, 2015, 1:07 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the relevant functionality to `src/slave/paths.cpp/hpp` to 
> store a marker file to denote HTTP based executors. We create the file when 
> `checkpointing` is enabled as part of handling the `Subscribe` request. This 
> is then used by the agent when recovering to ascertain if the executor was 
> connected via `HTTP` before the agent restart.
> 
> 
> Diffs
> -
> 
>   src/slave/paths.hpp f743fb4b1ca278fade9134e0ae8f6a6450d4a977 
>   src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 
> 
> Diff: https://reviews.apache.org/r/38876/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105772
---



src/master/quota_handler.cpp (line 75)


Add line



src/master/quota_handler.cpp (line 132)


Add line



src/master/quota_handler.cpp (line 146)


add 2 indents



src/master/quota_handler.cpp (line 149)


backticks



src/master/quota_handler.cpp (line 179)


roles



src/master/quota_handler.cpp (line 207)


validate



src/master/quota_handler.cpp (line 214)


`QuotaInfo`



src/master/quota_handler.cpp (line 218)


new line



src/master/quota_handler.cpp (line 223)


`QuotaInfo` quota request


- Joerg Schad


On Nov. 9, 2015, 11:30 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Nov. 9, 2015, 11:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> make test
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40129/#review105811
---


Patch looks great!

Reviews applied: [38705, 38883, 39410, 39420, 40129]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 8:02 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40129/
> ---
> 
> (Updated Nov. 10, 2015, 8:02 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-3868
> https://issues.apache.org/jira/browse/MESOS-3868
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated apply-review.sh to use apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
> 
> Diff: https://reviews.apache.org/r/40129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---

(Updated Nov. 10, 2015, 8:49 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
and Joris Van Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added /quota HTTP Endpoint for Quota handling.


Diffs (updated)
-

  src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36913/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-10 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39399/#review105806
---



src/master/allocator/mesos/hierarchical.hpp (line 337)


let's pull fixes like this out separately. I'll gladly commit it as a 
distinct patch.



src/master/allocator/mesos/hierarchical.hpp (line 354)


s/tie quota to/associate quota with/



src/master/allocator/mesos/hierarchical.cpp (lines 46 - 49)


can we move these up above with the other using declarations?



src/master/allocator/mesos/hierarchical.cpp (line 130)


Can you split out the removal of the namespaces (e.g. `std::` and 
`mesos::master::`) in to a separate review so that we can keep the quota 
specific changes concise?


- Joris Van Remoortere


On Nov. 5, 2015, 6:23 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39399/
> ---
> 
> (Updated Nov. 5, 2015, 6:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39399/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 10, 2015, 9:07 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joris Van Remoortere


> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > 
> >
> > I see that in the code, some are using 
> > 
> > '" << xxx << "'";
> > 
> > while some others are using
> > 
> > \"" << xxx << "\"";
> > 
> > What is the standard for different style?
> > 
> > Also when shall we need to add "" for one parameter in log message?
> 
> Alexander Rukletsov wrote:
> I think we are inconsistent. AFAIK, @neilc is doing some cleanup around.
> 
> Guangya Liu wrote:
> https://reviews.apache.org/r/39497 has been merged, it is using {{'" << 
> xxx << "'";}}, do we need to update this patch accordingly?

That review only sets the precedent for executor ids, which now have a 
streaming operator to take care of the formatting.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
---


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105817
---



src/master/allocator/mesos/hierarchical.hpp (line 358)


s/the/this



src/master/allocator/mesos/hierarchical.hpp (line 359)


Quota is satisfied before fair share, ...



src/master/allocator/mesos/hierarchical.cpp (line 137)


`Resources`



src/master/allocator/mesos/hierarchical.cpp (line 416)


`resources`



src/master/allocator/mesos/hierarchical.cpp (line 581)


`resources`



src/master/allocator/mesos/hierarchical.cpp (line 893)


s/numbers/numbers.



src/master/allocator/mesos/hierarchical.cpp (line 924)


Do you want to -symetrically to your todu when setting quota- print the 
actual quota removed?


- Joerg Schad


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Andrey Dyatlov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/
---

(Updated Nov. 10, 2015, 11 a.m.)


Review request for mesos, Alexander Rojas and Bernd Mathiske.


Bugs: MESOS-2783
https://issues.apache.org/jira/browse/MESOS-2783


Repository: mesos


Description
---

Documentation. Added a list of protocols supported by the Mesos fetcher as 
requested in MESOS-2783


Diffs (updated)
-

  docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 

Diff: https://reviews.apache.org/r/40087/diff/


Testing
---

Problem: In the description of the MESOS-2783 the list of protocols or schemas 
supported by the Mesos fetcher is requested. The bug is marked as resolved, but 
the documentation still doesn't contain this list. 
Solution: The list was made according to the following source files: 
src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.


Thanks,

Andrey Dyatlov



Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105818
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 10, 2015, 2 a.m., Andrey Dyatlov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> ---
> 
> (Updated Nov. 10, 2015, 2 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation. Added a list of protocols supported by the Mesos fetcher as 
> requested in MESOS-2783
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 
> 
> Diff: https://reviews.apache.org/r/40087/diff/
> 
> 
> Testing
> ---
> 
> Problem: In the description of the MESOS-2783 the list of protocols or 
> schemas supported by the Mesos fetcher is requested. The bug is marked as 
> resolved, but the documentation still doesn't contain this list. 
> Solution: The list was made according to the following source files: 
> src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
> 
> 
> Thanks,
> 
> Andrey Dyatlov
> 
>



Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40087/#review105819
---

Ship it!


Ship It!

- Jan Schlicht


On Nov. 10, 2015, 11 a.m., Andrey Dyatlov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40087/
> ---
> 
> (Updated Nov. 10, 2015, 11 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2783
> https://issues.apache.org/jira/browse/MESOS-2783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation. Added a list of protocols supported by the Mesos fetcher as 
> requested in MESOS-2783
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md af1d29b4df6b57e05e4e89e1f141344a67635733 
> 
> Diff: https://reviews.apache.org/r/40087/diff/
> 
> 
> Testing
> ---
> 
> Problem: In the description of the MESOS-2783 the list of protocols or 
> schemas supported by the Mesos fetcher is requested. The bug is marked as 
> resolved, but the documentation still doesn't contain this list. 
> Solution: The list was made according to the following source files: 
> src/launcher/fetcher.cpp, src/slave/containerizer/fetcher.cpp.
> 
> 
> Thanks,
> 
> Andrey Dyatlov
> 
>



Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Jan Schlicht


> On Nov. 9, 2015, 2:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > 
> >
> > Why not use `nullptr` instead?

Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not there 
yet. Also there's no mention of it in the C++ style guide.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
---


On Nov. 6, 2015, 8:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> ---
> 
> (Updated Nov. 6, 2015, 8:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [stout]: Added function to simultaneously query size and mtime of URI.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
> 
> Diff: https://reviews.apache.org/r/39594/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-11-10 Thread Joris Van Remoortere


> On Oct. 20, 2015, 10:35 p.m., Greg Mann wrote:
> >

The executor id now has a stream operator that takes care of this formatting.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39497/#review103320
---


On Oct. 21, 2015, 2:37 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39497/
> ---
> 
> (Updated Oct. 21, 2015, 2:37 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3772
> https://issues.apache.org/jira/browse/MESOS-3772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Specifically, we should always quote executor IDs (because they are
> user-supplied and might contain whitespace), but we don't need to quote
> framework IDs. There's a bunch more work we could do here (e.g., escaping
> punctuation), but this is a start.
> 
> Also fix a few style issues with usage of "<<" operators.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c99dc073f5ed5f635a41393ecb38ec13f21739d4 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef 
>   src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 
>   src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 
>   src/tests/containerizer.cpp 451c7be0bfd668ccd3325964cafcc4cbac941a94 
> 
> Diff: https://reviews.apache.org/r/39497/diff/
> 
> 
> Testing
> ---
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Till Toenshoff


> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > 
> >
> > Why not use `nullptr` instead?
> 
> Jan Schlicht wrote:
> Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not 
> there yet. Also there's no mention of it in the C++ style guide.
> 
> Benjamin Bannier wrote:
> I would have commented that since this file completely relies on `NULL` 
> instead of `nullptr` already consistence would suggest to stick to `NULL`.

I would interpret MESOS-3243 as a transition ticket for old, existing code and 
not for new code.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
---


On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> ---
> 
> (Updated Nov. 6, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [stout]: Added function to simultaneously query size and mtime of URI.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
> 
> Diff: https://reviews.apache.org/r/39594/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Nov. 10, 2015, 10 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota.hpp PRE-CREATION 
  src/master/quota.cpp PRE-CREATION 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---

make test


Thanks,

Joerg Schad



Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105816
---



src/master/allocator/mesos/hierarchical.hpp (line 358)


s/the order the role's/the order that the role's/
would make this more clear for me.



src/master/allocator/mesos/hierarchical.hpp (line 359)


s/Quota goes before fair share/Quota comes before fair share/



src/master/allocator/mesos/hierarchical.hpp (line 360)


s/towards the allocation queue's front./towards the front of the allocation 
queue./



src/master/allocator/mesos/hierarchical.cpp (line 140)


Maybe s/Introduce/Consider introducing/
Are we sure we want to do this?



src/master/allocator/mesos/hierarchical.cpp (line 225)


I think we can add an equivalent comment as above this for loop (not your 
fault):
`// Update the allocation to this framework.`



src/master/allocator/mesos/hierarchical.cpp (line 330)


same as above. let's add a comment here.



src/master/allocator/mesos/hierarchical.cpp (line 893)


let's clarify `just updates the numbers`. Also missing a period.



src/master/allocator/mesos/hierarchical.cpp (line 905)


A comment as to why we want to `allocate()` here would be useful.



src/master/allocator/mesos/hierarchical.cpp (line 926)


A comment here would be helpful as well.


- Joris Van Remoortere


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> ---
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier


> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > 
> >
> > Why not use `nullptr` instead?
> 
> Jan Schlicht wrote:
> Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not 
> there yet. Also there's no mention of it in the C++ style guide.

I would have commented that since this file completely relies on `NULL` instead 
of `nullptr` already consistence would suggest to stick to `NULL`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
---


On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> ---
> 
> (Updated Nov. 6, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [stout]: Added function to simultaneously query size and mtime of URI.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
> 
> Diff: https://reviews.apache.org/r/39594/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40129/#review105808
---


Bad patch!

Reviews applied: [38705, 38883, 39410]

Failed command: ./support/apply-review.sh -n -r 39410

Error:
 2015-11-10 08:15:10 URL:https://reviews.apache.org/r/39410/diff/raw/ 
[13493/13493] -> "39410.patch" [1]
error: support/apply-reviews.py: does not exist in index
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 8:02 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40129/
> ---
> 
> (Updated Nov. 10, 2015, 8:02 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-3868
> https://issues.apache.org/jira/browse/MESOS-3868
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated apply-review.sh to use apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
> 
> Diff: https://reviews.apache.org/r/40129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39636/#review105810
---


Bad patch!

Reviews applied: [39634]

Failed command: ./support/apply-review.sh -n -r 39634

Error:
 2015-11-10 08:34:51 URL:https://reviews.apache.org/r/39634/diff/raw/ 
[43330/43330] -> "39634.patch" [1]
error: src/CMakeLists.txt: does not exist in index
error: patch failed: src/Makefile.am:568
error: src/Makefile.am: patch does not apply
error: src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp: does 
not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp: does 
not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/puller.hpp: does not 
exist in index
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: does not 
exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp: 
does not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/store.cpp: does not 
exist in index
error: patch failed: src/slave/flags.hpp:53
error: src/slave/flags.hpp: patch does not apply
error: patch failed: src/slave/flags.cpp:120
error: src/slave/flags.cpp: patch does not apply
error: src/tests/containerizer/provisioner_docker_tests.cpp: does not exist in 
index
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 8:33 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39636/
> ---
> 
> (Updated Nov. 10, 2015, 8:33 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Add basic support to stout
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> dc7c6522b283916b975a77957909f6cdc02944d3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 9428717fac4655898d7768957f02937592e1a398 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> fc2df6831ae2cb1a91c7a8cc92965939576e575d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 
> 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 1baf142d53fd06149c80d4b2677c2a976c05ef71 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> e9b05ef3b59fd068137cb12e36591de2d4a801a1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 
> 0a98e9e310d3931c2341053595b7d62f68214783 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 8a8ede325cfe8f024e1be4db24b0c8118d18f359 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
> 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39636/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> gmake check on FreeBSD 10.2 (failing, log attached)
> 
> 
> File Attachments
> 
> 
> check.log
>   
> https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
> 
> 
> Thanks,
> 
> David Forsythe
> 
>



Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39288/
---

(Updated Nov. 10, 2015, 1:55 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3861
https://issues.apache.org/jira/browse/MESOS-3861


Repository: mesos


Description
---

Added authentication of quota requests.


Diffs
-

  src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39288/diff/


Testing
---

make check


Thanks,

Jan Schlicht



Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39289/
---

(Updated Nov. 10, 2015, 1:56 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Added authorization of quota requests.


Diffs
-

  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/quota/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
  src/master/quota_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 

Diff: https://reviews.apache.org/r/39289/diff/


Testing
---

make check


Thanks,

Jan Schlicht



Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 10, 2015, 12:52 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Updated comments.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/#review105842
---


This is supposed to be the fix (or workaround) for MESOS-3851, right? Let's 
please tag it in the "bugs" section. However, just as Vinod commented in that 
ticket, it seems the implications of the problem might really be bigger and not 
only localized to tbe command executor.

- Till Toenshoff


On Nov. 9, 2015, 9:37 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40107/
> ---
> 
> (Updated Nov. 9, 2015, 9:37 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused checks in command executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 
> 
> Diff: https://reviews.apache.org/r/40107/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40142/#review106002
---

Ship it!


Given that gmock ist not (and never should be, according to its authors) 
installed on the user machine but used as bundled dependencies, this could be 
done using quotation-marks;

```
#include "gmock/gmock.h"
```

However, the differences of sharp brackets and quotation-marks appears to be 
pretty much implementation specific, when looking at the standard. 

>6.10.2 Source file inclusion
>Constraints

>1 A #include directive shall identify a header or source file that can be 
>processed by the
>implementation.
>Semantics

>2 A preprocessing directive of the form
># include  new-line
>searches a sequence of implementation-defined places for a header identified 
>uniquely by
>the specified sequence between the < and > delimiters, and causes the 
>replacement of that
>directive by the entire contents of the header. How the places are specified 
>or the header
>identified is implementation-defined.

>3 A preprocessing directive of the form
># include "q-char-sequence" new-line
>causes the replacement of that directive by the entire contents of the source 
>file identified
>by the specified sequence between the " delimiters. The named source file is 
>searched
>for in an implementation-defined manner. If this search is not supported, or 
>if the search
>fails, the directive is reprocessed as if it read
># include  new-line
>with the identical contained sequence (including > characters, if any) from 
>the original
>directive

So our Mesos practice is not defined by standard limitations as the standard 
leaves pretty much everything to the implementation. On the other hand, the 
Mesos practice is definitely not uncommon - Xcode for example recommends using 
quotes for "user headers" and brackets for anthing else. For this specific case 
of a bundled but not installable dependency, I think we should stick with sharp 
brackets as this will allow quick recognition of non Mesos headers.

Thanks for this, Joerg!

- Till Toenshoff


On Nov. 10, 2015, 6:30 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40142/
> ---
> 
> (Updated Nov. 10, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-3879
> https://issues.apache.org/jira/browse/MESOS-3879
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected include order for gtest and gmock according to Styleguide.
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 8f63a2125b94646eac2a65d687508cdcbf239c1c 
>   src/tests/common/recordio_tests.cpp 
> db5e5c9d7241ba2d5d9486a9299177dfb0c505c7 
>   src/tests/containerizer.hpp dfa2c5bf733e944f2c22a36d0c071470dc90083d 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> d66f5198114c7bd67107ee056c2062d3118d1b4c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 4f152a4b01a8ea3d6c07aaef13319c67e0d6f99f 
>   src/tests/containerizer/isolator_tests.cpp 
> a7072124c7e5cf38ed41779c2d9e023e089bf28f 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 73634f88b3fc46fce66b17259c5f90b8d1c86f86 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9227666868801335003aeb0fa21e6b8f0e94f2cb 
>   src/tests/containerizer/sched_tests.cpp 
> 00723d01cd2cc37410d6f9fdd2de080063b7ccd8 
>   src/tests/credentials_tests.cpp 9d9de814bb1617d64f57dbf9425fe1e8135d2f46 
>   src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
>   src/tests/environment.cpp fd6ac2f88ef8f694c2a19018b6b4e4e34f08bd72 
>   src/tests/fault_tolerance_tests.cpp 
> 3e353e42e1051ff3d9e3be3707ff6bc7b5f348c8 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
>   src/tests/gc_tests.cpp 35701706bb16ff33d38d0dc6594bde0e011590f5 
>   src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c 
>   src/tests/hierarchical_allocator_tests.cpp 
> d422448606403fb39b077513ff73c6b9d41d2765 
>   src/tests/log_tests.cpp 4ff7a6a425dfa672f680b7072cbafad05b6249bf 
>   src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b 
>   src/tests/master_allocator_tests.cpp 
> 52fa472cbf764e0ed1dd334336f69774eb8c702b 
>   src/tests/master_authorization_tests.cpp 
> 0d1f2b5d9ce1a998651798624238f635aeac4995 
>   src/tests/master_contender_detector_tests.cpp 
> 84652b1fb57d36b3a7f05beda0a2af179c3ca3e8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7b0b983cae090ca5166d9fb1905fff88d3f21600 
>   src/tests/master_tests.cpp a754e3b3e78c639a473f79c1b24c505cc47ba1a9 
>   src/tests/master_validation_tests.cpp 
> 

Re: Review Request 40151: Windows: Implemented pids() to get all pids.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40151/#review106007
---


Patch looks great!

Reviews applied: [40151]

All tests passed.

- Mesos ReviewBot


On Nov. 11, 2015, 2:10 a.m., Matt Dotson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40151/
> ---
> 
> (Updated Nov. 11, 2015, 2:10 a.m.)
> 
> 
> Review request for Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented pids() to get all pids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40151/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Matt Dotson
> 
>



Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Guangya Liu


> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 159-186
> > 
> >
> > How to handle the following cases? Say two roles request quota: r1 and 
> > r2.
> > 
> > When r1 request quota as 5, the availableInCluster is 10 and r1 set 
> > quota succeed.
> > 
> > When r2 request quota as 7 again, the availableInCluster is still 10 as 
> > no one used resources in the cluster, so r2 set quota also succeed.
> > 
> > But now the quota for r1 and r2 is 12 which exceeds 10, is this a valid 
> > case? Thanks.
> 
> Alexander Rukletsov wrote:
> This is a sanity check, the precise bookkeeping and quota allocation is 
> done by an allocator module.

OK, got it. So we have two levels check, one is sanity check here and the other 
is precise bookkeeping in allocator. The first sanity check can get some early 
exception if there are not enough resources.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review104875
---


On Nov. 10, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 10, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov


> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote:
> > src/master/quota_handler.cpp, line 151
> > 
> >
> > So for this TODO, in future, we want to count dynamically reserved 
> > resources in ```roleTotal```, right? But in the code below, I see the 
> > dynamically reserved resources have already been counted in 
> > ```availableOnAgent```, so if we count it here as well, will it be double 
> > counted?

You're right, there is a danger that we end up doing double accounting after we 
add dynamic reservations. I'll add a todo to avoid that. Thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review105062
---


On Nov. 10, 2015, 10:52 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 10, 2015, 10:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan


> On Nov. 9, 2015, 2:09 p.m., Vinod Kone wrote:
> > Can you split this into 2 reviews? one adding --parent option and the other 
> > updating apply-review.sh to use apply-reviews.py?

Done.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105755
---


On Nov. 10, 2015, 12:03 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Nov. 10, 2015, 12:03 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--chain' option to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - With and without '-c'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/#review105832
---


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559]

Failed command: ./support/apply-review.sh -n -r 39559

Error:
 2015-11-10 11:35:47 URL:https://reviews.apache.org/r/39559/diff/raw/ 
[10306/10306] -> "39559.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:65
error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does not 
apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:83
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 11:10 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40131/
> ---
> 
> (Updated Nov. 10, 2015, 11:10 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.
> 
> 
> Diffs
> -
> 
>   bootstrap.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/
---

(Updated Nov. 10, 2015, 10:52 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Updated comments and minor naming issues.


Bugs: MESOS-3074
https://issues.apache.org/jira/browse/MESOS-3074


Repository: mesos


Description
---

Performs a check whether a quota request is reasonable and can be satisfied at 
the moment. A precise answer is impossible here, but a sanity check is still 
helpful, because it allows us to filter knowingly unsatisfiable requests.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38110/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov



Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/
---

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.


Diffs
-

  bootstrap.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/40131/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 40151: Windows: Implemented pids() to get all pids.

2015-11-10 Thread Matt Dotson

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40151/
---

(Updated Nov. 11, 2015, 2:01 a.m.)


Review request for mesos and Alex Clemmer.


Repository: mesos


Description
---

Windows: Implemented pids() to get all pids.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40151/diff/


Testing
---


Thanks,

Matt Dotson



Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/
---

Review request for mesos, Kapil Arya and Vinod Kone.


Bugs: MESOS-3834
https://issues.apache.org/jira/browse/MESOS-3834


Repository: mesos


Description
---

When performing an upgrade cycle, it is possible for a 0.24 and
later agent to recover from a framework checkpoint written by 0.22
or earlier. In this case, we need to compatibly accept a missing
FrameworkID, and then rewrite the framework checkpoint so that
subsequent upgrades don't hit the same problem.


Diffs
-

  src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
  src/slave/slave.cpp ac2d0e0153721a66495cd6539b25f5b3cee9d979 

Diff: https://reviews.apache.org/r/40177/diff/


Testing
---

make check on CentOS 6.7.
Manual testing with a rolling upgrade from 0.22


Thanks,

James Peach



Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review106018
---


Patch looks great!

Reviews applied: [40177]

All tests passed.

- Mesos ReviewBot


On Nov. 11, 2015, 5:59 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40177/
> ---
> 
> (Updated Nov. 11, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Kapil Arya and Vinod Kone.
> 
> 
> Bugs: MESOS-3834
> https://issues.apache.org/jira/browse/MESOS-3834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When performing an upgrade cycle, it is possible for a 0.24 and
> later agent to recover from a framework checkpoint written by 0.22
> or earlier. In this case, we need to compatibly accept a missing
> FrameworkID, and then rewrite the framework checkpoint so that
> subsequent upgrades don't hit the same problem.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp ac2d0e0153721a66495cd6539b25f5b3cee9d979 
> 
> Diff: https://reviews.apache.org/r/40177/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS 6.7.
> Manual testing with a rolling upgrade from 0.22
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-11-10 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/
---

(Updated Nov. 10, 2015, 2:27 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Updated based on BenM's review comments on r38876


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

This change adds the functionality for executors to `Subscribe` via the 
`api/v1/executor` endpoint. It also stores a marker file as part of the 
`Subscribe` call if framework `checkpointing` is enabled. This can then be used 
by the agent when recovering to wait for reconnecting back with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
`CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
the `Subscribe` call.


Diffs (updated)
-

  src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639 
  src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
  src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 

Diff: https://reviews.apache.org/r/38877/diff/


Testing
---

make check


Thanks,

Anand Mazumdar



Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105870
---


Patch looks great!

Reviews applied: [39594, 39595]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Nov. 10, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> 0b676f43e8529c6790824c8cf82e21a81d885ef1 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-10 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review105865
---



src/master/allocator/mesos/hierarchical.cpp (line 984)


laidAside are rejected resources? In that case I would prefer 
rejectedResources.



src/master/allocator/mesos/hierarchical.cpp (line 997)


s/comes first/is satisfied first



src/master/allocator/mesos/hierarchical.cpp (line 1003)


We can sum up resources as quota is only applicable to scalar resources.



src/master/allocator/mesos/hierarchical.cpp (line 1006)


Wouldn't it make sense to have a flag indicating when quota ia satisfied 
for the first time in this loop (i.e. foreach slave)? Otherwise we have to 
recheck this for every agent in the cluster


- Joerg Schad


On Nov. 9, 2015, 10:01 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> ---
> 
> (Updated Nov. 9, 2015, 10:01 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 14fef63714721fcda7cea3c28704766efda6d007 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/#review105872
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 10, 2015, 1:21 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40107/
> ---
> 
> (Updated Nov. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused checks in command executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 
> 
> Diff: https://reviews.apache.org/r/40107/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review106020
---


Patch looks great!

Reviews applied: [40177]

All tests passed.

- Mesos ReviewBot


On Nov. 11, 2015, 5:59 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40177/
> ---
> 
> (Updated Nov. 11, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Kapil Arya and Vinod Kone.
> 
> 
> Bugs: MESOS-3834
> https://issues.apache.org/jira/browse/MESOS-3834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When performing an upgrade cycle, it is possible for a 0.24 and
> later agent to recover from a framework checkpoint written by 0.22
> or earlier. In this case, we need to compatibly accept a missing
> FrameworkID, and then rewrite the framework checkpoint so that
> subsequent upgrades don't hit the same problem.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp ac2d0e0153721a66495cd6539b25f5b3cee9d979 
> 
> Diff: https://reviews.apache.org/r/40177/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS 6.7.
> Manual testing with a rolling upgrade from 0.22
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/#review105834
---


Patch looks great!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019, 39802, 39803, 39804, 
39805, 39834, 39850, 39851, 39852, 39888, 39889, 40102, 40131]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 11:10 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40131/
> ---
> 
> (Updated Nov. 10, 2015, 11:10 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.
> 
> 
> Diffs
> -
> 
>   bootstrap.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-11-10 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/#review105821
---



3rdparty/libprocess/include/process/event.hpp (line 145)


rename to `response`



3rdparty/libprocess/src/process.cpp (line 189)


All code related to this go to another patch.



3rdparty/libprocess/src/process.cpp (lines 2334 - 2336)


if we do move, remove this comment.



3rdparty/libprocess/src/process.cpp (line 2337)


No pointer +  std::move.



3rdparty/libprocess/src/process.cpp (lines 2341 - 2343)


Reuse similar comments for this code there.



3rdparty/libprocess/src/tests/http_tests.cpp (line 1178)


to separate patch, change other test and verify this one is actually needed.

Also write down that we need to reorder the ProcessBase::visit



3rdparty/libprocess/src/tests/http_tests.cpp (line 1183)


Remove.



3rdparty/libprocess/src/tests/http_tests.cpp (line 1218)


Try to reuse requests.


- Alexander Rojas


On Nov. 10, 2015, 4:58 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39276/
> ---
> 
> (Updated Nov. 10, 2015, 4:58 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3705
> https://issues.apache.org/jira/browse/MESOS-3705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When using the same socket to send multiple HTTP requests to different 
> actors. If the actor responsible for handling the first request is stuck 
> handling another event while a subsequent request can reply immediatly, the 
> order of the responses is altered violating HTTP Pipelining.
> 
> This patch fixes that problem enforcing that every response is sent in the 
> order the corresponding request arrived. It also adds a test to reproduce the 
> issue and verify the fix works.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/event.hpp 
> 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
>   3rdparty/libprocess/src/process.cpp 
> a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 7eb4ef187b2cb358c370d0381db65b8e18668bab 
> 
> Diff: https://reviews.apache.org/r/39276/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105824
---



src/slave/containerizer/fetcher.hpp (line 252)


Not yours, but this function can probably be const.



src/slave/containerizer/fetcher.cpp (line 247)


Newline after "(" to reduce jaggedness.



src/slave/containerizer/fetcher.cpp (line 262)


Newline after this line please.



src/slave/containerizer/fetcher.cpp (line 934)


4 spaces instead of 2 spaces.



src/slave/containerizer/fetcher.cpp (line 972)


Function can be made const.


- Jan Schlicht


On Nov. 6, 2015, 8:52 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Nov. 6, 2015, 8:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



  1   2   >