Review Request 41076: Added tests for implicit roles.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/ --- Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg Ma

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109281 --- The test failure that I noticed on Ubuntu 15.10 seems to occur with

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 8, 2015, 5:41 a.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 41076: Added tests for implicit roles.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/ --- (Updated Dec. 8, 2015, 5:44 a.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/#review109284 --- Patch looks great! Reviews applied: [40998] Passed command: expor

Review Request 41077: Fixed the license header in src/linux/ns.hpp.

2015-12-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41077/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109287 --- include/mesos/master/allocator.hpp (line 99)

Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/#review109288 --- Can you elaborate more without this fix what happened and why? - T

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Neil Conway
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to remov

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Jojy Varghese
> On Dec. 8, 2015, 7:08 a.m., Timothy Chen wrote: > > Can you elaborate more without this fix what happened and why? This fix moves "Accept" call before sending a response back to the client so that when the client sends the next request, the server is ready to accept it. Before this fix, ther

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Timothy Chen
> On Dec. 8, 2015, 7:08 a.m., Timothy Chen wrote: > > Can you elaborate more without this fix what happened and why? > > Jojy Varghese wrote: > This fix moves "Accept" call before sending a response back to the client > so that when the client sends the next request, the server is ready to

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review109294 --- Patch looks great! Reviews applied: [41026] Passed command: expor

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > I have talked with our shepherd Adam B yesterday, and we all agree to improve /roles endpoint to update/remove/list active roles, and Implicit Roles will focus on removing the static role list(specified by --roles flag) and let framework

<    1   2