Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109543 --- src/slave/cmake/FindCurl.cmake (line 18)

Re: Review Request 37703: Add docker exec command.

2015-12-09 Thread haosdent huang
> On Dec. 1, 2015, 3:09 a.m., Timothy Chen wrote: > > src/tests/containerizer/docker_tests.cpp, line 297 > > > > > > This isn't enough still, when the future is ready doesn't mean the > > container is actually

Re: Review Request 41092: Added CMake file for agent executable build.

2015-12-09 Thread Joseph Wu
> On Dec. 8, 2015, 7:30 p.m., Joseph Wu wrote: > > src/slave/CMakeLists.txt, line 42 > > > > > > The pre-commit hooks will complain about this line. > > Alex Clemmer wrote: > Ah, I didn't know this was true. I

<    1   2