Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote: > > src/master/master.cpp, line 527 > > > > > > Does it make sense to document this behavior (the master not starting > > if flag and no credentials) to either some

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/#review113273 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:46 p.m., Joerg Schad wrote: > > docs/configuration.md, line 344 > > > > > > How about: > > > > If true only authenticated requests for HTTP endpoint > > requiring authentification are

Re: Review Request 41943: Fixed stout protobuf::parse to support parsing JSON object containing JSON::Null.

> On Jan. 6, 2016, 6:36 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 344 > > > > > > You previously also had a test for a non-nested, but optional null > > string.

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113303 --- I haven't taken a close look at the tests yet. However, it may

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 7, 2016, 8:29 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/ --- (Updated Jan. 7, 2016, 8:29 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113318 --- Ship it! - Joerg Schad On Jan. 7, 2016, 8:29 p.m., Till

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113319 --- Patch looks great! Reviews applied: [42030] Passed command:

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 7, 2016, 12:22 p.m., Joseph Wu wrote: > > I haven't taken a close look at the tests yet. However, it may benefit you > > to add tests (preferably in separate reviews) for: > > > > + Dynamic reservations + optimistic offers. Make sure the new reservations > > show up as allocation

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

> On Jan. 6, 2016, 3:32 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 712-723 > > > > > > Suggestion: > > ``` > > if (role.isSome() && role.get() != resource.role()) { > > return false; >

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:46 p.m., Joerg Schad wrote: > > docs/configuration.md, line 344 > > > > > > How about: > > > > If true only authenticated requests for HTTP endpoint > > requiring authentification are

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113279 --- Patch looks great! Reviews applied: [41649] Passed command:

Review Request 42029: Logger Module: Add to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42029/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Alex Clemmer.

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review113227 --- Ship it! Committing this now, with the below change.

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote: > > src/master/master.cpp, line 527 > > > > > > Does it make sense to document this behavior (the master not starting > > if flag and no credentials) to either some

Re: Review Request 42029: Logger Module: Add to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42029/#review113295 --- Patch looks great! Reviews applied: [42029] Passed command:

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 6, 2016, 4:31 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113293 --- src/master/flags.cpp (line 212)

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113301 --- docs/configuration.md (line 344)

Review Request 42035: Windows: Remove the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/ --- (Updated Jan. 7, 2016, 9:44 p.m.) Review request for mesos, Alex Naparu,

Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113335 --- Patch looks great! Reviews applied: [41429] Passed command:

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113336 --- Ship it! Minor suggestions, but otherwise looks great Thanks!

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113339 --- Ship it! LGTM! It should be more appropriate to use `Option`

Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41612/#review113331 --- Ship it! Ship It! - Jie Yu On Jan. 6, 2016, 8:59 p.m., Greg

Re: Review Request 41986: Fixed race in persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41986/#review113332 --- Ship it! Thanks for triaging this! - Jie Yu On Jan. 6, 2016,

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41989/#review11 --- Ship it! Ship It! - Jie Yu On Jan. 6, 2016, 8:51 p.m., Greg

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review113345 --- Bad patch! Reviews applied: [42036] Failed command:

Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41814/#review113344 --- Ship it! include/mesos/slave/isolator.proto (line 21)

Re: Review Request 41999: Cleaned up unnecessary parameter in provisioner constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41999/#review113347 --- Ship it! Ship It! - Jie Yu On Jan. 6, 2016, 11:40 p.m.,

<    1   2