Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44655/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
  src/executor/executor.cpp c3e95ea7e4edf78f2a65ddc15e213aba66e69db2 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44655/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44656: Introduced `KillPolicy` protobuf.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44656/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 

Diff: https://reviews.apache.org/r/44656/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44628: Fixed a comment and ordering in mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44628/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 

Diff: https://reviews.apache.org/r/44628/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44630/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 
  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 

Diff: https://reviews.apache.org/r/44630/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 43763: Passed `Duration` as const reference in the executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43763/
---

(Updated March 10, 2016, 5:14 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/43763/diff/


Testing (updated)
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44626: Fixed whitespaces in mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44626/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 

Diff: https://reviews.apache.org/r/44626/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44651: Fixed formatting in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44651/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44651/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44634: Updated the log message in the HTTP API executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44634/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/executor/executor.cpp c3e95ea7e4edf78f2a65ddc15e213aba66e69db2 

Diff: https://reviews.apache.org/r/44634/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122937
---



Patch looks great!

Reviews applied: [44318, 44319, 44320, 44322]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 2:15 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> ---
> 
> (Updated March 10, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implements the [Generic Authorizer Interface v 
> 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
> 
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto PRE-CREATION 
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/authorizer/local/authorizer.hpp 
> c87a9915bae6bae7744bd57abd12e8d857181051 
>   src/authorizer/local/authorizer.cpp 
> 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
>   src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
>   src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
>   src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
> 
> Diff: https://reviews.apache.org/r/44322/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 44653: Fixed formatting in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44653/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44653/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44629: Fixed ordering and inconsistencies in slave constants.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44629/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 

Diff: https://reviews.apache.org/r/44629/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44654/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4911
https://issues.apache.org/jira/browse/MESOS-4911


Repository: mesos


Description
---

Executor shutdown grace period, which configured on the agent, is
propagated to executors via the `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`
environment variable. The executor library uses this timeout to delay
the hard shutdown of the related executor.


Diffs
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44654/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44662/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  CHANGELOG 1fbf3029d35207041b5204ed5754a412d5870b3c 

Diff: https://reviews.apache.org/r/44662/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44635: Corrected the log message and variable name in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44635/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44635/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44650: Omitted names of unused parameters in executor library.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44650/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e 

Diff: https://reviews.apache.org/r/44650/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44652: Omitted names of unused parameters in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44652/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 

Diff: https://reviews.apache.org/r/44652/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44631: Cleaned up the comment around executor shutdown event.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44631/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/executor/executor.proto 
a67dbad458e24b22875cf15b73b64c14a084b1ea 
  include/mesos/v1/executor/executor.proto 
c4ad0b4ac6a4e8def013b276877a9c0a5264d4e9 

Diff: https://reviews.apache.org/r/44631/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44657: Used `KillPolicy` in command executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44657/
---

Review request for mesos, Ben Mahler and Gilbert Song.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44657/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44659: Updated the comment about docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44659/
---

Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44659/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44627: Removed a stale comment in the 1.0 mesos.proto.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44627/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 

Diff: https://reviews.apache.org/r/44627/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44661: Deprecated the `docker_stop_timeout` flag.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44661/
---

Review request for mesos, Ben Mahler and Timothy Chen.


Bugs: MESOS-4910
https://issues.apache.org/jira/browse/MESOS-4910


Repository: mesos


Description
---

Instead, a combination of `executor_shutdown_grace_period`
agent flag and task kill policies should be used.


Diffs
-

  docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
  src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 

Diff: https://reviews.apache.org/r/44661/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44658: Removed unused signal escalation constant.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44658/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 

Diff: https://reviews.apache.org/r/44658/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44515: Added agent flags for HTTP authentication.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review122892
---



Looks great! Just some minor nits and a question about authenticating http 
requests even if --authenticate_http=false doesn't require authentication.


src/slave/constants.cpp (line 56)


"accommodate" (two 'm's)



src/slave/flags.cpp (line 679)


No need for the final '\n'



src/slave/flags.cpp (line 684)


I wonder if/when we'll ever deprecate one of these formats.
https://issues.apache.org/jira/browse/MESOS-2281



src/slave/flags.cpp (lines 685 - 686)


Can't these lines be joined?



src/slave/flags.cpp (lines 688 - 689)


Can't these lines be joined?



src/slave/slave.cpp (line 353)


s/At least...specified/If the http_authenticators flag is not specified, 
the default value will be filled in./



src/slave/slave.cpp (lines 364 - 365)


How about you just put the whole `"' not "` on the second line with 
`"found..."`



src/slave/slave.cpp (line 366)


s/''/'/?



src/slave/slave.cpp (line 372)


So we only load the authenticators and even allow authentication if 
--authenticate_http is set? My understanding is that --authenticate_http=false 
means that both authenticated and unauthenticated requests will be allowed, but 
--authenticate_http=true means that we /require/ all requests to be 
authenticated. That's what the flag help seems to imply.
Maybe that behavior's only really true for authenticate_frameworks and 
authenticate_slaves



src/tests/mesos.cpp (lines 182 - 184)


Any reason you can't reuse the previous `path` and `fd` variables?



src/tests/mesos.cpp (line 203)


s/credentials/http credentials/


- Adam B


On March 9, 2016, 12:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> ---
> 
> (Updated March 9, 2016, 12:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flags for HTTP authentication.
> 
> Three command-line flags have been added to the agent to enable HTTP 
> authentication: `--authenticate_http`, `--http_credentials`, and 
> `--http_authenticators`.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
> 
> Diff: https://reviews.apache.org/r/44515/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review122901
---



Can you add some tests for these endpoints that show that hitting them with a 
bad credential will fail with status Unauthorized? See 
`TeardownTest.TeardownEndpointBadCredentials` or 
`PersistentVolumeEndpointsTest.BadCredentials`.

- Adam B


On March 9, 2016, 9:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 9, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and `sudo make check` was used to test on both OSX and Ubuntu 
> 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

[Adam B]

> On March 9, 2016, 8:02 p.m., Alexander Rojas wrote:
> > I just did a grep and I found this:
> > 
> > ```sh
> > $ ag --cpp --ignore="build/.*" '\"mesos\"' .
> > # ...
> > src/authentication/http/basic_authenticator_factory.cpp
> > 66:  Authenticator* authenticator = new BasicAuthenticator("mesos", 
> > credentials);
> > 
> > src/master/constants.hpp
> > 136:// Name of the default, "mesos" HTTP authentication realm.
> > # ...
> > ```
> > 
> > at least those two need to be changed.

Hmm, if the first one is used by both master and agent, then we might need to 
pass the realm as a parameter to the factory's create method.
Good call with the grep, Alexander.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
---


On March 9, 2016, 12:42 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> ---
> 
> (Updated March 9, 2016, 12:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
> https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122900
---



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated March 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/#review122897
---




include/mesos/mesos.proto (line 443)


Also added in v1 APIs?



src/master/validation.cpp (lines 381 - 382)


move `{` into one line.


- Klaus Ma


On March 9, 2016, 11:48 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44570/
> ---
> 
> (Updated March 9, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4772
> https://issues.apache.org/jira/browse/MESOS-4772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To be able to authenticate HTTP requests for tasks, the authorizer has to
> determine who owns the tasks. This is achieved by adding an owner field to
> TaskInfo and ExecutorInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/tests/master_validation_tests.cpp 
> c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
> 
> Diff: https://reviews.apache.org/r/44570/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122902
---


Fix it, then Ship it!




Looks good. Just some alpha-order nits, mostly.


src/CMakeLists.txt (lines 24 - 26)


re-alphabetize



src/CMakeLists.txt (lines 56 - 58)


re-alphabetize



src/Makefile.am (lines 409 - 411)


re-alphabetize



src/authorizer/authorizer.cpp (line 41)


Double-blank line between impls, please


- Adam B


On March 9, 2016, 6:07 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 9, 2016, 6:07 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

[Martin Bydzovsky]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44581/
---

Review request for mesos.


Repository: mesos


Description
---

fixed docker's stdout/stderr streams got corrupted after calling docker->stop.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44581/diff/


Testing
---


Thanks,

Martin Bydzovsky

Re: Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44581/#review122909
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On March 10, 2016, 10:12 a.m., Martin Bydzovsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44581/
> ---
> 
> (Updated March 10, 2016, 10:12 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> fixed docker's stdout/stderr streams got corrupted after calling docker->stop.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
> 
> Diff: https://reviews.apache.org/r/44581/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Bydzovsky
> 
>

Re: Review Request 44186: Added authentication to master endpoints.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44186/
---

(Updated March 10, 2016, 10:31 a.m.)


Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.


Changes
---

Addressed review and rebased.


Bugs: MESOS-4844
https://issues.apache.org/jira/browse/MESOS-4844


Repository: mesos


Description
---

Added Authentication to master http endpoints (except version, health, 
redirect, scheduler).


Diffs (updated)
-

  src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
  src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 
  src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/status_update_manager_tests.cpp 
d64d3b8c96270478f6b681c038de77c3a9eb68fe 

Diff: https://reviews.apache.org/r/44186/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

[Joerg Schad]

> On March 10, 2016, 6:26 a.m., Adam B wrote:
> > Can you add some tests for these endpoints that show that hitting them with 
> > a bad credential will fail with status `Unauthorized`? See 
> > `TeardownTest.TeardownEndpointBadCredentials` or 
> > `PersistentVolumeEndpointsTest.BadCredentials`.

I will add an additional review for those tests.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44186/#review122886
---


On March 10, 2016, 10:31 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44186/
> ---
> 
> (Updated March 10, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Authentication to master http endpoints (except version, health, 
> redirect, scheduler).
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
>   src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/master_maintenance_tests.cpp 
> 3faa8136cf57276295553910319480028f433e4c 
>   src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
>   src/tests/status_update_manager_tests.cpp 
> d64d3b8c96270478f6b681c038de77c3a9eb68fe 
> 
> Diff: https://reviews.apache.org/r/44186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44186: Added authentication to master endpoints.

[Joerg Schad]

> On March 10, 2016, 6:26 a.m., Adam B wrote:
> > src/tests/master_maintenance_tests.cpp, line 129
> > 
> >
> > Why set this to false and then still createBasicAuthHeaders for these 
> > tests?
> > Why can't we keep this at `true`?

Done.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44186/#review122886
---


On March 10, 2016, 10:31 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44186/
> ---
> 
> (Updated March 10, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Authentication to master http endpoints (except version, health, 
> redirect, scheduler).
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
>   src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/master_maintenance_tests.cpp 
> 3faa8136cf57276295553910319480028f433e4c 
>   src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
>   src/tests/status_update_manager_tests.cpp 
> d64d3b8c96270478f6b681c038de77c3a9eb68fe 
> 
> Diff: https://reviews.apache.org/r/44186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122905
---



Patch looks great!

Reviews applied: [44318, 44319, 44320, 44322]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 7:34 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> ---
> 
> (Updated March 10, 2016, 7:34 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implements the [Generic Authorizer Interface v 
> 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
> 
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto PRE-CREATION 
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/authorizer/local/authorizer.hpp 
> c87a9915bae6bae7744bd57abd12e8d857181051 
>   src/authorizer/local/authorizer.cpp 
> 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
>   src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
>   src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
>   src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
> 
> Diff: https://reviews.apache.org/r/44322/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
---

(Updated March 10, 2016, 3:10 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description (updated)
---

Implements the [Generic Authorizer Interface v 
0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).

It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051 
  src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
  src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
  src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
  src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 

Diff: https://reviews.apache.org/r/44322/diff/


Testing
---

make -j4 check


Thanks,

Alexander Rojas

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

> On March 10, 2016, 10:14 a.m., Adam B wrote:
> > src/authorizer/authorizer.cpp, lines 43-44
> > 
> >
> > Double-blank line between impls, please

screw up while rebasing.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review122902
---


On March 9, 2016, 3:07 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44320/
> ---
> 
> (Updated March 9, 2016, 3:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is the first step towards separating the language used to define
> the ACLs from the mechanism to query them.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.hpp PRE-CREATION 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   include/mesos/authorizer/authorizer.proto  
>   src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/authorizer/acls.cpp PRE-CREATION 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
>   src/examples/persistent_volume_framework.cpp 
> 4218b1563e10aaefe9abcdc20c90c13651959790 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
> 
> Diff: https://reviews.apache.org/r/44320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description
---

see summary


Diffs
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
---

(Updated March 10, 2016, 3:15 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description (updated)
---

Implements the [Generic Authorizer Interface v 
0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).

It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051 
  src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
  src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
  src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 
  src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 
  src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 

Diff: https://reviews.apache.org/r/44322/diff/


Testing
---

make -j4 check


Thanks,

Alexander Rojas

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/
---

(Updated March 10, 2016, 1:49 p.m.)


Review request for mesos, Adam B and Joerg Schad.


Changes
---

Addressed some issues.


Bugs: MESOS-4772
https://issues.apache.org/jira/browse/MESOS-4772


Repository: mesos


Description
---

To be able to authenticate HTTP requests for tasks, the authorizer has to
determine who owns the tasks. This is achieved by adding an owner field to
TaskInfo and ExecutorInfo.


Diffs (updated)
-

  include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
  include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
  src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/tests/master_validation_tests.cpp 
c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 

Diff: https://reviews.apache.org/r/44570/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

[Jan Schlicht]

> On March 10, 2016, 9:22 a.m., Klaus Ma wrote:
> > include/mesos/mesos.proto, line 443
> > 
> >
> > Also added in v1 APIs?

Oh sure, good catch!


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/#review122897
---


On March 9, 2016, 4:48 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44570/
> ---
> 
> (Updated March 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4772
> https://issues.apache.org/jira/browse/MESOS-4772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To be able to authenticate HTTP requests for tasks, the authorizer has to
> determine who owns the tasks. This is achieved by adding an owner field to
> TaskInfo and ExecutorInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/tests/master_validation_tests.cpp 
> c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
> 
> Diff: https://reviews.apache.org/r/44570/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/
---

(Updated March 10, 2016, 3:09 p.m.)


Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.


Changes
---

Adresses adam's review.


Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950


Repository: mesos


Description
---

This is the first step towards separating the language used to define
the ACLs from the mechanism to query them.


Diffs (updated)
-

  include/mesos/authorizer/acls.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp 
705482656788ac12e9d21e355b71fd2ede2be558 
  include/mesos/authorizer/authorizer.proto  
  src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f 
  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/authorizer/acls.cpp PRE-CREATION 
  src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
  src/common/parse.hpp 78c7cf12ca6a475305254177db6b6b2319a1f72f 
  src/examples/persistent_volume_framework.cpp 
4218b1563e10aaefe9abcdc20c90c13651959790 
  src/examples/test_authorizer_module.cpp 
95d77fbff0cdfdb360a8597fbba28404b59d0042 
  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 

Diff: https://reviews.apache.org/r/44320/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 44186: Added authentication to master endpoints.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44186/#review122914
---



Patch looks great!

Reviews applied: [44286, 44186]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 10:31 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44186/
> ---
> 
> (Updated March 10, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Authentication to master http endpoints (except version, health, 
> redirect, scheduler).
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
>   src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/master_maintenance_tests.cpp 
> 3faa8136cf57276295553910319480028f433e4c 
>   src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
>   src/tests/status_update_manager_tests.cpp 
> d64d3b8c96270478f6b681c038de77c3a9eb68fe 
> 
> Diff: https://reviews.apache.org/r/44186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

[Jan Schlicht]

> On March 10, 2016, 7:31 a.m., Adam B wrote:
> > src/master/validation.cpp, line 381
> > 
> >
> > It may be sufficient to only check `if (task.has_owner() && 
> > task.has_executor())` since a custom executor should set the owner on the 
> > ExecutorInfo not the TaskInfo.

That is if the `ExecutorInfo` is reused in a `TaskInfo` it's sufficient to 
check for that? That makes sense because the `ExecutorInfo` validation compares 
the `ExecutorId` against the ones of existing `ExecutorInfo`s. But how'd we 
make sure that the owner is set in `ExecutorInfo` if that executor isn't 
existing yet?


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/#review122887
---


On March 9, 2016, 4:48 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44570/
> ---
> 
> (Updated March 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4772
> https://issues.apache.org/jira/browse/MESOS-4772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To be able to authenticate HTTP requests for tasks, the authorizer has to
> determine who owns the tasks. This is achieved by adding an owner field to
> TaskInfo and ExecutorInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/tests/master_validation_tests.cpp 
> c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
> 
> Diff: https://reviews.apache.org/r/44570/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/#review122956
---


Fix it, then Ship it!





src/master/http.cpp (line 1849)


`s/taskWriter/tasksWriter/`?


- Michael Park


On Feb. 29, 2016, 6:55 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43823/
> ---
> 
> (Updated Feb. 29, 2016, 6:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/tasks` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
> 
> Diff: https://reviews.apache.org/r/43823/diff/
> 
> 
> Testing
> ---
> 
> make check. Also verified that this endpoint is covered by the unit tests.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
---

(Updated March 10, 2016, 7:15 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

The createFromModule will be used to create a MasterContender/Detector
from a module (specified using the --modules flag on the command
line).


Diffs
-

  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44669/diff/


Testing
---


Thanks,

Anurag Singh

Review Request 44670: Added master_detector and master_contender flags.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44670/
---

Review request for mesos.


Repository: mesos


Description
---

The master_detector and master_contender flags allow modules to be
used for specifying the MasterContender and MasterDetector
implementations to use.


Diffs
-

  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 

Diff: https://reviews.apache.org/r/44670/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44319: Removed initialize method from the authorizer interface.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review122961
---


Fix it, then Ship it!




Looks good. Some minor comments.


include/mesos/authorizer/authorizer.hpp (line 61)


s/returned value/the authorizer/



src/authorizer/local/authorizer.hpp (line 50)


Add a comment for this?



src/authorizer/local/authorizer.cpp (line 353)


s/stringAcls/acls/



src/authorizer/local/authorizer.cpp (line 364)


s/acls/acls_/



src/local/local.cpp (line 228)


s/create/authorizer/



src/local/local.cpp (line 243)


s/authorizer/authorizer_/



src/master/main.cpp (line 372)


So, we create non-default authorizer if --authorizers specifies a 
non-default name but create the default authorizer only if --acls is present 
(irrespective of whether --authorizers says "local)". 

I think those semantics are a bit weird to grok. IIRC, we did it that way 
for backwards compatibility with old releases that didn't have "--authorizers" 
flag? We should atleast mention this behavior in the flags help.



src/tests/cluster.cpp (line 175)


s/create/authorizer/


- Vinod Kone


On March 9, 2016, 2:06 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44319/
> ---
> 
> (Updated March 9, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed initialize method from the authorizer interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 705482656788ac12e9d21e355b71fd2ede2be558 
>   src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 
>   src/authorizer/local/authorizer.hpp 
> c87a9915bae6bae7744bd57abd12e8d857181051 
>   src/authorizer/local/authorizer.cpp 
> 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 
>   src/examples/test_authorizer_module.cpp 
> 95d77fbff0cdfdb360a8597fbba28404b59d0042 
>   src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
> 
> Diff: https://reviews.apache.org/r/44319/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 44026: Moved future tests into future_tests.cpp.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review122949
---


Ship it!




Ship It!

- Michael Park


On March 9, 2016, 7:25 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> ---
> 
> (Updated March 9, 2016, 7:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved future tests into future_tests.cpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> ded1aaed25876d45e33b4a27fffc6a5c46ca92f5 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> e9bf80ee69f4add299cb828ed3245ac07398943c 
> 
> Diff: https://reviews.apache.org/r/44026/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44666: Fixed typos in comments in libprocess.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44666/#review122950
---


Ship it!




Ship It!

- Cong Wang


On March 10, 2016, 6:13 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44666/
> ---
> 
> (Updated March 10, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in comments in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5dae1e71f0cdedd22028bb3657ffad35f776b1c7 
> 
> Diff: https://reviews.apache.org/r/44666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

[Neil Conway]

> On March 10, 2016, 7:16 a.m., Adam B wrote:
> > src/master/http.cpp, lines 1166-1167
> > 
> >
> > Why is the space removed here?
> > Do we need to put a space after `JSON` instead?

TLDR processing inserts newlines automatically between strings; a space is not 
required after 'JSON', and isn't useful before 'and'. For reference, see how 
the other TLDR strings work.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review122889
---


On March 9, 2016, 6:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 44666: Fixed typos in comments in libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44666/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed typos in comments in libprocess.


Diffs
-

  3rdparty/libprocess/src/process.cpp 5dae1e71f0cdedd22028bb3657ffad35f776b1c7 

Diff: https://reviews.apache.org/r/44666/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 44666: Fixed typos in comments in libprocess.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44666/#review122952
---


Ship it!




Ship It!

- Jie Yu


On March 10, 2016, 6:13 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44666/
> ---
> 
> (Updated March 10, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in comments in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5dae1e71f0cdedd22028bb3657ffad35f776b1c7 
> 
> Diff: https://reviews.apache.org/r/44666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44584: Improved docs for dynamic weights.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44584/
---

(Updated March 10, 2016, 6:40 p.m.)


Review request for mesos, Adam B and Yongqiao Wang.


Changes
---

Address comments.


Repository: mesos


Description
---

Improved docs for dynamic weights.


Diffs (updated)
-

  docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
  docs/roles.md 65d6ddf46ac394389c70a3faf5cc85c5cf892478 
  docs/weights.md dec2ddd6516d2d3a9926f6410f8309eb2de40c3c 
  src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28 

Diff: https://reviews.apache.org/r/44584/diff/


Testing
---

Previewed via site-docker.


Thanks,

Neil Conway

Re: Review Request 44670: Added master_detector and master_contender flags.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44670/
---

(Updated March 10, 2016, 7:16 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

The master_detector and master_contender flags allow modules to be
used for specifying the MasterContender and MasterDetector
implementations to use.


Diffs
-

  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 

Diff: https://reviews.apache.org/r/44670/diff/


Testing (updated)
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Anurag Singh

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43911/#review122958
---




src/slave/http.cpp (lines 89 - 105)


This needs to be defined in the namespace that `TaskInfo` is defined, that 
is, in the `mesos` namespace.



src/slave/http.cpp (line 97)


If we were using `model` before, we need to maintain that.

We have a `json` defined for `CommandInfo` in `src/common/http.cpp`, we 
should add the declaration `void json(JSON::ObjectWriter* writer, const 
CommandInfo& command);` to `src/common/http.hpp`.

We can then use it like this:

```
writer->field("command", task.command());
```



src/slave/http.cpp (line 125)


Same as above, since we were using `model` before, we need to maintain 
this. We just need to remove the `JSON::Protobuf` here.

```
writer->element(task);
```



src/slave/http.cpp (line 493)


Curious as to why we added a newline here.



src/slave/http.cpp (line 497)


Same here, why the newline?


- Michael Park


On Feb. 29, 2016, 7:01 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43911/
> ---
> 
> (Updated Feb. 29, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/state` agent endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/43911/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Jie Yu]

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote:
> > include/mesos/v1/mesos.proto, lines 1543-1544
> > 
> >
> > We're going to introduce a ContainerInfo.NetworkInfo.name to allow 
> > frameworks to specify the network they want to join. Note that  NetworkInfo 
> > in ContainerInfo is repeated which allows us to express the situation where 
> > a container wants to join multiple networks.
> > 
> > As we did for ContainerInfo.volumes, I think command configurations for 
> > a container should go to top level. This also avoids the confusion that 
> > 'network_name' is set in DockerInfo while there's another NetworkInfo.name.
> > 
> > I think what I am proposing is that: we add a NetworkInfo.name, and if 
> > DOckerInfo.network is not set and NetworkInfo.name is set, the docker 
> > containerizer will do --net=.
> 
> Guangya Liu wrote:
> Does it make sense to use the `repeated string groups` field in 
> NetworkInfo? I think that we can treate the groups as different user defined 
> networks. If we added `repeated string names` field, then what are the 
> difference between those two fields?
> 
> `
> // A group is the name given to a set of logically-related interfaces that
> // are allowed to communicate among themselves. Network traffic is allowed
> // between two container interfaces that share at least one network group.
> // For example, one might want to create separate groups for isolating 
> dev,
> // testing, qa and prod deployment environments.
> repeated string groups = 3;
> `
> 
> Jie Yu wrote:
> What i am suggesting is to add a singular name field:
> ```
> message NetworkInfo {
>   optional string name;
> }
> ```
> 
> NetworkInfo itself is repeated in ContainerInfo
> 
> Guangya Liu wrote:
> Thanks Yu Jie, still a bit confused, can you please explain more? :-)
> 
> What is the advantage of adding the following instead of `optional string 
> network_name = 8;`? 
> 
> message NetworkInfo {
>   optional string name;
> }
> 
> Also once add a singular `NetworkInfo`, do we still need to add the 
> `optional string network_name` field?
> 
> Qian Zhang wrote:
> I think what we are going to do is to add a singular `name` field in the 
> existing `NetworkInfo` message rather than to add a singular `NetworkInfo` 
> message.
> 
> Guangya Liu wrote:
> @Ezra, FYI, There is a JIRA 
> https://issues.apache.org/jira/browse/MESOS-4758 trying to add `name` to 
> `NetworkInfo`
> 
> Ezra Silvera wrote:
> @gyliu - is https://issues.apache.org/jira/browse/MESOS-4758 already 
> merged?  If not I suggest to merge this change and then when that request is 
> merged we can easily go and change the code to use that field. It seems we 
> keep moving gin circles here on a relatively simple change which prohibit us 
> to use user-networks from our Swarm based cloud..
> 
> Guangya Liu wrote:
> @Ezra, not yet. I think that you can get some comments from @jieyu for 
> this.

@Ezra @gyliu, sorry about the delay. MESOS-4758 just got merged.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119730
---


On Feb. 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
---

Review request for mesos.


Repository: mesos


Description
---

The createFromModule will be used to create a MasterContender/Detector
from a module (specified using the --modules flag on the command
line).


Diffs
-

  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44669/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43910/#review122957
---


Ship it!




Ship It!

- Michael Park


On Feb. 29, 2016, 6:55 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43910/
> ---
> 
> (Updated Feb. 29, 2016, 6:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enhanced a test case for the `/state` agent endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/43910/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Note that we don't currently check the conversion of `TaskInfo` -> JSON, 
> which is used for `queuedTasks`. Would be nice to improve the test case so 
> that the slave has a queued task, although this will probably require some 
> `DROP_MESSAGE` trickery...
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44342: XFS disk resource isolator.

[Jiang Yan Xu]

> On March 9, 2016, 10:03 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 573-576
> > 
> >
> > We do need to handle orphans, as you've commented in `cleanup()`.
> > 
> > `orphans` here are known to the containerizer so `cleanup()` will be 
> > called by it to remove the quota. However if there's not an entry for it in 
> > `infos`, `cleanup()` ignores it.
> > 
> > The concern is that if the project ID of the orphan is not unassigned 
> > from the sandbox and the ID is not tracked by the isolator, next time it's 
> > used by a new task, it'll share the same quota with the orphan.

OK it looks to me that we do need to recursively scan all the sandboxes (we can 
probably `glob` them) and determine whether they belong to an recovered 
container, known orphan and unknown orphan and then clean up the extraneous 
ones.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review122156
---


On March 7, 2016, 10:38 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 7, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac a20382e8d425eb297492a6e6c2c75ea59be097c2 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44652: Omitted names of unused parameters in command executor.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44652/#review122944
---


Fix it, then Ship it!





src/launcher/executor.cpp (line 124)


Not sure whether we have a real style for that, but the example I seen (and 
used myself) are to comment the name. See 
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/openssl.cpp#L155
 for an example.
In this case I don't believe it makes a large difference as the Type is 
descriptive enough, but that might be different with more general types 
(imagine a string).


- Joerg Schad


On March 10, 2016, 5:14 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44652/
> ---
> 
> (Updated March 10, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/44652/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44584: Improved docs for dynamic weights.

[Neil Conway]

> On March 10, 2016, 7:47 a.m., Yongqiao Wang wrote:
> > docs/weights.md, lines 40-46
> > 
> >
> > Why adjust this order? `role` is an optional item in `/weights` `PUT` 
> > request, and `/weights` is focus on changing the weight, so I put `weight` 
> > item firstly.

I think putting "role" first is more readable, and is consistent with the 
`--weights` syntax. If you want to emphasize that "role" is optional, I suggest 
documenting that explicitly.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44584/#review122893
---


On March 10, 2016, 7:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44584/
> ---
> 
> (Updated March 10, 2016, 7:28 a.m.)
> 
> 
> Review request for mesos, Adam B and Yongqiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic weights.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/roles.md 65d6ddf46ac394389c70a3faf5cc85c5cf892478 
>   docs/weights.md dec2ddd6516d2d3a9926f6410f8309eb2de40c3c 
>   src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28 
> 
> Diff: https://reviews.apache.org/r/44584/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/
---

(Updated March 10, 2016, 7:34 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

MasterContender and MasterDetector abstract classes can be subclassed by
user-provided classes to allow for arbitrary contender/detector implementations.


Diffs (updated)
-

  include/mesos/master/contender.hpp PRE-CREATION 
  include/mesos/master/detector.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44287/diff/


Testing
---

See https://reviews.apache.org/r/44289/.


Thanks,

Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44545/
---

(Updated March 10, 2016, 7:35 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Instead of keeping standalone and zookeper contender/detector class
definitions and implementations in the same file, separated them. Also
made the necessary changes in users of class headers to point to the
new locations.


Diffs (updated)
-

  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/contenders/contender.hpp PRE-CREATION 
  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/contenders/standalone.cpp PRE-CREATION 
  src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/detectors/detector.hpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 
  src/master/detectors/standalone.cpp PRE-CREATION 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 
  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/isolator_tests.cpp 
342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
  src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
dfb0f51fec67a3951e396eab28eedb0dbf9493ae 
  src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44545/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44544/
---

(Updated March 10, 2016, 7:35 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Moved contender and detector definitions into separate directories.


Diffs (updated)
-

  src/master/contenders/contender.hpp PRE-CREATION 
  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/detectors/detector.hpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44544/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44289/
---

(Updated March 10, 2016, 7:35 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Added support for contender and detector modules.


Diffs (updated)
-

  include/mesos/module/contender.hpp PRE-CREATION 
  include/mesos/module/detector.hpp PRE-CREATION 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/examples/test_contender_module.cpp PRE-CREATION 
  src/examples/test_detector_module.cpp PRE-CREATION 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 

Diff: https://reviews.apache.org/r/44289/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Anurag Singh

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Joseph Wu]

> On March 9, 2016, 10:46 a.m., Michael Park wrote:
> > src/tests/cluster.hpp, line 88
> > 
> >
> > Why do we need to return `Try` as opposed to 
> > `Try`?
> 
> Joseph Wu wrote:
> We return an `Owned` so that the tests can use `.reset()` to destruct the 
> master/agents.  If we just had a `Try<...>`, the tests would have to rely on 
> scope to destruct, which could get ugly if you have combinations of 
> masters/agents in a test :)
> 
> i.e.
> ```
> Try master = StartMaster();
> Try slave = StartSlave(...);
> 
> // Do stuff.
> 
> master->reset();
> slave->reset();
> 
> // More stuff
> ```
> Vs.
> ```
> {
>   // Have to construct slave after master...
>   Try slave;
>   
>   {
> Try master = StartMaster();
> slave = StartSlave(...);
> 
> // Do stuff.
>   }
> }
> 
> // More stuff.
> ```
> 
> Michael Park wrote:
> I think your second example you meant to leave out the `Owned`, right?
> Assuming that is the case, I would consider using `Try` 
> since
> it provides the same capabilities - unnecessary dynamic allocations.

Oops, yes, I meant to leave out the `Owned` in the second part :)


> On March 9, 2016, 10:46 a.m., Michael Park wrote:
> > src/tests/cluster.hpp, line 108
> > 
> >
> > We're storing a `process::Owned`, but returning an 
> > instance of `process::Owned` here. This probably only works 
> > because `Owned` is implemented as `Shared` currently. This should either be 
> > `Shared`, or something like `const MasterDetector&`/`const MasterDetector*`.
> 
> Joseph Wu wrote:
> Each call to `detector()` returns a new instance of a MasterDetector; the 
> comment above this line should say the same thing.  (Am I interpretting your 
> issue correctly?)
> 
> This is mostly a convenience function so that you don't see something 
> like this in all the tests:
> ```
> // For the non-zookeeper case:
> Owned detector(new 
> StandaloneMasterDetector(master.get()->pid);
> ```
> 
> Michael Park wrote:
> I think my source of confusion is that I thought `detector()` simply 
> returns `masterDetector`
> (since I only looked through through the header file). I understand that 
> is not the case.
> I'm currently confused as to what `Master::masterDetector` does, 
> considering your comment below, which reads:
> > Now that `Master` and `Slave` live at the test level, all 
> `MasterDetector` objects are owned in the test scope.
>   (If `MasterDetector` is always owned by the test, this eliminates the 
> need for two `StartSlave` varieties for
>   `MasterDetector*` and `Owned`.)

Renamed `detector()` -> `createDetector`.  And `masterDetector` -> `detector`.


> On March 9, 2016, 10:46 a.m., Michael Park wrote:
> > src/tests/cluster.hpp, line 141
> > 
> >
> > The zookeeper setup is for multi-master setup, right? Before, we had a 
> > zookeeper url per-`Masters`, now we have it per-`Master`. Is the idea to 
> > simply store duplicates instead?
> 
> Joseph Wu wrote:
> If we had multi-master tests, this would store duplicates (we also store 
> it in MesosTest).  (Maybe it will be useful in future to store different 
> zookeeper URLs per master?)  We currently don't support multi-master tests, 
> and I'm guessing we will tweak zookeeper variables when we move to support 
> multi-master tests.
> 
> Michael Park wrote:
> We don't currently have any multi-master tests? So we don't use 
> `zookeeperUrl` at all?

See: https://issues.apache.org/jira/browse/MESOS-2976 and related/linked JIRAs.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/#review122760
---


On March 10, 2016, 12:28 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43613/
> ---
> 
> (Updated March 10, 2016, 12:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Artem 
> Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope 
> of test objects to the test body.
> 
> Changes the `Cluster` class into two RAII objects (`Master` and 

Re: Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/#review122993
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43707/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40567, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b 
> 
> Diff: https://reviews.apache.org/r/43707/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44433: Added empty line for list in maintenance doc.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44433/#review122972
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 8, 2016, 8 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44433/
> ---
> 
> (Updated March 8, 2016, 8 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added empty line for list in maintenance doc.
> 
> 
> Diffs
> -
> 
>   docs/maintenance.md 365c920719dbd0c5e61efe1975547a2848647bce 
> 
> Diff: https://reviews.apache.org/r/44433/diff/
> 
> 
> Testing
> ---
> 
> Document update.
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/
---

(Updated March 10, 2016, 7:45 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
Toenshoff.


Changes
---

Added more tests.


Bugs: MESOS-4850
https://issues.apache.org/jira/browse/MESOS-4850


Repository: mesos


Description (updated)
---

Added authentication to agent HTTP endpoints.

This patch adds HTTP authentication to the `/state`, `/state.json`, and 
`/flags` endpoints. Tests are also updated to use authentication when hitting 
these endpoints, and new tests were added to probe these endpoints' behavior 
when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
`SlaveTest.FlagsEndpointBadCredential`.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/containerizer/docker_containerizer_tests.cpp 
6aecd912fc84b72d2b64f7a842891fddcbc469ac 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44553/diff/


Testing (updated)
---

Tests were updated to use authentication when hitting the affected agent 
endpoints, and new tests were added to probe the endpoint behavior when invalid 
credentials are supplied.

`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new tests 
were run 1000 times to look for flakiness.


Thanks,

Greg Mann

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44537/
---

(Updated March 10, 2016, 1:08 p.m.)


Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Add a `clock::advance` to slightly improve the double-inverse offer regression 
check.


Bugs: MESOS-4831
https://issues.apache.org/jira/browse/MESOS-4831


Repository: mesos


Description
---

Based on the modified test Anand posted in the description of MESOS-4831.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 

Diff: https://reviews.apache.org/r/44537/diff/


Testing
---

make check OSX


Thanks,

Joseph Wu

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

[Greg Mann]

> On March 10, 2016, 8:57 a.m., Adam B wrote:
> > Can you add some tests for these endpoints that show that hitting them with 
> > a bad credential will fail with status Unauthorized? See 
> > `TeardownTest.TeardownEndpointBadCredentials` or 
> > `PersistentVolumeEndpointsTest.BadCredentials`.

Good idea, done!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44553/#review122901
---


On March 10, 2016, 7:45 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44553/
> ---
> 
> (Updated March 10, 2016, 7:45 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4850
> https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication to agent HTTP endpoints.
> 
> This patch adds HTTP authentication to the `/state`, `/state.json`, and 
> `/flags` endpoints. Tests are also updated to use authentication when hitting 
> these endpoints, and new tests were added to probe these endpoints' behavior 
> when bad credentials are supplied: `SlaveTest.StateEndpointBadCredential` and 
> `SlaveTest.FlagsEndpointBadCredential`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 6aecd912fc84b72d2b64f7a842891fddcbc469ac 
>   src/tests/fault_tolerance_tests.cpp 
> d193897e636efd0e3ef67bf67fcd6255a3de0341 
>   src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
>   src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
> 
> Diff: https://reviews.apache.org/r/44553/diff/
> 
> 
> Testing
> ---
> 
> Tests were updated to use authentication when hitting the affected agent 
> endpoints, and new tests were added to probe the endpoint behavior when 
> invalid credentials are supplied.
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04. The new 
> tests were run 1000 times to look for flakiness.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review122977
---




src/slave/containerizer/mesos/linux_launcher.cpp (lines 247 - 255)


Can we add a small note here that we rely on the child being blocked 
through the Hook infrastructure, and that's why it's safe to freeze the child 
this way?



src/slave/containerizer/mesos/linux_launcher.cpp (line 249)


let's wrap all the arguments.



src/slave/containerizer/mesos/linux_launcher.cpp (lines 250 - 251)


Why are we taking these by const value?



src/slave/containerizer/mesos/linux_launcher.cpp (lines 273 - 277)


What should we do here now that the hook infrastructure is in place?
Should we log an error as well as return one? or return a more meaningful 
error message?



src/slave/containerizer/mesos/linux_launcher.cpp (line 276)


We now rely on the hook logic to do this right?
Let's document this.



src/slave/containerizer/mesos/linux_launcher.cpp (lines 306 - 317)


Does the order here matter?
If not can we make a note?



src/slave/containerizer/mesos/linux_launcher.cpp (lines 318 - 319)


Now that we've gutted the pipe logic, can we add a `NOTE:` that the child 
process will be blocked until the hooks have finished?


- Joris Van Remoortere


On March 3, 2016, 3:39 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> ---
> 
> (Updated March 3, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved logic to assign process to freezer hierarchy into parentHook.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 9c80cfb621ef2e28aabfb2649846892964d2d4f3 
> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> ---
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

(Updated March 10, 2016, 1:01 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rename `detector()` to `createDetector()`.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try` with `Owned`.  And 
`Try` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/command_executor_tests.cpp 0d2fcf6d4b8d9a925eb6748e6bd33cf279b8f7f8 
  src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 
  src/tests/containerizer/docker_containerizer_tests.cpp 
6aecd912fc84b72d2b64f7a842891fddcbc469ac 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
e72239a55724f1aeeec5362cc370c93dbeca7164 
  src/tests/containerizer/isolator_tests.cpp 
342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 
  src/tests/containerizer/memory_pressure_tests.cpp 
03879d99c371f296f8d9904666911b34209c114d 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
a1427fd0157dee343b643f3272dba8ffea61f7b0 
  src/tests/containerizer/provisioner_docker_tests.cpp 
5b685bfd842d0d98e8ea5ec5ddea8d2cd893dd81 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
2fc0893f5f5e80a783296fb31b30abe86d92df1b 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp d0fd27fd8a6b48511ef8cafab5dff59f65729d9f 
  src/tests/hook_tests.cpp bb287c77493209e663a37e7f88d09a0459855f7d 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_quota_tests.cpp 4fabc1473ec3e048afe7171abbb8d6e49e863847 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
  src/tests/master_validation_tests.cpp 
c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_endpoints_tests.cpp 
81185a161498394020a27f1f5bf747bac5425f43 
  src/tests/persistent_volume_tests.cpp 
e9215de2e073025f67cdc73e8a8de38cf030671f 
  src/tests/rate_limiting_tests.cpp 352a5e7a58b500c25c7c8a421047c4e79434e38e 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
f95ae7a32c3809d150adf1e9e515a3b527e61699 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
dfb0f51fec67a3951e396eab28eedb0dbf9493ae 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 
  src/tests/status_update_manager_tests.cpp 
d64d3b8c96270478f6b681c038de77c3a9eb68fe 
  src/tests/teardown_tests.cpp 2b8e6875022910a729732cee5e03f03099fe08e7 

Diff: https://reviews.apache.org/r/43615/diff/


Testing
---

sudo make check
```
 | OSX | CentOS 7 | 

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

[Joseph Wu]

> On March 8, 2016, 5:54 p.m., Guangya Liu wrote:
> > src/tests/master_maintenance_tests.cpp, lines 501-503
> > 
> >
> > @Joseph, just a question, how can this guarantee that there is no other 
> > events after the Clock::settle()?
> 
> Joseph Wu wrote:
> This is actually a "best-effort" check rather than a guarantee.  It's 
> essentially a guard against sending 2 inverse offers right after another (the 
> bug you fixed in the previous patch).
> 
> Guangya Liu wrote:
> Yes, I also add similar logic based on comments from @Anand 
> https://reviews.apache.org/r/44258/ and assert the event is pending for such 
> case, I do not know how would you rebase this patch or do you think is it 
> necessary to add such checking? I think that we need the checking proposed by 
> @Anand as this can make sure no other offers coming.
> 
> Anand Mazumdar wrote:
> I hadn't seen this patch when I had raised the initial comment on r44258. 
> The eventual plan is to move all the maintenance tests to the new scheduler 
> mock interface for testing like this patch does. 
> 
> I am wondering if it would be a good idea to make r44258 take care of the 
> actual implementation i.e. fixing the bug in master and r44537 takes care of 
> the testing details? 
> 
> [~gyliu] How does this sound to you/Joseph?
> 
> Guangya Liu wrote:
> Yes, that's also my think, I will remove the logic of `Clock::settle()` 
> but keep the logic limitted in master and leave the test update to this 
> patch. But I still want to know how we can check that there is no event 
> coming after `Clock::settle()` ;-)
> 
> Anand Mazumdar wrote:
> I suggested to Joseph to advance the clock by `allocation_interval` and 
> then do a `Clock::settle` to _ensure_ that we do not get another offer to no 
> longer have it as "best-effort".

Added it.  I should emphasize that this check is still best-effort :)  The 
`clock::advance` only makes it a slightly "better" effort.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44537/#review122652
---


On March 10, 2016, 1:08 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44537/
> ---
> 
> (Updated March 10, 2016, 1:08 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4831
> https://issues.apache.org/jira/browse/MESOS-4831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on the modified test Anand posted in the description of MESOS-4831.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 3faa8136cf57276295553910319480028f433e4c 
> 
> Diff: https://reviews.apache.org/r/44537/diff/
> 
> 
> Testing
> ---
> 
> make check OSX
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44537/#review122992
---


Ship it!




- Anand Mazumdar


On March 10, 2016, 9:08 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44537/
> ---
> 
> (Updated March 10, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4831
> https://issues.apache.org/jira/browse/MESOS-4831
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on the modified test Anand posted in the description of MESOS-4831.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 3faa8136cf57276295553910319480028f433e4c 
> 
> Diff: https://reviews.apache.org/r/44537/diff/
> 
> 
> Testing
> ---
> 
> make check OSX
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/
---

(Updated March 10, 2016, 9:40 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.


Changes
---

Addressed comment.


Bugs: MESOS-4849
https://issues.apache.org/jira/browse/MESOS-4849


Repository: mesos


Description
---

Changed the master's default HTTP authentication realm.


Diffs (updated)
-

  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 

Diff: https://reviews.apache.org/r/44523/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 44280: Removed `FLAGS_v` assignment in test case.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44280/#review122970
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 6:37 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44280/
> ---
> 
> (Updated March 2, 2016, 6:37 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per discussion with James Peach, this doesn't serve a
> useful purpose.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 
> 
> Diff: https://reviews.apache.org/r/44280/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44407: Fixed a typo in a log message in an example framework.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44407/#review122971
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 4, 2016, 9:55 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44407/
> ---
> 
> (Updated March 4, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a typo in a log message in an example framework.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> c4c3aa68dc3e6e001f9a746ea5151b8ad958856f 
> 
> Diff: https://reviews.apache.org/r/44407/diff/
> 
> 
> Testing
> ---
> 
> Visual inspection of log message.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 44672: Added normalize method to registry puller.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Added normalize method to registry puller.

Logic is verified with docker go code 
(https://github.com/docker/docker/blob/v1.10.2/reference/reference.go#L171~#L173).


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song

Review Request 44674: Supported image name specified with private registry prefix.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44674/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Supported image name specified with private registry prefix.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44674/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest"

Tested with private registry localhost:80/ubuntu


Thanks,

Gilbert Song

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43629/
---

(Updated March 10, 2016, 12:28 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rename `detector()` to `createDetector()`.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with a slightly different 
pattern.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 

Diff: https://reviews.apache.org/r/43629/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43630/
---

(Updated March 10, 2016, 12:28 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Rename `detector()` to `createDetector()`.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Continuation of https://reviews.apache.org/r/43615/ with re-ordering of some 
local variables due to the order of destruction.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 
  src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 

Diff: https://reviews.apache.org/r/43630/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 44547: Added functions in promises to the collect header.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44547/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Added functions in promises to the collect header.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 

Diff: https://reviews.apache.org/r/44547/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44546: Moved functions in promises to a common header file.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44546/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Moved functions in promises to a common header file.


Diffs (updated)
-

  src/master/detectors/standalone.cpp PRE-CREATION 
  src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e 

Diff: https://reviews.apache.org/r/44546/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44289: Added support for contender and detector modules.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44289/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Added support for contender and detector modules.


Diffs (updated)
-

  include/mesos/module/contender.hpp PRE-CREATION 
  include/mesos/module/detector.hpp PRE-CREATION 
  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/examples/test_contender_module.cpp PRE-CREATION 
  src/examples/test_detector_module.cpp PRE-CREATION 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 

Diff: https://reviews.apache.org/r/44289/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Anurag Singh

Re: Review Request 44670: Added master_detector and master_contender flags.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44670/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

The master_detector and master_contender flags allow modules to be
used for specifying the MasterContender and MasterDetector
implementations to use.


Diffs (updated)
-

  src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 
  src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
  src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 

Diff: https://reviews.apache.org/r/44670/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Anurag Singh

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

The createFromModule will be used to create a MasterContender/Detector
from a module (specified using the --modules flag on the command
line).


Diffs (updated)
-

  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44669/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review122996
---




3rdparty/libprocess/src/metrics/metrics.cpp (line 234)


(1) Why not just `snapshot`?
(2) We don't use default capture by reference. Could you explicitly list 
the variables that need to be captured here?


- Michael Park


On March 10, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review122998
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review122997
---




docs/ssl.md (line 102)


Not sure exactly how much detail we want to add here about specific 
configurations (especially considering the upcoming change to the 
containerizer's environment variables).  But here's some more specifics:

* When using the DockerContainerizer + normal Mesos agent, the docker 
executor shares the same root as the agent.  So as long as the environment 
variables are passed on (via the methods you listed), this will work.
* When using the DockerContainerizer + dockerized Mesos agent, you will 
need to add an additional `ContainerInfo.volumes` which mounts from the host 
(*not the agent*) to the executor.  In this case, the task will have access to 
the keys/certs :(
* The UnifiedContainerizer + normal Mesos agent case will probably be 
similar to the DockerContainerizer + normal Mesos agent case (I haven't tried 
this).
* UnifiedContainerizer + Mesos launched via UnifiedContainerizer ???


- Joseph Wu


On March 10, 2016, 5:46 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 10, 2016, 5:46 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

> On March 10, 2016, 9:32 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234
> > 
> >
> > (1) Why not just `snapshot`?
> > (2) We don't use default capture by reference. Could you explicitly 
> > list the variables that need to be captured here?

1. Fixed

2. We need to capture all the function parameters, and in this context it 
equals to capture all. So I don't think it makes sense to list them one by one?


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review122996
---


On March 10, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44546: Moved functions in promises to a common header file.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44546/
---

(Updated March 10, 2016, 7:35 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Moved functions in promises to a common header file.


Diffs (updated)
-

  src/master/detectors/standalone.cpp PRE-CREATION 
  src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e 

Diff: https://reviews.apache.org/r/44546/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44584: Improved docs for dynamic weights.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44584/#review122969
---



Patch looks great!

Reviews applied: [44583, 44584]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 6:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44584/
> ---
> 
> (Updated March 10, 2016, 6:40 p.m.)
> 
> 
> Review request for mesos, Adam B and Yongqiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic weights.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md f6e84023b90e560594429826ed7163310d62b265 
>   docs/roles.md 65d6ddf46ac394389c70a3faf5cc85c5cf892478 
>   docs/weights.md dec2ddd6516d2d3a9926f6410f8309eb2de40c3c 
>   src/master/flags.cpp c1dd127109f1ba96a8f9b95f3eb99dfeb43f7d28 
> 
> Diff: https://reviews.apache.org/r/44584/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/
---

(Updated March 10, 2016, 7:34 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Also modified users of MasterContender and MasterDetector to use this
namespace.


Diffs (updated)
-

  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 
  src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f 
  src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
  src/scheduler/scheduler.cpp b010a819132fb80810e7f8ce96778109f2e8b35e 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 
  src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
dfb0f51fec67a3951e396eab28eedb0dbf9493ae 
  src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44288/diff/


Testing
---

See https://reviews.apache.org/r/44289/.


Thanks,

Anurag Singh

Re: Review Request 44547: Added functions in promises to the collect header.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44547/
---

(Updated March 10, 2016, 7:35 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Added functions in promises to the collect header.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 

Diff: https://reviews.apache.org/r/44547/diff/


Testing
---


Thanks,

Anurag Singh

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44543/
---

(Updated March 10, 2016, 7:34 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

MasterContender and MasterDetector are now defined in
include/mesos/master/contender.hpp and detector.hpp.


Diffs (updated)
-

  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 

Diff: https://reviews.apache.org/r/44543/diff/


Testing
---


Thanks,

Anurag Singh

Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/
---

Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-4740
https://issues.apache.org/jira/browse/MESOS-4740


Repository: mesos


Description
---

Updated `/metrics/snapshot` endpoint to use `jsonify`.


Diffs
-

  3rdparty/libprocess/src/metrics/metrics.cpp 
f1e6774ebf8670b006ba6ea181439d0ef1529b40 

Diff: https://reviews.apache.org/r/44675/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/
---

(Updated March 10, 2016, 9:21 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

MasterContender and MasterDetector abstract classes can be subclassed by
user-provided classes to allow for arbitrary contender/detector implementations.


Diffs (updated)
-

  include/mesos/master/contender.hpp PRE-CREATION 
  include/mesos/master/detector.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44287/diff/


Testing
---

See https://reviews.apache.org/r/44289/.


Thanks,

Anurag Singh

Re: Review Request 44545: Separated standalone and zookeeper classes.

[Anurag Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44545/
---

(Updated March 10, 2016, 9:22 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Instead of keeping standalone and zookeper contender/detector class
definitions and implementations in the same file, separated them. Also
made the necessary changes in users of class headers to point to the
new locations.


Diffs (updated)
-

  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/contenders/contender.hpp PRE-CREATION 
  src/master/contenders/contender.cpp PRE-CREATION 
  src/master/contenders/standalone.cpp PRE-CREATION 
  src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/detectors/detector.hpp PRE-CREATION 
  src/master/detectors/detector.cpp PRE-CREATION 
  src/master/detectors/standalone.cpp PRE-CREATION 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 
  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/isolator_tests.cpp 
342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 
  src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 
  src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 
  src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 
  src/tests/scheduler_event_call_tests.cpp 
8c02ceeb3ec1783cb2f63f100700508e70f586e4 
  src/tests/scheduler_http_api_tests.cpp 
dfb0f51fec67a3951e396eab28eedb0dbf9493ae 
  src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 
  src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c 
  src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 

Diff: https://reviews.apache.org/r/44545/diff/


Testing
---


Thanks,

Anurag Singh