Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122914 --- Patch looks great! Reviews applied: [44286, 44186] Passed

Re: Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44581/#review122909 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
> On March 10, 2016, 6:26 a.m., Adam B wrote: > > Can you add some tests for these endpoints that show that hitting them with > > a bad credential will fail with status `Unauthorized`? See > > `TeardownTest.TeardownEndpointBadCredentials` or > > `PersistentVolumeEndpointsTest.BadCredentials`.

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 10, 2016, 10:31 a.m.) Review request for mesos, Adam B,

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-10 Thread Joerg Schad
> On March 10, 2016, 6:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 129 > > > > > > Why set this to false and then still createBasicAuthHeaders for these > > tests? > > Why can't we

Review Request 44581: fixed docker's stdout/stderr streams got corrupted after calling docker->stop.

2016-03-10 Thread Martin Bydzovsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44581/ --- Review request for mesos. Repository: mesos Description --- fixed

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122905 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review122902 --- Fix it, then Ship it! Looks good. Just some alpha-order nits,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review122901 --- Can you add some tests for these endpoints that show that hitting

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review122900 --- Patch looks great! Reviews applied: [42705, 44606] Passed

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Adam B
> On March 9, 2016, 8:02 p.m., Alexander Rojas wrote: > > I just did a grep and I found this: > > > > ```sh > > $ ag --cpp --ignore="build/.*" '\"mesos\"' . > > # ... > > src/authentication/http/basic_authenticator_factory.cpp > > 66: Authenticator* authenticator = new

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122892 --- Looks great! Just some minor nits and a question about

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review122897 --- include/mesos/mesos.proto (line 443)

<    1   2   3