Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-22 Thread Steve Niemitz
> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the >

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 23, 2016, 1:10 p.m.) Review request for mesos, Avinash

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-22 Thread Avinash sridharan
> On March 21, 2016, 3:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > This is just a thought. Maybe its better to use `await` over here, and

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124810 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

<    1   2