Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46114/
---

(Updated April 15, 2016, 4:35 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

Use the `principal` set in `FrameworkInfo.principal` to populate
framework metrics instead of looking them up in `authenticated`
map. It also ensures that HTTP->PID framework downgrades preserve 
the metrics and no additional logic is needed to deal with this. 
(Previously HTTP frameworks never had AuthN and no principal was 
passed in `FrameworkInfo`, so this was never a concern).


Diffs (updated)
-

  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 

Diff: https://reviews.apache.org/r/46114/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/
---

(Updated April 15, 2016, 4:39 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod & Greg


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

This change introduces two new flags `authenticate_http_frameworks`
and `http_framework_authenticators` to the master. This allows us
to selectively turn on/off framework authentication and decouple
them from authentication for operator endpoints.


Diffs (updated)
-

  src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
  src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
  src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 

Diff: https://reviews.apache.org/r/46211/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46209: Explicitly set `FrameworkInfo.principal` if AuthN is enabled.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46209/
---

(Updated April 15, 2016, 4:35 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-5214
https://issues.apache.org/jira/browse/MESOS-5214


Repository: mesos


Description
---

This change explicitly sets `FrameworkInfo.principal` if
AuthN is enabled for old driver based frameworks. The
value gets defaulted to the authenticated principal (if missing).


Diffs (updated)
-

  src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 

Diff: https://reviews.apache.org/r/46209/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Anand Mazumdar]

> On April 15, 2016, 12:42 a.m., Vinod Kone wrote:
> > src/master/flags.cpp, line 482
> > 
> >
> > do we need a default here? we needed a default for 
> > `--http_authenticators` for backwards compatibility. since there is no 
> > backwards compatibility concern here, i think we should be ok with no 
> > default? having a default and not loading is a bit weird IMO.
> > 
> > remove the default and mention in the description  that this flag is 
> > required iff `--authenticate_http_frameworks` is set.

FWIW, I do like the idea of having the default authenticator be `basic` i.e. 
have a default value. It becomes easier to get started with using AuthN. 
Otherwise, they have to first search around for the module JSON string 
documentation, populate the fields etc. to set up the module correctly. Even, 
we need to do it to wire up our test driver. I wonder if it’s worth the hassle 
for operators/framework developers to go through this extra step.

We can explicitly include in the documentation that the module (including 
default) is only loaded when `--authenticate_http_frameworks` is set. 

I updated the review diff based on the above proposal. Let me know what do you 
think?


> On April 15, 2016, 12:42 a.m., Vinod Kone wrote:
> > src/master/constants.hpp, line 132
> > 
> >
> > If and when we add AuthN support for agent <-> executor, what is that 
> > realm going to be? 'mesos-http-framework' or 'mesos-http-executor'? I guess 
> > it has to the latter because we bring up both master and agent in the same 
> > OS process in tests?
> > 
> > so should this be called mesos-http-scheduler instead? it's kinda 
> > unfortunate that we sometimes equate framework with scheduler and sometimes 
> > with framework and executor.

Sounds good. Also, I don't like the idea of having the protocol name embedded 
in the realm. How about just: "mesos-scheduler"?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/#review129044
---


On April 15, 2016, 4:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46211/
> ---
> 
> (Updated April 15, 2016, 4:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two new flags `authenticate_http_frameworks`
> and `http_framework_authenticators` to the master. This allows us
> to selectively turn on/off framework authentication and decouple
> them from authentication for operator endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
>   src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
> 
> Diff: https://reviews.apache.org/r/46211/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/
---

(Updated April 15, 2016, 4:39 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Explicitly mentioned that authenticators are loaded only when framework AuthN 
is enabled.


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

This change adds config docs around authenticating HTTP
frameworks using the newly introduced flags. Also added a
small note to the `authenticate` flag that this does not
work for HTTP based frameworks.


Diffs (updated)
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/46212/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Anand Mazumdar]

- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/#review129044
---


On April 15, 2016, 4:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46211/
> ---
> 
> (Updated April 15, 2016, 4:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two new flags `authenticate_http_frameworks`
> and `http_framework_authenticators` to the master. This allows us
> to selectively turn on/off framework authentication and decouple
> them from authentication for operator endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
>   src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
> 
> Diff: https://reviews.apache.org/r/46211/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 44379: Use tokens size to parse perf stat format.

[fan du]

> On April 11, 2016, 7:08 a.m., haosdent huang wrote:
> > Thanks you very much for your quick reply! By the way, this patch should 
> > credited by you, please update the description and remove my name. Quite 
> > appreciated your great help again so that I could rebase my patches depend 
> > on this.

You have also spend time to debug it, never mind, it's just a patch.


- fan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review128076
---


On April 11, 2016, 7:01 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> ---
> 
> (Updated April 11, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4705
> https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use tokens size to parse perf stat format.
> 
> Co-authored with haosdent.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> ---
> 
> 1. {Found and Test} with Serenity, ema filter could get perf event statistics 
> correctly as expected.
> 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
> --log_dir=/tmp/mesos/
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 46180: Implemented create() for docker volume isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/
---

(Updated 四月 15, 2016, 3:27 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented create() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
0ad473dc3bd45e122fba55a670e1a893e61c977a 

Diff: https://reviews.apache.org/r/46180/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45360: Added volume client for mount and unmount.

[Guangya Liu]

> On 四月 14, 2016, 6:12 p.m., Gilbert Song wrote:
> >

We can talk more for your comments when sync up. ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/#review128931
---


On 四月 14, 2016, 6:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45360/
> ---
> 
> (Updated 四月 14, 2016, 6:05 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added volume client for mount and unmount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/volume_client.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45360/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for external mount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 15, 2016, 2:23 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Summary (updated)
-

Added spec protobuf for external mount.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
---

Added spec protobuf for external mount.


Diffs (updated)
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 15, 2016, 2:44 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Summary (updated)
-

Added spec protobuf for DockerVolumeMount.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
---

Added spec protobuf for DockerVolumeMount. The DockerVolumeMount was used to 
check point the mount point for each container to recover.


Diffs
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45326: Implemented os::which().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/
---

(Updated 四月 15, 2016, 3:07 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-4576
https://issues.apache.org/jira/browse/MESOS-4576


Repository: mesos


Description
---

Implemented os::which().


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
33ddb06e25920096f2d16d4f372129ee2f6a8721 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
a81086860a17bd1912e55051dd7bb98a20772b51 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
9bd34c7508cd813c5de18028956f6a740997c266 

Diff: https://reviews.apache.org/r/45326/diff/


Testing
---

make
make check

[ RUN  ] OsTest.Which
[   OK ] OsTest.Which (0 ms)


Thanks,

Guangya Liu

Re: Review Request 46180: Implemented create() for docker volume isolator.

[Guangya Liu]

> On 四月 14, 2016, 6:33 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 
> > 72-73
> > 
> >
> > How about moving "' used by volume isolator" to the second line?

I was now using `os::which`, so no need for this now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46180/#review128942
---


On 四月 14, 2016, 1:40 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46180/
> ---
> 
> (Updated 四月 14, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented create() for docker volume isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46180/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45360: Added volume client for mount and unmount.

[Guangya Liu]

> On 四月 14, 2016, 9:27 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.cpp, 
> > lines 60-61
> > 
> >
> > Let's use `https://github.com/emccode/rexray`, which is under 
> > maintainance.

I think you mean https://github.com/emccode/dvdcli ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/#review128997
---


On 四月 14, 2016, 6:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45360/
> ---
> 
> (Updated 四月 14, 2016, 6:05 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added volume client for mount and unmount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/volume_client.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45360/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45360: Added volume driver client for mount and unmount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45360/
---

(Updated 四月 15, 2016, 2:43 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Summary (updated)
-

Added volume driver client for mount and unmount.


Repository: mesos


Description (updated)
---

Added volume driver client for mount and unmount.


Diffs (updated)
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45360/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45326: Implemented os::which().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/
---

(Updated 四月 15, 2016, 3:06 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Summary (updated)
-

Implemented os::which().


Bugs: MESOS-5084
https://issues.apache.org/jira/browse/MESOS-5084


Repository: mesos


Description (updated)
---

Implemented os::which().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
33ddb06e25920096f2d16d4f372129ee2f6a8721 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
a81086860a17bd1912e55051dd7bb98a20772b51 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
9bd34c7508cd813c5de18028956f6a740997c266 

Diff: https://reviews.apache.org/r/45326/diff/


Testing (updated)
---

make
make check

[ RUN  ] OsTest.Which
[   OK ] OsTest.Which (0 ms)


Thanks,

Guangya Liu

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

(Updated April 15, 2016, 5:49 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed comment.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs (updated)
-

  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46262: Added a LoggingTest with authentication.

[Greg Mann]

> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote:
> > src/tests/logging_tests.cpp, line 148
> > 
> >
> > Too keep it consistent, could you add subtests for wrong credentials 
> > and one which succeeds?

Regarding this comment, see my replies in the patches for MetricsTests.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
---


On April 15, 2016, 7:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

[Michael Park]

> On April 14, 2016, 9:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines 
> > 355-360
> > 
> >
> > If we pull out `internal::os_version`, we could do less work here:
> > 
> > ```
> > Try os_version = internal::os_version();
> > if (os_version.isError()) {
> >   return Error(os_version.error());
> > }
> > 
> > return internal::sysname(os_version);
> > ```
> > 
> > If the idea is to keep the implementation consistent with 
> > `posix/os.hpp` that sounds fine as well, in which case we should just 
> > define this in `os.hpp`.
> 
> Alex Clemmer wrote:
> Actually, we should just pull this out into `stout/os.hpp` because the 
> different implementations are identical right now.

Yep, that's exactly what I meant by "just define this in `os.hpp`".


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/#review129003
---


On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46191/
> ---
> 
> (Updated April 15, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `uname` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Vinod Kone]

> On April 14, 2016, 5:33 p.m., Greg Mann wrote:
> > src/master/flags.cpp, lines 225-226
> > 
> >
> > This seems a tiny bit misleading: if the value is `false`, no 
> > authentication will be performed at all. Perhaps something like "If 
> > `false`, HTTP frameworks are not authenticated."

+1


> On April 14, 2016, 5:33 p.m., Greg Mann wrote:
> > src/master/master.cpp, lines 665-673
> > 
> >
> > This can be moved into the `if (flags.authenticate_http_frameworks)` 
> > scope, as well as the above declaration of `httpFrameworkAuthenticator`.

+1


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/#review128925
---


On April 15, 2016, 4:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46211/
> ---
> 
> (Updated April 15, 2016, 4:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two new flags `authenticate_http_frameworks`
> and `http_framework_authenticators` to the master. This allows us
> to selectively turn on/off framework authentication and decouple
> them from authentication for operator endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
>   src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
> 
> Diff: https://reviews.apache.org/r/46211/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/
---

(Updated April 15, 2016, 5:49 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds a parameter to
process::initialize which allows the authentication
realm of such endpoints to be set when libprocess is
initialized.


Diffs (updated)
-

  3rdparty/libprocess/include/process/gtest.hpp 
3e0887257e1484813b3547170a5a1b9bb89de0d2 
  3rdparty/libprocess/include/process/process.hpp 
77e96957ca556cf9a7e2bf427d6762572fe48c51 
  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
  3rdparty/libprocess/src/tests/main.cpp 
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 

Diff: https://reviews.apache.org/r/46254/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

[Greg Mann]

> On April 15, 2016, 10:35 a.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp, line 31
> > 
> >
> > Something tells me there should be a comment here, but I don't know 
> > exactly what its contents should be.
> 
> Alexander Rojas wrote:
> I originaly thought this was in a cpp, but there are multiple problems I 
> see:
> 
> 1. We avoid ha static global strings since the have initialization 
> uncertainty, also if something goes wrong it can be destroy before you can 
> use it.
> 2. The way to go is `constexpr char DEFAULT_HTTP_AUTHENTICATION_REALM[] = 
> "libprocess-realm"`

Thanks arojas! I changed this to `constexpr char`, which I believe fixes the 
uncertain initialization/lifetime issue, but you said "multiple problems" so 
let me know what you think :-)


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/#review129091
---


On April 15, 2016, 5:49 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46254/
> ---
> 
> (Updated April 15, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to enable authentication on libprocess-level
> HTTP endpoints, this patch adds a parameter to
> process::initialize which allows the authentication
> realm of such endpoints to be set when libprocess is
> initialized.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 3e0887257e1484813b3547170a5a1b9bb89de0d2 
>   3rdparty/libprocess/include/process/process.hpp 
> 77e96957ca556cf9a7e2bf427d6762572fe48c51 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
>   3rdparty/libprocess/src/tests/main.cpp 
> 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 
> 
> Diff: https://reviews.apache.org/r/46254/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/
---

(Updated April 15, 2016, 6:55 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

This change introduces two new flags `authenticate_http_frameworks`
and `http_framework_authenticators` to the master. This allows us
to selectively turn on/off framework authentication and decouple
them from authentication for operator endpoints.


Diffs (updated)
-

  src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
  src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
  src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 

Diff: https://reviews.apache.org/r/46211/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/
---

(Updated April 15, 2016, 7:04 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

This change adds config docs around authenticating HTTP
frameworks using the newly introduced flags. Also added a
small note to the `authenticate` flag that this does not
work for HTTP based frameworks.


Diffs (updated)
-

  docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 

Diff: https://reviews.apache.org/r/46212/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

[Greg Mann]

> On April 15, 2016, 11:39 a.m., Alexander Rojas wrote:
> > src/tests/metrics_tests.cpp, line 288
> > 
> >
> > To be consistent with your other patches, could you add tests for wrong 
> > credentials.
> > 
> > Also, would be nice to have a test where you actually can access the 
> > metrics endpoint.

I think I would actually prefer to eliminate the tests from other patches which 
include requests containing invalid credentials. Since the libprocess test 
`HttpAuthenticationTest.Basic` already tests the basic HTTP authenticator with 
both missing credentials and invalid credentials, I think it's sufficient in 
these tests to only test one of those cases. What do you think?

Regarding a test which successfully accesses the metrics endpoint, see my reply 
to your comment on the tests for the MetricsTests in libprocess.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46261/#review129100
---


On April 15, 2016, 7:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46261/
> ---
> 
> (Updated April 15, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The tests `MetricsTest.AgentAuthenticationEnabled` and
> `MetricsTest.MasterAuthenticationEnabled` are added in
> this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 
> 
> Diff: https://reviews.apache.org/r/46261/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/
---

(Updated April 15, 2016, 7:05 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added `basic` auth flag.


Bugs: MESOS-4459
https://issues.apache.org/jira/browse/MESOS-4459


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
31d6c70e7ecb584c75404556508dd9cdcf63fb78 
  src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
  src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
  src/tests/scheduler_http_api_tests.cpp 
d469adf7230ce5bb5e71a241a06e389295905e03 
  src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 

Diff: https://reviews.apache.org/r/46118/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45326: Implemented os::which().

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review129156
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 13)


Instead of putting it in a new file, can you put it in stout/posix/os.hpp 
for now since `getenv` is only in stout/posix/os.hpp for now.



3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 30)


Looks like we ignore errors. Should the return value be 'Option'?



3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp (line 34)


Can you do the following to avoid unnecessary indentation?
```
Option path = getenv("PATH");
if (path.isNone()) {
  return None();
}

vector tokens = strings::tokenize(path.get(), ":");
...
```


- Jie Yu


On April 15, 2016, 3:07 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> ---
> 
> (Updated April 15, 2016, 3:07 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-4576
> https://issues.apache.org/jira/browse/MESOS-4576
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented os::which().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 33ddb06e25920096f2d16d4f372129ee2f6a8721 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> a81086860a17bd1912e55051dd7bb98a20772b51 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 9bd34c7508cd813c5de18028956f6a740997c266 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> [ RUN  ] OsTest.Which
> [   OK ] OsTest.Which (0 ms)
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/#review129228
---


Fix it, then Ship it!





src/Makefile.am (line 554)


Align the tailing ``


- Jie Yu


On April 16, 2016, 12:10 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46163/
> ---
> 
> (Updated April 16, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed state/{state,storage}.hpp files.
> 
> 
> Diffs
> -
> 
>   include/mesos/state/state.proto PRE-CREATION 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
>   src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
>   src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b 
>   src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
>   src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
>   src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
>   src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
>   src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
>   src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46163/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 46295: Replaced 'using namespace' with 'using'.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Replaced 'using namespace' with 'using'.


Diffs
-

  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46295/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

[Kapil Arya]

> On April 15, 2016, 8:40 p.m., Jie Yu wrote:
> > src/log/log.cpp, line 742
> > 
> >
> > Please move this to the begining of this file.

Fixed as part of https://reviews.apache.org/r/46295/


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46162/#review129227
---


On April 15, 2016, 6:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46162/
> ---
> 
> (Updated April 15, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved mesos::internal::log::Log to mesos::log namespace.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46162/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

[Kapil Arya]

> On April 15, 2016, 8:43 p.m., Jie Yu wrote:
> > src/Makefile.am, line 554
> > 
> >
> > Align the tailing ``

It's aligned properly in the code. RB is displaying it incorrectly.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/#review129228
---


On April 15, 2016, 8:10 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46163/
> ---
> 
> (Updated April 15, 2016, 8:10 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed state/{state,storage}.hpp files.
> 
> 
> Diffs
> -
> 
>   include/mesos/state/state.proto PRE-CREATION 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
>   src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
>   src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b 
>   src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
>   src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
>   src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
>   src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
>   src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
>   src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46163/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/#review129232
---



Bad patch!

Reviews applied: [46293, 46285, 43985, 46010, 46009]

Failed command: ./support/apply-review.sh -n -r 46285

Error:
2016-04-16 01:31:22 URL:https://reviews.apache.org/r/46285/diff/raw/ 
[2127/2127] -> "46285.patch" [1]
error: patch failed: 3rdparty/libprocess/src/poll_socket.cpp:132
error: 3rdparty/libprocess/src/poll_socket.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12557/console

- Mesos ReviewBot


On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46293/
> ---
> 
> (Updated April 16, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [3/3] Updated `sendfile` test.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 
> 
> Diff: https://reviews.apache.org/r/46293/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 45326: Implemented os::which().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/
---

(Updated 四月 16, 2016, 3:16 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-4576
https://issues.apache.org/jira/browse/MESOS-4576


Repository: mesos


Description
---

Implemented os::which().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
52978f37a27c6db45b71fa1a1d41bb833a76e666 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
9bd34c7508cd813c5de18028956f6a740997c266 

Diff: https://reviews.apache.org/r/45326/diff/


Testing
---

make
make check

[ RUN  ] OsTest.Which
[   OK ] OsTest.Which (0 ms)


Thanks,

Guangya Liu

Re: Review Request 46288: Update CMake file to include the new state.proto file.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46288/#review129230
---


Ship it!




Ship It!

- Jie Yu


On April 16, 2016, 12:11 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46288/
> ---
> 
> (Updated April 16, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update CMake file to include the new state.proto file.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
> 
> Diff: https://reviews.apache.org/r/46288/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/#review129229
---


Ship it!




Ship It!

- Jie Yu


On April 16, 2016, 12:10 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46164/
> ---
> 
> (Updated April 16, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved mesos::internal::state to mesos::state namespace.
> 
> 
> Diffs
> -
> 
>   include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
>   include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
>   include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
>   include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
>   include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
>   include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
>   src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
>   src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46164/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/
---

(Updated April 16, 2016, 1:10 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [1/3] Implemented `sendfile`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
293f82f6730551491504721e0af28e9537540db1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
f3197679a9c22b37acae003262e5c6d21e110f56 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 

Diff: https://reviews.apache.org/r/43985/diff/


Testing (updated)
---

Build Windows,OSX


Thanks,

Daniel Pravat

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/
---

(Updated April 15, 2016, 9:27 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Replaced 'using namespace' with 'using'.


Diffs (updated)
-

  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46295/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129239
---



Patch looks great!

Reviews applied: [45900, 45901, 46160, 46161, 46162, 46163, 46164, 46288, 46295]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 1:27 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> ---
> 
> (Updated April 16, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced 'using namespace' with 'using'.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

[Greg Mann]

> On April 15, 2016, 11:22 a.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 551
> > 
> >
> > Can you please add a test where authentication actually works? (for 
> > saftey)

I wonder if we really need this? I've written some previous tests along those 
lines (which test full endpoint functionality both with and without 
authentication), but after some conversations with bmahler recently I'm not 
sure this is a good idea. Since we don't currently use the authenticated 
`principal` at all in the endpoint handler, we really just need to test here 
that unauthenticated requests receive an `Unauthorized` response. The 
`HttpAuthenticationTest.Authenticated` test in libprocess already tests that a 
properly authenticated request will succeed in reaching the HTTP endpoint and 
passing the correct principal to the handler, so we don't need to test that 
again. Once authorization is enabled on this endpoint, it will make sense to 
have successfully authenticated test cases in order to test the authorization 
code, but at this point I think it would introduce unnecessary tests and 
increase the code maintenance burden. What do you think?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46260/#review129098
---


On April 15, 2016, 6:58 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46260/
> ---
> 
> (Updated April 15, 2016, 6:58 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `MetricsTest.SnapshotAuthenticationEnabled`
> is added to the libprocess tests in this patch.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> b84dc8d858f58bc9f52b218b7153510417cf34c2 
> 
> Diff: https://reviews.apache.org/r/46260/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46115/
---

(Updated April 15, 2016, 6:07 p.m.)


Review request for mesos, Greg Mann and Vinod Kone.


Changes
---

Made the log message consistent with driver based framework


Bugs: MESOS-3923
https://issues.apache.org/jira/browse/MESOS-3923


Repository: mesos


Description
---

This change adds AuthN support for HTTP based frameworks.

We allow AuthZ without AuthN for `/scheduler` endpoint. Also,
we ensure that `FrameworkInfo.principal` (if present) equals
the authenticated principal. We also allow a framework to
omit specifying the `FrameworkInfo.principal` in case
it is not interested in authorization or if it is disabled.
We do log a warning for this cases similar to what driver
based frameworks already do.


Diffs (updated)
-

  src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10 
  src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f 
  src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
  src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
  src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 

Diff: https://reviews.apache.org/r/46115/diff/


Testing
---

make check. Enabled AuthN for all the tests later in the chain.


Thanks,

Anand Mazumdar

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46115/#review129051
---


Fix it, then Ship it!





src/master/http.cpp (lines 437 - 439)


Update this warning message per my comment in the other review.


- Vinod Kone


On April 14, 2016, 5:46 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46115/
> ---
> 
> (Updated April 14, 2016, 5:46 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds AuthN support for HTTP based frameworks.
> 
> We allow AuthZ without AuthN for `/scheduler` endpoint. Also,
> we ensure that `FrameworkInfo.principal` (if present) equals
> the authenticated principal. We also allow a framework to
> omit specifying the `FrameworkInfo.principal` in case
> it is not interested in authorization or if it is disabled.
> We do log a warning for this cases similar to what driver
> based frameworks already do.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10 
>   src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/master/validation.hpp d1f2323172cbf3bb052942a119b8531f9ccad48d 
>   src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
> 
> Diff: https://reviews.apache.org/r/46115/diff/
> 
> 
> Testing
> ---
> 
> make check. Enabled AuthN for all the tests later in the chain.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 46182: Adding app runtime processing to appc store and provisioner.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/
---

Review request for mesos.


Repository: mesos


Description
---

Adding app runtime processing to appc store and provisioner.


Diffs
-

  include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
  src/slave/containerizer/mesos/provisioner/store.hpp 
1d477ef13ddd24fd8badae0decaa4a2271ecc746 

Diff: https://reviews.apache.org/r/46182/diff/


Testing
---

make check on linux passes 
AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest


Thanks,

Srinivas Brahmaroutu

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46182/#review129178
---



Patch looks great!

Reviews applied: [46182]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 6:23 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46182/
> ---
> 
> (Updated April 15, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adding app runtime processing to appc store and provisioner.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/46182/diff/
> 
> 
> Testing
> ---
> 
> make check on linux passes 
> AppcProvisionerIntegrationTest.ROOT_SimpleLinuxImageTest
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 15, 2016, 11:56 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
---

Added spec protobuf for DockerVolumeMount. The DockerVolumeMount
was used to check point the mount point for each container to recover.


Diffs
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto 
PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 46293: Windows: [3/3] Updated `sendfile` test.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46293/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [3/3] Updated `sendfile` test.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
5b1543443b83b35d0f3bf1ca5884845fb8d34e7a 

Diff: https://reviews.apache.org/r/46293/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Review Request 46285: Windows: [2/3] `sendfile` used with the typed error state of `Try`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46285/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [2/3] `sendfile` used with the typed error state of `Try`.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/46285/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129204
---




3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 294)


Should we use `SharedHandle` here?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 312 - 
313)


`} else {`



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 359)


What's the difference between `Failed to call X` vs `Call to `X` failed`?



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 403 - 
404)


I think it would easier to read:

```
Try utime = Nanoseconds(lKernelTime.QuadPart * 100);
Try stime = Nanoseconds(lUserTime.QuadPart * 100);
```

This is also arguably more correct, since any number < 10,000,000 would 
incorrectly result in 0 by the division.

What do you think?


- Michael Park


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> ---
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/
---

(Updated April 15, 2016, 8:10 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Reincluded an accidentally change to Makefile.am


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Exposed state/{state,storage}.hpp files.


Diffs (updated)
-

  include/mesos/state/state.proto PRE-CREATION 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b 
  src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46163/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/
---

(Updated April 15, 2016, 8:10 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Moved mesos::internal::state to mesos::state namespace.


Diffs (updated)
-

  include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46164/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46288: Update CMake file to include the new state.proto file.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46288/
---

(Updated April 15, 2016, 8:11 p.m.)


Review request for mesos, Alex Clemmer and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Update CMake file to include the new state.proto file.


Diffs (updated)
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 

Diff: https://reviews.apache.org/r/46288/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/
---

(Updated April 16, 2016, 12:19 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Summary (updated)
-

Windows: [1/3] Implemented `sendfile`.


Repository: mesos


Description (updated)
---

Windows: [1/3] Implemented `sendfile`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
293f82f6730551491504721e0af28e9537540db1 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d 

Diff: https://reviews.apache.org/r/43985/diff/


Testing
---

Build Windows,OSX
Run Windows


Thanks,

Daniel Pravat

Re: Review Request 46160: Exposed zookeeper headers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46160/#review129225
---


Ship it!




Ship It!

- Jie Yu


On April 15, 2016, 10:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46160/
> ---
> 
> (Updated April 15, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed zookeeper headers.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/log/network.hpp 6d40027ec3c5e16c18a239042daba5c65aac4451 
>   src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
>   src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
>   src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
>   src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
>   src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
>   src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
>   src/tests/master_contender_detector_tests.cpp 
> 1426a173b1f458d67b748016aee311ac008b054a 
>   src/tests/zookeeper_test_server.hpp 
> 1f1360e5ce06b2f4416dfedfe02642c7c8f7c9ae 
>   src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
>   src/tests/zookeeper_url_tests.cpp f6c50149bba95ccdadfd6ee97599069e2ddcd03d 
>   src/zookeeper/authentication.hpp 40a233381e1e0efd2442efc95627d1968a925eae 
>   src/zookeeper/authentication.cpp 62eab1cc9e85ce65314b9a317ab9d62b1d6d7e88 
>   src/zookeeper/contender.hpp c4bb0bc408afcfc49ccc7823808373b8e00209d6 
>   src/zookeeper/contender.cpp 4cda56cd1f46237387eb92bf938c448a9f370d02 
>   src/zookeeper/detector.hpp 39a2241ec413d4bdfaa13cb040d71265ae510357 
>   src/zookeeper/detector.cpp b184deb9357e4c23eba1fd2e2b2e1e60c2d0442d 
>   src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b 
>   src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f 
>   src/zookeeper/url.hpp 1de7a082e444c8b8d22b599feaff0beaf5c45106 
>   src/zookeeper/watcher.hpp dd948d05ff914bf8f1abfaa2d428a004515a97a4 
>   src/zookeeper/zookeeper.hpp  
>   src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 
> 
> Diff: https://reviews.apache.org/r/46160/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46161: Exposed log/log.hpp.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46161/#review129226
---


Ship it!




Ship It!

- Jie Yu


On April 15, 2016, 10:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46161/
> ---
> 
> (Updated April 15, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed log/log.hpp.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46161/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/
---

(Updated April 15, 2016, 7 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Moved mesos::internal::state to mesos::state namespace.


Diffs (updated)
-

  include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46164/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Kapil Arya]

> On April 14, 2016, 1:58 p.m., Jie Yu wrote:
> > include/mesos/state/state.hpp, line 83
> > 
> >
> > Let's void mesos:: if possible. Ditto for others.

Some of the `mesos::`s are required due to conflicts with 
mesos::internal::slave::state and mesos::state.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/#review128935
---


On April 15, 2016, 7 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46164/
> ---
> 
> (Updated April 15, 2016, 7 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved mesos::internal::state to mesos::state namespace.
> 
> 
> Diffs
> -
> 
>   include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
>   include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
>   include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
>   include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
>   include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
>   include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
>   src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
>   src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46164/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/#review129199
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 55)


Add newline.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 62)


```
  if (!::GetComputerNameEx(ComputerNameDnsHostname, NULL, ) &&
  ::GetLastError() != ERROR_MORE_DATA) {
```



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 66)


`std::unique_ptr` semantically means that it's pointing to a single 
element. We should use  `std::unique_ptr` to use the array of elements 
version. We should also use `new` so that we don't have to manually calcaluate 
the number of bytes.

```
std::unique_ptr name(new char[size + 1]);
```



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 333 - 
336)


This fits in one line.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 348)


`s/computer name/nodename/`



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 349)


`s/name/nodename/`


- Michael Park


On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46191/
> ---
> 
> (Updated April 15, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `uname` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46160: Exposed zookeeper headers.

[Kapil Arya]

> On April 13, 2016, 8:55 p.m., Jie Yu wrote:
> > src/state/zookeeper.hpp, line 23
> > 
> >
> > Let's put mesos headers after stout/libprocess

Dropping since it's already inconsistent with codebase.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46160/#review128817
---


On April 15, 2016, 6:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46160/
> ---
> 
> (Updated April 15, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed zookeeper headers.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/log/network.hpp 6d40027ec3c5e16c18a239042daba5c65aac4451 
>   src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
>   src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
>   src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
>   src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
>   src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
>   src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
>   src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
>   src/tests/master_contender_detector_tests.cpp 
> 1426a173b1f458d67b748016aee311ac008b054a 
>   src/tests/zookeeper_test_server.hpp 
> 1f1360e5ce06b2f4416dfedfe02642c7c8f7c9ae 
>   src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
>   src/tests/zookeeper_url_tests.cpp f6c50149bba95ccdadfd6ee97599069e2ddcd03d 
>   src/zookeeper/authentication.hpp 40a233381e1e0efd2442efc95627d1968a925eae 
>   src/zookeeper/authentication.cpp 62eab1cc9e85ce65314b9a317ab9d62b1d6d7e88 
>   src/zookeeper/contender.hpp c4bb0bc408afcfc49ccc7823808373b8e00209d6 
>   src/zookeeper/contender.cpp 4cda56cd1f46237387eb92bf938c448a9f370d02 
>   src/zookeeper/detector.hpp 39a2241ec413d4bdfaa13cb040d71265ae510357 
>   src/zookeeper/detector.cpp b184deb9357e4c23eba1fd2e2b2e1e60c2d0442d 
>   src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b 
>   src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f 
>   src/zookeeper/url.hpp 1de7a082e444c8b8d22b599feaff0beaf5c45106 
>   src/zookeeper/watcher.hpp dd948d05ff914bf8f1abfaa2d428a004515a97a4 
>   src/zookeeper/zookeeper.hpp  
>   src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 
> 
> Diff: https://reviews.apache.org/r/46160/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46161: Exposed log/log.hpp.

[Kapil Arya]

> On April 13, 2016, 8:54 p.m., Jie Yu wrote:
> > Please make sure the cmake works. Also, put mesos header after 
> > libprocess/stout headers. Please all occurances.

The CMakelists.txt files don't contain headers so we are good here.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46161/#review128816
---


On April 15, 2016, 6:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46161/
> ---
> 
> (Updated April 15, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed log/log.hpp.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46161/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46161: Exposed log/log.hpp.

[Kapil Arya]

> On April 13, 2016, 8:54 p.m., Jie Yu wrote:
> > Please make sure the cmake works. Also, put mesos header after 
> > libprocess/stout headers. Please all occurances.
> 
> Kapil Arya wrote:
> The CMakelists.txt files don't contain headers so we are good here.

Added https://reviews.apache.org/r/46288/


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46161/#review128816
---


On April 15, 2016, 6:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46161/
> ---
> 
> (Updated April 15, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed log/log.hpp.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46161/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 46288: Update CMake file to include the new state.proto file.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46288/
---

Review request for mesos, Alex Clemmer and Jie Yu.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Update CMake file to include the new state.proto file.


Diffs
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 

Diff: https://reviews.apache.org/r/46288/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46162/#review129227
---


Fix it, then Ship it!





src/log/log.cpp (line 742)


Please move this to the begining of this file.


- Jie Yu


On April 15, 2016, 10:12 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46162/
> ---
> 
> (Updated April 15, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved mesos::internal::log::Log to mesos::log namespace.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46162/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 46281: Fixed broken mesos build.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46281/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/scheduler_http_api_tests.cpp 
85e55e263fb93c7ba59a72528b0b13dc0f0aee9c 

Diff: https://reviews.apache.org/r/46281/diff/


Testing
---

make check

Looks like the review bot kicked in a bit earlier and
I never noticed this breaking change.


Thanks,

Anand Mazumdar

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

addressed comments.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Exposed state/{state,storage}.hpp files.


Diffs (updated)
-

  include/mesos/state/state.proto PRE-CREATION 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b 
  src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46163/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46161: Exposed log/log.hpp.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46161/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed comments.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Exposed log/log.hpp.


Diffs (updated)
-

  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/java/jni/org_apache_mesos_Log.cpp 
140b950136417eed7cba363a89537ed2f33832ff 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46161/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

addressed comments.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Moved mesos::internal::state to mesos::state namespace.


Diffs (updated)
-

  include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46164/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45901/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos, Anurag Singh and Jie Yu.


Changes
---

rebased


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Removed unsed headers from master contender/detector files.


Diffs (updated)
-

  src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
  src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed 
  src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f 
  src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
  src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
  src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
  src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 
  src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee 
  src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
  src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/45901/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 46281: Fixed broken mesos build.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46281/#review129193
---


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 10:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46281/
> ---
> 
> (Updated April 15, 2016, 10:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_http_api_tests.cpp 
> 85e55e263fb93c7ba59a72528b0b13dc0f0aee9c 
> 
> Diff: https://reviews.apache.org/r/46281/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Looks like the review bot kicked in a bit earlier and
> I never noticed this breaking change.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46160: Exposed zookeeper headers.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46160/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Addressed Jie's comments.


Summary (updated)
-

Exposed zookeeper headers.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description (updated)
---

Exposed zookeeper headers.


Diffs (updated)
-

  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
  src/log/network.hpp 6d40027ec3c5e16c18a239042daba5c65aac4451 
  src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
  src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
  src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
  src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
  src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
  src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/group_tests.cpp ebf6963cd4d4dcf053a61495a33a74f22d95e7ec 
  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 
  src/tests/zookeeper_test_server.hpp 1f1360e5ce06b2f4416dfedfe02642c7c8f7c9ae 
  src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
  src/tests/zookeeper_url_tests.cpp f6c50149bba95ccdadfd6ee97599069e2ddcd03d 
  src/zookeeper/authentication.hpp 40a233381e1e0efd2442efc95627d1968a925eae 
  src/zookeeper/authentication.cpp 62eab1cc9e85ce65314b9a317ab9d62b1d6d7e88 
  src/zookeeper/contender.hpp c4bb0bc408afcfc49ccc7823808373b8e00209d6 
  src/zookeeper/contender.cpp 4cda56cd1f46237387eb92bf938c448a9f370d02 
  src/zookeeper/detector.hpp 39a2241ec413d4bdfaa13cb040d71265ae510357 
  src/zookeeper/detector.cpp b184deb9357e4c23eba1fd2e2b2e1e60c2d0442d 
  src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b 
  src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f 
  src/zookeeper/url.hpp 1de7a082e444c8b8d22b599feaff0beaf5c45106 
  src/zookeeper/watcher.hpp dd948d05ff914bf8f1abfaa2d428a004515a97a4 
  src/zookeeper/zookeeper.hpp  
  src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 

Diff: https://reviews.apache.org/r/46160/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 45900: Removed stale contender/detector files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45900/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos, Anurag Singh and James Peach.


Changes
---

rebased


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

Also updated Makefile.am to move contender/detector module library
declarations into the existing list.


Diffs (updated)
-

  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/master/contender/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 
  src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 

Diff: https://reviews.apache.org/r/45900/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46162/
---

(Updated April 15, 2016, 6:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

addressed comments.


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Moved mesos::internal::log::Log to mesos::log namespace.


Diffs (updated)
-

  include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
  src/java/jni/org_apache_mesos_Log.cpp 
140b950136417eed7cba363a89537ed2f33832ff 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46162/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46192/#review129197
---


Ship it!




Ship It!

- Michael Park


On April 15, 2016, 8:51 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46192/
> ---
> 
> (Updated April 15, 2016, 8:51 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Added `systems_tests.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 400c6dc451602926f93b22713af8c66d7ca59ca6 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> c9d331df2f4496183b5734d2434413f68b9c1b4b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/systems_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 9bd34c7508cd813c5de18028956f6a740997c266 
> 
> Diff: https://reviews.apache.org/r/46192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46212/#review129183
---


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 7:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46212/
> ---
> 
> (Updated April 15, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds config docs around authenticating HTTP
> frameworks using the newly introduced flags. Also added a
> small note to the `authenticate` flag that this does not
> work for HTTP based frameworks.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
> 
> Diff: https://reviews.apache.org/r/46212/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46118/#review129185
---


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 7:05 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46118/
> ---
> 
> (Updated April 15, 2016, 7:05 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4459
> https://issues.apache.org/jira/browse/MESOS-4459
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 31d6c70e7ecb584c75404556508dd9cdcf63fb78 
>   src/tests/master_quota_tests.cpp e4a65bf09c8fdd2d6b6161042c3702a8cc4cd454 
>   src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 
>   src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 
>   src/tests/scheduler_http_api_tests.cpp 
> d469adf7230ce5bb5e71a241a06e389295905e03 
>   src/tests/scheduler_tests.cpp b630944b1d3163345e912cb2bfc3301daa4c6362 
> 
> Diff: https://reviews.apache.org/r/46118/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45604: Updated the balloon framework and executor.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review129187
---




src/examples/balloon_framework.cpp (lines 63 - 64)


Kill these two lines.



src/examples/balloon_framework.cpp (lines 67 - 69)


Just change the type of  task_memory_usage_limit from Option to 
Bytes; no need for this validation then.



src/examples/balloon_framework.cpp (lines 85 - 91)


Ditto. Change `task_memory` to Bytes instead of Option.



src/examples/balloon_framework.cpp (line 115)


s/should persist and//



src/examples/balloon_framework.cpp (lines 117 - 118)


why would they be incomplete?


- Vinod Kone


On April 14, 2016, 9:43 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> ---
> 
> (Updated April 14, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment.
> 
> This also updates:
> 
> * The style of the framework code.
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> * Refines the shutdown logic for the executor.  In particular, ironed 
>   out bugs when the balloon executor does not exceed the memory limit.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/tests/balloon_framework_test.sh 
> ae32753e8942f77f94752543c384d218d6e4d48d 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Michael Park]

> On April 14, 2016, 9:10 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183
> > 
> >
> > (1) It seems like this should live in `posix/os.hpp`.
> > (2) The declaration of this function in `windows/os.hpp` is:
> > ```
> > inline Result process(pid_t pid);
> > ```
> > It seems like the windows version needs all 3 states whereas the POSIX 
> > version only needs 2?
> > If that is the case, I think it makes sense to consolidate to using 
> > `Result` in both cases and
> > leave a comment on the POSIX version that we have the 3 states because 
> > of Windows.
> 
> Alex Clemmer wrote:
> I think I must be missing something. There is a version of `process` that 
> returns a `Result` in `linux.hpp`, `osx.hpp`, and so on -- the version whose 
> prototype you mention here is just the Windows implementation of this.
> 
> For the function you are highlighting here in your comment, which returns 
> `Option`, this is separate -- it is meant to be shared among all platforms. 
> There is no need for it to return `Result` because it is just finding a 
> process with a certain `pid` in a list of processes.
> 
> So, my recommendation is to keep it the way it is.
> 
> Thoughts?

Yep, you're right. I read incorrectly. Too bad that we have `Option 
process(pid_t, const std::list&);` as well as `Result 
process(pid_t);` but that's a separate issue :)


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review128983
---


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> ---
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129192
---


Ship it!




Ship It!

- Michael Park


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> ---
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/#review129194
---


Ship it!




Ship It!

- Vinod Kone


On April 14, 2016, 11:27 p.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46189/
> ---
> 
> (Updated April 14, 2016, 11:27 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [#MESOS-5057]
> This patch renames 'slave' to 'agent' in the following strings:
> 1. Error/Warning messages
> 2. Flag help/description messages
> 3. Test case messages
> 4. Other standard output messages
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9 
>   src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
>   src/examples/dynamic_reservation_framework.cpp 
> 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc 
>   src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d 
>   src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1 
>   src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d 
>   src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10 
>   src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
>   src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
> 843771ae5b4f7e283d85c093e63c235dc753397d 
>   src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
> 78dc298ec19a61cd491b2b43b463db67528c5526 
>   src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773 
>   src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
>   src/slave/http.cpp 922aaad6e83ca9d5ab503ddb733a332982843300 
>   src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
>   src/slave/slave.cpp 49fa4a06e26d0d4475ed50db254a320a7030f896 
>   src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 7accd32fba5eed196a82b1a171cb16d37b9e0539 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304 
>   src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1 
>   src/tests/hierarchical_allocator_tests.cpp 
> 8ed0df45fc745d338482d1944a346cd40c18bb37 
>   src/tests/master_allocator_tests.cpp 
> 17607df7d488c8dd42c57504a5ca326697f57ffa 
>   src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
>   src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc 
>   src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
>   src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e 
> 
> Diff: https://reviews.apache.org/r/46189/diff/
> 
> 
> Testing
> ---
> 
> Perform the following regular expression on 'mesos/src' and 'mesos/support' 
> folder to find out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or 
> attribute name
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46163/
---

(Updated April 15, 2016, 6:16 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Fixed compilation issue


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Exposed state/{state,storage}.hpp files.


Diffs (updated)
-

  include/mesos/state/state.proto PRE-CREATION 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b 
  src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46163/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46164/
---

(Updated April 15, 2016, 6:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description
---

Moved mesos::internal::state to mesos::state namespace.


Diffs (updated)
-

  include/mesos/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 
  include/mesos/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 
  include/mesos/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
  include/mesos/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e 
  include/mesos/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd 
  include/mesos/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a 
  include/mesos/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c 
  src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b 
  src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 
  src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c 
  src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46164/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46211/#review129184
---


Ship it!




Ship It!

- Vinod Kone


On April 15, 2016, 6:55 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46211/
> ---
> 
> (Updated April 15, 2016, 6:55 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3923
> https://issues.apache.org/jira/browse/MESOS-3923
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two new flags `authenticate_http_frameworks`
> and `http_framework_authenticators` to the master. This allows us
> to selectively turn on/off framework authentication and decouple
> them from authentication for operator endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 7c7cc25fcc897dedb28001fbb944d2e50eca4713 
>   src/master/flags.hpp 83bb9088e595b393d610cc65479cb6a35fb31842 
>   src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
> 
> Diff: https://reviews.apache.org/r/46211/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

[Michael Park]

> On April 14, 2016, 9:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 310
> > 
> >
> > Please use a C++ cast.
> 
> Alex Clemmer wrote:
> I don't really know enough about C++ casts to know what the "right thing" 
> to do here is. My simpleton's understanding is the preference is: (1) 
> `static_cast` (2) `dynamic_cast`, and (3) `reinterpret_cast`. That said, I 
> think only the last works, so that's what I guessed you wanted.

Yep, you did the right thing.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/#review129003
---


On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46191/
> ---
> 
> (Updated April 15, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `uname` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 15, 2016, 6:32 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/
---

(Updated April 15, 2016, 6:51 a.m.)


Review request for mesos, Adam B and Alexander Rojas.


Summary (updated)
-

Added a realm parameter to `process::initialize` (libprocess).


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description (updated)
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds a parameter to
process::initialize which allows the authentication
realm of such endpoints to be set when libprocess is
initialized.


Diffs (updated)
-

  3rdparty/libprocess/include/process/gtest.hpp 
3e0887257e1484813b3547170a5a1b9bb89de0d2 
  3rdparty/libprocess/include/process/process.hpp 
77e96957ca556cf9a7e2bf427d6762572fe48c51 
  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
  3rdparty/libprocess/src/tests/main.cpp 
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 

Diff: https://reviews.apache.org/r/46254/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Review Request 46260: Added a MetricsTest with authentication to libprocess.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46260/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

The test `MetricsTest.SnapshotAuthenticationEnabled`
is added to the libprocess tests in this patch.


Diffs
-

  3rdparty/libprocess/src/tests/metrics_tests.cpp 
b84dc8d858f58bc9f52b218b7153510417cf34c2 

Diff: https://reviews.apache.org/r/46260/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46261/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

The tests `MetricsTest.AgentAuthenticationEnabled` and
`MetricsTest.MasterAuthenticationEnabled` are added in
this patch.


Diffs
-

  src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 

Diff: https://reviews.apache.org/r/46261/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46261/
---

(Updated April 15, 2016, 7:01 a.m.)


Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

The tests `MetricsTest.AgentAuthenticationEnabled` and
`MetricsTest.MasterAuthenticationEnabled` are added in
this patch.


Diffs (updated)
-

  src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 

Diff: https://reviews.apache.org/r/46261/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/
---

(Updated April 15, 2016, 7:11 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Libprocess: [2/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 

Diff: https://reviews.apache.org/r/44131/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 46249: Support hook/module process operation before main process initialize.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129072
---



Bad patch!

Reviews applied: [46249]

Failed command: ./support/apply-review.sh -n -r 46249

Error:
2016-04-15 07:30:52 URL:https://reviews.apache.org/r/46249/diff/raw/ [696/696] 
-> "46249.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12542/console

- Mesos ReviewBot


On April 15, 2016, 3:54 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 15, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, it will auto use process 
> initialize fucntion, as the process::initialize will only call once,then in 
> the main fucnton process initialize  process::initialize("master") will not 
> be called. So the HTTP request process "delegate" will be wrong, http request 
> will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp ea7f0fc 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

[Alex Clemmer]

> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > 
> >
> > Do we have plans to implement this in stout?

We do not. We could, but no one really needs it right now. Do you think we 
should?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
---


On April 15, 2016, 8:01 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> ---
> 
> (Updated April 15, 2016, 8:01 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Moved process tests to their own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 400c6dc451602926f93b22713af8c66d7ca59ca6 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> c9d331df2f4496183b5734d2434413f68b9c1b4b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 9bd34c7508cd813c5de18028956f6a740997c266 
> 
> Diff: https://reviews.apache.org/r/46014/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 46254: Added a default authentication realm to libprocess tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/
---

Review request for mesos, Adam B and Ben Mahler.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

Both the initialization code in the libprocess tests
main.cpp as well as some of the test code needs access
to a common authentication realm; this patch adds such
a realm.


Diffs
-

  3rdparty/libprocess/include/process/gtest.hpp 
3e0887257e1484813b3547170a5a1b9bb89de0d2 
  3rdparty/libprocess/src/tests/main.cpp 
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 

Diff: https://reviews.apache.org/r/46254/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
---

(Updated 四月 15, 2016, 6:37 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Ignored the DOCKER_VOLUME volume source.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46255/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

In order to enable authentication on libprocess-level
HTTP endpoints, this patch adds code to the master and
agent's main.cpp file which makes use of the new
`authenticationRealm` argument to `process::initialize`
which allows the authentication realm of such endpoints
to be set when libprocess is initialized. The argument is
added to libprocess initialization in the tests as well.


Diffs
-

  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 
  src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 

Diff: https://reviews.apache.org/r/46255/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann

Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46264/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed a typo in docker_containerizer_tests.cpp.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
7accd32fba5eed196a82b1a171cb16d37b9e0539 

Diff: https://reviews.apache.org/r/46264/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 46249: hook/module process operation before main process initialize.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---

(Updated 四月 15, 2016, 8:09 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Summary (updated)
-

hook/module process operation before main process initialize.


Repository: mesos


Description
---

If we in hook/module manager use libprocess library, it will auto use process 
initialize fucntion, as the process::initialize will only call once,then in the 
main fucnton process initialize  process::initialize("master") will not be 
called. So the HTTP request process "delegate" will be wrong, http request will 
not be response.


Diffs
-

  src/master/main.cpp ea7f0fc 

Diff: https://reviews.apache.org/r/46249/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

[Michael Park]

> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > 
> >
> > Do we have plans to implement this in stout?
> 
> Alex Clemmer wrote:
> We do not. We could, but no one really needs it right now. Do you think 
> we should?

No, I was just curious whether we could simply reorder a patch to avoid this.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
---


On April 15, 2016, 8:01 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> ---
> 
> (Updated April 15, 2016, 8:01 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Moved process tests to their own file.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 400c6dc451602926f93b22713af8c66d7ca59ca6 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> c9d331df2f4496183b5734d2434413f68b9c1b4b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 9bd34c7508cd813c5de18028956f6a740997c266 
> 
> Diff: https://reviews.apache.org/r/46014/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
---

(Updated April 15, 2016, 6:25 a.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212


Repository: mesos


Description
---

When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.


Diffs (updated)
-

  src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/reservation_endpoints_tests.cpp 
f014290ed9f279df4c774aeb7ce7bd38fd1cc854 

Diff: https://reviews.apache.org/r/46242/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44123/
---

(Updated April 15, 2016, 7:10 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: [1/2] Implemented assorted `os::` functions on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/44123/diff/


Testing
---

OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/
---

(Updated April 15, 2016, 7:50 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471


Repository: mesos


Description
---

Stout: Implemented `os::processes` on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/46013/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Alex Clemmer]

> On April 14, 2016, 9:10 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183
> > 
> >
> > (1) It seems like this should live in `posix/os.hpp`.
> > (2) The declaration of this function in `windows/os.hpp` is:
> > ```
> > inline Result process(pid_t pid);
> > ```
> > It seems like the windows version needs all 3 states whereas the POSIX 
> > version only needs 2?
> > If that is the case, I think it makes sense to consolidate to using 
> > `Result` in both cases and
> > leave a comment on the POSIX version that we have the 3 states because 
> > of Windows.

I think I must be missing something. There is a version of `process` that 
returns a `Result` in `linux.hpp`, `osx.hpp`, and so on -- the version whose 
prototype you mention here is just the Windows implementation of this.

For the function you are highlighting here in your comment, which returns 
`Option`, this is separate -- it is meant to be shared among all platforms. 
There is no need for it to return `Result` because it is just finding a process 
with a certain `pid` in a list of processes.

So, my recommendation is to keep it the way it is.

Thoughts?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review128983
---


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> ---
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/
---

(Updated April 15, 2016, 8:01 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471


Repository: mesos


Description
---

Stout:[1/2] Moved process tests to their own file.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
400c6dc451602926f93b22713af8c66d7ca59ca6 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
c9d331df2f4496183b5734d2434413f68b9c1b4b 
  3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
9bd34c7508cd813c5de18028956f6a740997c266 

Diff: https://reviews.apache.org/r/46014/diff/


Testing
---


Thanks,

Alex Clemmer