Re: Review Request 46249: Hook and module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/ --- (Updated 四月 18, 2016, 5:41 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 四月 18, 2016, 5:41 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On 四月 11, 2016, 2:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > // value,unit,event,cgroup,running,ratio

Re: Review Request 36816: Supported HTTP in Mesos health check program.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review129287 --- src/docker/executor.cpp (line 385)

Re: Review Request 36816: Supported HTTP in Mesos health check program.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review129286 --- include/mesos/mesos.proto (line 312)

Re: Review Request 46075: Update docs to reflect /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46075/#review129284 --- Patch looks great! Reviews applied: [45014, 46075] Passed

Re: Review Request 46075: Update docs to reflect /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46075/ --- (Updated April 18, 2016, 3:39 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 18, 2016, 3:38 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 46249: hook/module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129281 --- Bad patch! Reviews applied: [46249] Failed command:

Re: Review Request 46249: hook/module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/ --- (Updated 四月 18, 2016, 2:44 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

> On 四月 18, 2016, 12:59 a.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase? Hi Vinod, has rebased the code, please take a look, thanks - zhou --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46190/ --- (Updated 四月 18, 2016, 2:31 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46189/ --- (Updated 四月 18, 2016, 2:31 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46249: hook/module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129278 --- src/master/main.cpp (lines 195 - 196)

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129272 --- Patch looks great! Reviews applied: [46307] Passed command:

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/ --- (Updated April 17, 2016, 10:46 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

> On April 15, 2016, 10:56 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 66 > > > > > > `std::unique_ptr` semantically means that it's pointing to a single > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 17, 2016, 10:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 15, 2016, 11:31 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 362 > > > > > > What's the difference between `Failed to call X` vs `Call to `X` > >

Re: Review Request 46308: Moved LogProcess declaration to log/log.h.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46308/#review129269 --- Patch looks great! Reviews applied: [45900, 45901, 46160, 46161,

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 5:15 p.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129265 --- Bad patch! Reviews applied: [46307] Failed command:

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

> On April 16, 2016, 9:41 p.m., Jie Yu wrote: > > src/log/log.cpp, lines 742-744 > > > > > > Can you move this to the top of the file? > > Kapil Arya wrote: > That won't work right away coz LogProcess, etc. are

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46295/ --- (Updated April 17, 2016, 12:47 p.m.) Review request for mesos and Jie Yu.

Review Request 45673: PoC: Docker Volume Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45673/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 3:11 p.m.) Review request for mesos, Ben Mahler, Neil

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 3:11 p.m.) Review request for mesos, Ben Mahler, Neil

Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- Review request for mesos, Ben Mahler, Neil Conway, and Timothy Chen. Bugs:

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

> On April 16, 2016, 9:41 p.m., Jie Yu wrote: > > src/log/log.cpp, lines 742-744 > > > > > > Can you move this to the top of the file? That won't work right away coz LogProcess, etc. are declared in this file. So

Re: Review Request 36816: Supported HTTP in Mesos health check program.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review129261 --- Patch looks great! Reviews applied: [36816] Passed command:

Re: Review Request 36816: Supported HTTP in Mesos health check program.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated April 17, 2016, 9:14 a.m.) Review request for mesos, Adam B, Michael