Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54216/#review160483 --- Patch looks great! Reviews applied: [54211, 54212, 54213, 54214,

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 4, 2017, 2:07 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

> On Dec. 14, 2016, 8:45 p.m., Joris Van Remoortere wrote: > > I ran this with `./libprocess-tests --gtest_filter="*FutureTest*After3*" > > --gtest_repeat=1000 --gtest_break_on_failure` and ran into the following: > > > > ``` > > Repeating all tests (iteration 412) . . . > > > > Note: Google

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/ --- (Updated Jan. 4, 2017, 3:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55152: Fixed nested container docs and added a link to home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55152/#review160552 --- Patch looks great! Reviews applied: [54013, 54073, 54074, 55152]

Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/ --- Review request for mesos, Avinash sridharan, Jie Yu, and Jiang Yan Xu. Bugs:

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review160553 --- Ship it! Thanks for taking this on. Looks good. Can you run

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Jan. 4, 2017, 7:58 p.m., Jie Yu wrote: > > src/docker/docker.hpp, lines 137-145 > > > > > > Feel that this belongs to higher level components (i.e., docker > > containerizer, docker executor). > > > >

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55160/#review160557 --- Patch looks great! Reviews applied: [54821, 51052, 55160]

Review Request 55177: Fixed scheme handling in URL::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55177/ --- Review request for mesos, Benjamin Mahler and Timothy Chen. Repository: mesos

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54358: Introduced ControlFlow for process::loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54358/#review160472 --- Getting my head around the overall layout of this. I'll get into

Re: Review Request 55149: Added the `mesos-cni-port-mapper` to the CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55149/#review160469 --- Patch looks great! Reviews applied: [55149] Passed command:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160513 --- 3rdparty/stout/include/stout/os/linux.hpp (lines 57 - 60)

Re: Review Request 54537: Support 'Basic' auth docker registry on Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54537/#review160475 --- Patch looks great! Reviews applied: [54537] Passed command:

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54821/#review160519 --- src/docker/docker.hpp (lines 137 - 145)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160541 --- 3rdparty/stout/include/stout/os/linux.hpp (line 72)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 4, 2017, 9:28 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:58 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, lines 57-60 > > > > > > I would actually suggest keep this `create` method, but move the > > allocation logic in `create`.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 82 > > > > > > You should explictly delete the copy constructors here to ensure the > > stack can't be leaked if

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 63 > > > > > > I'd recommend something like this: > > ``` > > Try allocate(size_t nbytes) { > > int

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 4, 2017, 5:41 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 120 > > > > > > Consider hoisting this into the `Stack` class: > > > > ``` > > void * Stack::start()

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 4, 2017, 9:55 p.m.) Review request for mesos and Jie Yu.