Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

2018-01-14 Thread Qian Zhang
> On Jan. 9, 2018, 8:04 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 9221-9246 (patched) > > > > > > Kill this. See above comments. > > Qian Zhang wrote: > The reason I did this change is, only

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

2018-01-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/ --- (Updated Jan. 15, 2018, 2:21 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 64857: Updated example frameworks for mesos-local.

2018-01-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/#review195409 --- PASS: Mesos patch 64857 was successfully built and tested.

Re: Review Request 65156: Detached the virtual paths regardless of the result of gc.

2018-01-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/ --- (Updated Jan. 15, 2018, 9:16 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65156: Detached the virtual paths regardless of the result of gc.

2018-01-14 Thread Qian Zhang
> On Jan. 15, 2018, 3:01 a.m., Vinod Kone wrote: > > Can you expand on the description on why this change is necessary? Done. - Qian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 64848: Updated example frameworks to make use of added flags.

2018-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64848/ --- (Updated Jan. 15, 2018, 12:29 a.m.) Review request for mesos, Alexander

Re: Review Request 64857: Updated example frameworks for mesos-local.

2018-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/ --- (Updated Jan. 15, 2018, 12:29 a.m.) Review request for mesos, Alexander

Re: Review Request 64847: Added collection of example framework flag definitions.

2018-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/ --- (Updated Jan. 15, 2018, 12:29 a.m.) Review request for mesos, Alexander

Re: Review Request 64849: Added authentication to some example frameworks.

2018-01-14 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/ --- (Updated Jan. 15, 2018, 12:29 a.m.) Review request for mesos, Alexander

Re: Review Request 64911: Refactored connection logic in libprocess.

2018-01-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64911/#review195407 --- FAIL: Failed to apply the dependent review: 55323. Failed

Re: Review Request 64911: Refactored connection logic in libprocess.

2018-01-14 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64911/#review195406 --- Refactoring looks good, but I was curious about a change below

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

2018-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195404 --- src/slave/slave.cpp Lines 2813 (patched)

Re: Review Request 65156: Detached the virtual paths regardless of the result of gc.

2018-01-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/#review195403 --- Ship it! Can you expand on the description on why this change

Re: Review Request 65156: Detached the virtual paths regardless of the result of gc.

2018-01-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/#review195401 --- PASS: Mesos patch 65156 was successfully built and tested.

Re: Review Request 64978: Made task's volume directory visible in the /files endpoints.

2018-01-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/ --- (Updated Jan. 14, 2018, 10:30 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 65156: Detached the virtual paths regardless of the result of gc.

2018-01-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65156/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8444