Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212607 --- Ship it! LGTM, this seems to even be a simplification over the

Review Request 69912: Added agent/RP IDs to some operation updates generated by the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69912/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9559

Review Request 69913: Added more operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69913/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9473

Review Request 69907: Fixed variable names in `Master::_doRegistryGC()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69907/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Repository: mesos

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > Thanks for fixing this! Can you add a test? Hm.. yeah I pondered that, let me think again if there's a sane test. My first impression was that I would have to write a very particular white box test, which seemed not so great. Any suggestions

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212619 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/#review212615 --- PASS: Mesos patch 69909 was successfully built and tested.

Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9473

Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9473

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1818 (patched) > > > > > > why not put `.allocatableTo(role)` like below? > > ditto blew in the second

Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-8887

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1818 (patched) > > > > > > why not put `.allocatableTo(role)` like below? > > ditto blew in the second

Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69908/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-8887

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212609 --- include/mesos/mesos.proto Lines 1541 (patched)

Re: Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69908/#review212611 --- PASS: Mesos patch 69908 was successfully built and tested.

Re: Review Request 69913: Added more operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69913/#review212620 --- PASS: Mesos patch 69913 was successfully built and tested.

Re: Review Request 69900: Reduced unnecessary agent lookups in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69900/#review212603 --- Ship it! Ship It! - Benjamin Bannier On Feb. 5, 2019, 11:30