Re: Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70034/#review213027 --- Ship it! I was about to propose adding this to our style guide

Re: Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70034/#review213026 --- PASS: Mesos patch 70034 was successfully built and tested.

Re: Review Request 68187: Always built shared protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68187/#review213018 --- Patch looks great! Reviews applied: [68187] Passed command:

Re: Review Request 65116: Getting Started using the Mesos Binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65116/#review213021 --- Bad review! Reviews applied: [65116] Error: 2019-02-21 11:10:01

Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70034/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos

Re: Review Request 68736: Added `task cat` command to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68736/#review213023 --- Bad review! Reviews applied: [68736, 68711, 68950, 68949]

Re: Review Request 68761: Made the actors in resource providers managed by libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68761/#review213024 --- Bad review! Reviews applied: [68761, 68760, 68759] Error:

Re: Review Request 70022: Added master load tests to cmake build.

> On Feb. 20, 2019, 4:17 p.m., Benjamin Bannier wrote: > > LGTM. We should also run `support/mesos-tidy.sh`. That setup depends on > > cmake and we could see new failures from adding the file there. I kicked > > off a run. > > Benjamin Bannier wrote: > Our tidy checks report something

Re: Review Request 68814: Added a test for `Option` / `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68814/#review213033 --- Patch looks great! Reviews applied: [68813, 68814] Passed

Re: Review Request 68807: Used `Future::discard` to abort an outdated resuorce provider launches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68807/#review213028 --- Patch looks great! Reviews applied: [68755, 68756, 68757, 68777,

Re: Review Request 70037: Bumped SVN yum repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70037/#review213038 --- Ship it! Ship It! - Gilbert Song On Feb. 21, 2019, 11 a.m.,

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

> On Feb. 20, 2019, 6:13 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 7452 (patched) > > > > > > Is it possible that the stream could still be present on disk, but the > > operation would not be found

Re: Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68903/#review213049 --- Bad review! Reviews applied: [68903] Error: 2019-02-21 20:26:21

Re: Review Request 70037: Bumped SVN yum repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70037/#review213039 --- Ship it! Ship It! - Vinod Kone On Feb. 21, 2019, 7 p.m.,

Review Request 70037: Bumped SVN yum repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70037/ --- Review request for mesos, James DeFelice and Vinod Kone. Repository: mesos

Re: Review Request 70011: Modified `LOGROTATE_CustomRotateOptions` test after memfd change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70011/#review213041 --- Ship it! Ship It! - Gilbert Song On Feb. 19, 2019, 9:06

Re: Review Request 70010: Store `logrotate` config in memfd file instead of container's sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70010/#review213032 --- Fix it, then Ship it! When I was testing the containerizer

Re: Review Request 69960: Added the concept of "orphaned operations" to the master.

> On Feb. 20, 2019, 1:40 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 10694-10696 (patched) > > > > > > What happens if `_allocate()` is executed on the allocator actor in > > between

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69287/#review213047 --- Fix it, then Ship it!

Re: Review Request 70009: Exposed `memfd_create` syscall via `createMemFd` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70009/#review213010 --- Fix it, then Ship it! src/linux/memfd.hpp Lines 39 (patched)

Re: Review Request 70037: Bumped SVN yum repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70037/#review213050 --- PASS: Mesos patch 70037 was successfully built and tested. All

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/#review213040 --- Bad review! Reviews applied: [68508, 68507] Error: 2019-02-21

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213043 --- Fix it, then Ship it! The patch LGTM. Thanks for working on

Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/#review213053 --- Bad review! Reviews applied: [68919] Error: 2019-02-21 21:46:07

Re: Review Request 69403: Removed empty filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69403/#review213076 --- Patch looks great! Reviews applied: [69035, 69036, 69357, 69359,

Re: Review Request 68090: Added log_auto_compact flag to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68090/#review213065 --- Patch looks great! Reviews applied: [68089, 68090] Passed

Re: Review Request 69977: Improved agent operation recovery process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69977/#review213064 --- Fix it, then Ship it! Noticed an orthogonally related

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69287/#review213066 --- PASS: Mesos patch 69287 was successfully built and tested.

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review213063 --- Fix it, then Ship it! src/slave/slave.cpp Lines 4739-4740

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Feb. 21, 2019, 11:58 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 165-167 (original), 181-183 (patched) > > > > > > Sorry, I was wrong. Would you mind

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 22, 2019, 1:43 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69287/ --- (Updated Feb. 22, 2019, 1:44 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69977: Improved agent operation recovery process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69977/ --- (Updated Feb. 21, 2019, 5:52 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review213056 --- Bad review! Reviews applied: [68916, 68915, 68914, 68913, 68906,

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Feb. 21, 2019, 8:06 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.hpp > > Lines 23 (patched) > > > > > > nits: > > > > newline above (usually we do that if the

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213061 --- Fix it, then Ship it!

Re: Review Request 69962: Added cleanup logic for orphaned operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69962/ --- (Updated Feb. 21, 2019, 4:06 p.m.) Review request for mesos, Benno Evers,

Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Bugs:

Re: Review Request 70016: Supported CUDA 10+ images that are based on nvidia-container-runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70016/ --- (Updated Feb. 21, 2019, 11:03 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69980: Modified when master responds to operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/ --- (Updated Feb. 21, 2019, 4:07 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70014: Removed operations when removing resource providers.

> On Feb. 20, 2019, 5:09 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 8372-8387 (patched) > > > > > > Do we recover the resources associated with non-terminal, > > non-speculative operations in this

Re: Review Request 69960: Added the concept of "orphaned operations" to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69960/ --- (Updated Feb. 21, 2019, 4:06 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69977: Improved agent operation recovery process.

> On Feb. 21, 2019, 5:19 p.m., Joseph Wu wrote: > > src/slave/slave.cpp > > Lines 7337 (patched) > > > > > > The SLRP uses this method like this: > > ``` > > Try> operationPaths = > >

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/ --- (Updated Feb. 21, 2019, 5:56 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 70016: Supported nvidia-docker 2.0 for CUDA 10+.

> On Feb. 20, 2019, 9:50 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > > Lines 418 (patched) > > > > > > This has the same limitations that the original nvidia-docker does,

Re: Review Request 70016: Supported CUDA 10+ images that are based on nvidia-container-runtime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70016/ --- (Updated Feb. 21, 2019, 10:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69960: Added the concept of "orphaned operations" to the master.

> On Feb. 20, 2019, 1:22 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 156 (patched) > > > > > > s/Marks a non-terminal, non-speculative/Marks a non-speculative/ I think this method will also be called

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 21, 2019, 11:34 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69287/ --- (Updated Feb. 21, 2019, 11:35 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

> On Feb. 21, 2019, 8:08 p.m., Gilbert Song wrote: > > src/tests/containerizer/volume_host_path_isolator_tests.cpp > > Lines 30 (patched) > > > > > > newline above Done. > On Feb. 21, 2019, 8:08 p.m., Gilbert Song

Re: Review Request 70014: Removed operations when removing resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70014/ --- (Updated Feb. 21, 2019, 4:07 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69869: Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/ --- (Updated Feb. 21, 2019, 4:08 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69872/ --- (Updated Feb. 21, 2019, 4:08 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69967: Added a recovery path for orphan operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69967/ --- (Updated Feb. 21, 2019, 4:07 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213070 --- Ship it! Ship It! - Gilbert Song On Feb. 21, 2019, 5:43

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review213074 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70040: Added test for terminal operation updates after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70040/#review213071 --- PASS: Mesos patch 70040 was successfully built and tested.

Re: Review Request 69325: WIP: Fixed CSI build problems for `make distcheck`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69325/#review213073 --- Patch looks great! Reviews applied: [69325] Passed command:

Re: Review Request 69287: Added test cases for the `volume/host_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69287/#review213075 --- FAIL: Some of the unit tests failed. Please check the relevant