Review Request 70151: Added `class ResourceLimits`.

2019-03-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70151/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9608 https://issu

Review Request 70149: Added a `contains` method in `ResourceQuantities`.

2019-03-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70149/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 70150: Added a constructor for `ResourceQuantities`.

2019-03-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70150/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 69582: Added a test to verify a bug fix for the master.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213511 --- Patch looks great! Reviews applied: [70147, 69582] Passed comman

Re: Review Request 70142: Added ARCHIVE_EXTRACT_SECURE_NODOTDOT flag to archiver default.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70142/#review213510 --- Patch looks great! Reviews applied: [70142] Passed command: expo

Review Request 70148: Added `>`, `<` and `>=` operators to `Value::Scalar`.

2019-03-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70148/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

2019-03-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/ --- (Updated March 6, 2019, 6:35 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70147/ --- (Updated March 7, 2019, 12:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70147/ --- (Updated March 7, 2019, 12:25 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69582: Added a test to verify a bug fix for the master.

2019-03-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/ --- (Updated March 7, 2019, 12:11 a.m.) Review request for mesos, Benno Evers, Chun

Review Request 70147: WIP: Added a Sequence to the master to order updates to agent resources.

2019-03-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70147/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, Joseph Wu, and Meng Z

Review Request 70142: Added ARCHIVE_EXTRACT_SECURE_NODOTDOT flag to archiver default.

2019-03-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70142/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Greg Mann. Bugs: MES

Re: Review Request 70077: Added documentation regarding downgrading a Mesos cluster.

2019-03-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70077/#review213498 --- Ship it! I can tweak the below before committing. Also, I'll a

Re: Review Request 67762: Added minimum capability check during master recovery.

2019-03-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213496 --- Ship it! I can tweak the below before committing. src/master/

Re: Review Request 70131: Added a comment around recovery for `ContainerLogger`s.

2019-03-06 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70131/#review213494 --- Ship it! Ship It! - Till Toenshoff On March 5, 2019, 10:42 p

[GitHub] [mesos] asfgit closed pull request #325: Added Andrei Sekretenko to "contributors.yaml".

2019-03-06 Thread GitBox
asfgit closed pull request #325: Added Andrei Sekretenko to "contributors.yaml". URL: https://github.com/apache/mesos/pull/325 This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70140/#review213493 --- Bad review! Reviews applied: [70140, 70139, 70138, 70137] Error:

[GitHub] [mesos] asekretenko opened a new pull request #325: Added Andrei Sekretenko to "contributors.yaml".

2019-03-06 Thread GitBox
asekretenko opened a new pull request #325: Added Andrei Sekretenko to "contributors.yaml". URL: https://github.com/apache/mesos/pull/325 This is an automated message from the Apache Git Service. To respond to the message, p

Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213490 --- Patch looks great! Reviews applied: [70129] Passed command: expo

Re: Review Request 70093: Added license header to some Python source files.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70093/#review213487 --- Fix it, then Ship it! src/python/scheduler/src/mesos/__init__.

Re: Review Request 70094: Fixed garbled license header.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70094/#review213488 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213489 --- As per Benjamin's private comments, I'll wait a few days before co

Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70140/ --- (Updated March 6, 2019, 10:36 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 70129: Updated advanced contributing guide.

2019-03-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/ --- (Updated March 6, 2019, 2:32 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70140/#review213485 --- Bad review! Reviews applied: [70140, 70139, 70138, 70137] Error:

Review Request 70140: Updated UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70140/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8813

Review Request 70139: Updated ROOT_UNPRIVILEGED_USER_PersistentVolumes to cover non-shared PV.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70139/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8813

Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70137/ --- (Updated March 6, 2019, 10:03 p.m.) Review request for mesos, Andrei Budnik and

Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70137/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8813

Review Request 70138: Replaced reading mounttable with getting path gid in volume gid manager.

2019-03-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70138/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8813

Re: Review Request 70095: Fixed cpplint issues in the Java bindings.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70095/#review213484 --- Fix it, then Ship it! src/java/jni/convert.cpp Line 55 (origin

Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70099/#review213481 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70102/#review213480 --- Ship it! Semantics over syntax! - Alexander Rukletsov On Mar

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review213483 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70098: Made cpplint.patch reflect our modifications.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70098/#review213482 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70100: Skipped pylint for cpplint.py per config instead of per patch.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70100/#review213478 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70101: Removed manual author list cpplint.patch.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70101/#review213479 --- Ship it! I can't think of a legal reason, i.e., license require

Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70099/#review213477 --- support/mesos-style.py Line 266 (original), 266 (patched)

Re: Review Request 69615: Disable containerizer ptrace attach.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review213473 --- Patch looks great! Reviews applied: [69615] Passed command: expo

Re: Review Request 70098: Made cpplint.patch reflect our modifications.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70098/#review213470 --- Looking at this deeper, I'm not sure we should explicitly maintain

Re: Review Request 70097: Reverted untracked and unneeded cpplint modification.

2019-03-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70097/#review213469 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

2019-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70133/#review213468 --- Patch looks great! Reviews applied: [70132, 70133] Passed comman