Re: Review Request 70804: Used the new quota struct for the allocator recover call.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70804/#review215743 --- Patch looks great! Reviews applied: [70799, 70800, 70801, 70802,

Re: Review Request 70777: WIP: Stopped using rDNS for hostname validation.

2019-06-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70777/ --- (Updated June 7, 2019, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 70809: Fixed non-deferred callback calling Master::send() in UpdateFramework.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70809/#review215746 --- Patch looks great! Reviews applied: [70809] Passed command:

Review Request 70809: Fixed non-deferred callback calling Master::send() in UpdateFramework.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70809/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs:

Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

2019-06-07 Thread Benno Evers
> On May 31, 2019, 3:05 p.m., Alexander Rukletsov wrote: > > The code looks good to me. Thanks! > > > > As part of this change, either here or in separate reviews, let us: > > - call out the modification in the changelog; > > - mention taken approach in MESOS-9791 and explain why (based on the

Review Request 70810: Updated SSL docs with suggested runtime configuration.

2019-06-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70810/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.

Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70752/ --- (Updated June 7, 2019, 4:26 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70752/ --- (Updated June 7, 2019, 4:26 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70810: Updated SSL docs with suggested runtime configuration.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70810/#review215752 --- Patch looks great! Reviews applied: [70810] Passed command:

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

2019-06-07 Thread Andrei Sekretenko
> On June 6, 2019, 9:11 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2196-2200 (patched) > > > > > > Oh, this gate doesn't really accomplish much? > > > > I

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- (Updated June 7, 2019, 4:21 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215759 --- src/slave/containerizer/mesos/launch.cpp Line 508 (original),

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215755 --- Ship it! Ship It! - Gilbert Song On June 7, 2019, 10:21

Re: Review Request 70738: Allow roles to burst up to quota limits in the allocator.

2019-06-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215754 --- Fix it, then Ship it! We've come a long way, the allocation

Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70813/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing - WIP

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70814/ --- (Updated June 7, 2019, 6:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 70756: Refactored some of `MasterAPITest`s using MockMasterAPISubscriber.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70756/#review215761 --- Patch looks great! Reviews applied: [70532, 70663, 70664, 70665,

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/ --- (Updated June 7, 2019, 6:05 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70814/ --- Review request for mesos. Repository: mesos Description --- Added

Review Request 70815: Added using updateFramework() to java V0 example framework.

2019-06-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70815/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/#review215764 --- Patch looks great! Reviews applied: [70778, 70782] Passed

Re: Review Request 70811: Fixed compilation error on Mac OS.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215768 --- Patch looks great! Reviews applied: [70811] Passed command:

Re: Review Request 70815: Added using updateFramework() to java V0 example framework.

2019-06-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70815/#review215765 --- Bad patch! Reviews applied: [70815, 70814, 70813, 70755, 70754,