Review Request 72067: Improved performance of v1 agent operator API GET_STATE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72067/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Bugs: MESOS-10026

Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72065/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Bugs: MESOS-10026

Re: Review Request 72056: Improved performance of v1 agent operator API GET_METRICS call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72056/ --- (Updated Jan. 30, 2020, 9:31 p.m.) Review request for mesos, Andrei Sekretenko

Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72064/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Bugs: MESOS-10026

Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72066/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Bugs: MESOS-10026

Re: Review Request 72068: Removed dead code from v1 API serialization changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72068/#review219443 --- Bad patch! Reviews applied: [72056, 72064, 72065, 72066, 72067,

Re: Review Request 72029: Changed termination logic of the default executor.

> On Jan. 30, 2020, 12:14 a.m., Greg Mann wrote: > > The patch looks great, thanks Andrei. What about adding a test for this, > > would it be hard? I'm imagining something like: > > 1) kill a task under the default executor > > 2) intercept the ACK from agent to executor > > 3) verify that the

Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72064/ --- (Updated Jan. 30, 2020, 9:45 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72029: Changed termination logic of the default executor.

> On Jan. 30, 2020, 12:14 a.m., Greg Mann wrote: > > The patch looks great, thanks Andrei. What about adding a test for this, > > would it be hard? I'm imagining something like: > > 1) kill a task under the default executor > > 2) intercept the ACK from agent to executor > > 3) verify that the

Review Request 72068: Removed dead code from v1 API serialization changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72068/ --- Review request for mesos, Andrei Sekretenko and Greg Mann. Repository: mesos

Re: Review Request 72029: Changed termination logic of the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72029/#review219441 --- Bad patch! Reviews applied: [72029] Failed command: ['bash',

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 29, 2020, 10:28 д.п., Qian Zhang wrote: > > The commit message seems not accurate to me: > > > This could lead to termination of the executor before receiving all > > > status update acknowledgments from the agent. > > > > I think the issue that we wanted to mitigate is, executor may

Re: Review Request 72029: Changed termination logic of the default executor.

> On Янв. 30, 2020, 12:14 д.п., Greg Mann wrote: > > The patch looks great, thanks Andrei. What about adding a test for this, > > would it be hard? I'm imagining something like: > > 1) kill a task under the default executor > > 2) intercept the ACK from agent to executor > > 3) verify that the

Re: Review Request 72029: Changed termination logic of the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72029/ --- (Updated Янв. 30, 2020, 3:28 п.п.) Review request for mesos, Andrei

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 30, 2020, 2:31 д.п., Qian Zhang wrote: > > src/docker/executor.cpp > > Lines 779-788 (original), 779-789 (patched) > > > > > > This seems a bit redundant to me, I'd suggest to only have: > > ``` > >

Re: Review Request 72055: Changed termination logic of the Docker executor.

> On Янв. 30, 2020, 12:18 д.п., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 781-783 (original), 781-783 (patched) > > > > > > Is there a reason to have a failsafe here, but not in the default > >