Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71886/ --- (Updated March 16, 2020, 5:07 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71885/ --- (Updated March 16, 2020, 5:06 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71858: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/ --- (Updated March 16, 2020, 5:04 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71884/ --- (Updated March 16, 2020, 5:05 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72027/ --- (Updated March 16, 2020, 5:17 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

> On March 11, 2020, 4:34 p.m., Greg Mann wrote: > > Could you update the description of this patch with a note that not all > > callsites of `Containerizer::update` are updated here, since some involve > > significant related code changes? In particular, I noticed that a couple > > callsites

Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/ --- (Updated March 16, 2020, 5:07 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219950 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

> On March 6, 2020, 8:06 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Line 663 (original), 714-716 (patched) > > > > > > Do we want to set the memory reservation here as well? > > Qian Zhang wrote: > I

Re: Review Request 72161: Added patch for RapidJSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72161/ --- (Updated March 16, 2020, 5:03 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72162/ --- (Updated March 16, 2020, 5:03 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- (Updated March 16, 2020, 5:13 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71955/ --- (Updated March 16, 2020, 5:13 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71952: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/ --- (Updated March 16, 2020, 5:12 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated March 16, 2020, 5:12 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72040/ --- (Updated March 16, 2020, 5:23 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/ --- (Updated March 16, 2020, 5:22 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219949 --- Bad review! Reviews applied: [72041, 72040, 72211, 72027, 72022,

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71951/ --- (Updated March 16, 2020, 5:11 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/ --- (Updated March 16, 2020, 5:11 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71944: Set container process's OOM score adjust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/ --- (Updated March 16, 2020, 5:10 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/ --- (Updated March 16, 2020, 5:24 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72022/ --- (Updated March 16, 2020, 5:16 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 16, 2020, 5:15 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72210/ --- (Updated March 16, 2020, 5:14 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219947 --- Bad review! Reviews applied: [7, 72221, 72217, 72216, 71955,

Re: Review Request 71944: Set container process's OOM score adjust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/ --- (Updated March 16, 2020, 3:17 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.

> On March 15, 2020, 5:04 p.m., Qian Zhang wrote: > > src/master/validation.cpp > > Lines 1554-1561 (patched) > > > > > > What about the task which does not set `share_cgroups` (or even not set > > `ContainerInfo`

Re: Review Request 71944: Set container process's OOM score adjust.

> On March 2, 2020, 9:50 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > > Lines 222 (patched) > > > > > > Why don't we want to set the OOM score adjustment for

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72022/#review219953 --- src/docker/executor.cpp Lines 201-212 (original), 201-212

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/#review219954 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72210/#review219955 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 842-845

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72210/ --- (Updated March 16, 2020, 9:51 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- (Updated March 16, 2020, 9:51 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 16, 2020, 9:52 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/ --- (Updated March 16, 2020, 9:52 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72162/ --- (Updated March 16, 2020, 9:51 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72027/ --- (Updated March 16, 2020, 9:52 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219952 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219956 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 498

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

> On March 16, 2020, 7:54 p.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 201-212 (original), 201-212 (patched) > > > > > > We also have the less common case of a custom executor in a Docker > >

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219959 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Review Request 72239: Added stack trace logging to program crashes on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72239/ --- Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu. Bugs:

Re: Review Request 72239: Added stack trace logging to program crashes on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72239/#review219962 --- Bad patch! Reviews applied: [72239] Failed command: ['bash',

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

> On March 16, 2020, 8:23 p.m., Greg Mann wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4624-4628 (patched) > > > > > > Are we sure this will hold for all systems? Can we just check

Re: Review Request 72239: Added stack trace logging to program crashes on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72239/#review219967 --- Patch looks great! Reviews applied: [72239] Passed command:

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219961 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

> On March 16, 2020, 8:44 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 465-473 (original), 525-533 (patched) > > > > > > Why are our expectations for CPU consumption

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

> On March 16, 2020, 8:31 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 842-845 (patched) > > > > > > Will this be true on all systems? Can we just check that the task > >

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

> On March 16, 2020, 8:44 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 465-473 (original), 525-533 (patched) > > > > > > Why are our expectations for CPU consumption