Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33531/#review81662 --- Patch looks great! Reviews applied: [33531] All tests passed. - M

Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33531/#review81660 --- LGTM. - Michael Park On April 27, 2015, 4:50 a.m., Joerg Schad wr

Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33572/#review81659 --- docs/mesos-c++-style-guide.md

Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

> On April 26, 2015, 10:40 p.m., Till Toenshoff wrote: > > Minor nit, please make sure your summary ends with a punctuation. For the > > description, we commonly enter "see summary" in cases where that one is > > descriptive enough for the commit. Thanks, fixed the dot. The description is actu

Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33531/ --- (Updated April 27, 2015, 4:50 a.m.) Review request for mesos, Alexander Rojas a

Re: Review Request 33266: Check patch command in configure.ac

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33266/#review81653 --- Ship it! Ship It! - Till Toenshoff On April 16, 2015, 5:30 p.m.,

Re: Review Request 32001: Required a period in trailing comments in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/#review81650 --- Ship it! Ship It! - Till Toenshoff On April 24, 2015, 1:53 p.m.,

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

> On April 23, 2015, 4:28 p.m., Till Toenshoff wrote: > > Ship It! When testing your patch, I noticed that it fails for me. ``` ../../src/tests/slave_tests.cpp:184: Failure Value of: status.get().reason() Actual: 8 Expected: TaskStatus::REASON_COMMAND_EXECUTOR_FAILED Which is: 0 ``` - Till

Re: Review Request 33527: Updated documentation for ClangFormat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527/#review81647 --- Patch looks great! Reviews applied: [33527] All tests passed. - M

Re: Review Request 33528: Create '.clang-format' from 'bootstrap' script instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33528/#review81646 --- Ship it! Ship It! - Till Toenshoff On April 26, 2015, 3:59 a.m.,

Re: Review Request 33527: Updated documentation for ClangFormat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527/ --- (Updated April 26, 2015, 9:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/#review81642 --- Patch looks great! Reviews applied: [33558] All tests passed. - M

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/#review81643 --- docs/mesos-c++-style-guide.md

Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33572/#review81638 --- LGTM. - Michael Park On April 26, 2015, 8:26 p.m., Benjamin Hindm

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

> On April 26, 2015, 3:51 a.m., Michael Park wrote: > > docs/mesos-c++-style-guide.md, lines 195-201 > > > > > > Alternative suggestion: > > > > ``` > > socket > > .send([]() { > > s1; > >

Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33572/ --- (Updated April 26, 2015, 8:26 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/ --- (Updated April 26, 2015, 8:26 p.m.) Review request for mesos, Ben Mahler, Joris

Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33572/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and Vi

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/ --- (Updated April 26, 2015, 8:18 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33568: libprocess: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33568/#review81631 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:14 a.m

Re: Review Request 33562: mesos: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33562/#review81626 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:02 a.m

Re: Review Request 33567: stout: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33567/#review81630 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:14 a.m

Re: Review Request 33569: mesos: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33569/#review81632 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:14 a.m

Re: Review Request 33565: libprocess: Removed and switched from memory:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33565/#review81628 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:12 a.m

Re: Review Request 33561: libprocess: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33561/#review81625 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:02 a.m

Re: Review Request 33564: stout: Removed and switched from 'memory::' to 'std::'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33564/#review81627 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:12 a.m

Re: Review Request 33566: mesos: Removed and switched from memory:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33566/#review81629 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:12 a.m

Re: Review Request 33560: stout: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33560/#review81624 --- Ship it! Ship It! - Benjamin Hindman On April 26, 2015, 7:02 a.m

Re: Review Request 33527: Updated documentation for ClangFormat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527/#review81619 --- Ship it! docs/clang-format.md

Re: Review Request 33569: mesos: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33569/#review81611 --- Patch looks great! Reviews applied: [33560, 33561, 33562, 33564, 33

Review Request 33567: stout: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33567/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33569: mesos: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33569/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33568: libprocess: Removed and switched from tuples:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33568/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33564: stout: Removed and switched from 'memory::' to 'std::'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33564/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33566: mesos: Removed and switched from memory:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33566/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33565: libprocess: Removed and switched from memory:: to std::.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33565/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 26, 2015, 7:10 a.m.) Review request for mesos and Jie Yu. Bugs

Review Request 33561: libprocess: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33561/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33560: stout: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33560/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte

Review Request 33562: mesos: Removed pre-C++11 codepath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33562/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoorte