Re: Review Request 33793: HTTP headers should be considered case-insensitive.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 3, 2015, 10:41 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-328 https://issues.apache.org/jira/browse/MESOS-328 Repository: mesos Description --- HTTP headers should be considered case-insensitive. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21 3rdparty/libprocess/include/process/http.hpp 5210ce07c8ea47cf67681455c2f5eb0fda4bb426 Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 30774: Fetcher Cache
On March 19, 2015, 9:40 a.m., Timothy Chen wrote: src/slave/containerizer/fetcher.cpp, line 379 https://reviews.apache.org/r/30774/diff/38/?file=899705#file899705line379 benh, what do you think of Bernd's contentionBarrier injection? commonly we always just mock the callback (_fetch in this case) in tests to block, but Bernd wanted to introduce a specific empty method for tests. I told him this is not a pattern we use in Mesos, but like to see what you think. Bernd Mathiske wrote: Of course I will stick to the prevalent patterns unless you start liking this one :-) Bernd Mathiske wrote: Turns out there is no method that offers itself opportunistically for the prevalent pattern. The next call up is AFTER waiting for the futures that the barrier needs to be BEFORE. Suggestions? Alternatives (without judging them): - Factor out the loop that gathers the futures and make it a method that gets called once. Then mock this method and have it dual-purposed as contention barrier. - Make the futures globally visible, await them in the test, too. - Use an explicit lock instead of mocking. Another option has been implemented in the latest patch: cut off the lower half of fetch() and call it _fetch(), then mock the latter. This variant ressembles existing other code the most. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review77057 --- On April 30, 2015, 7:40 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated April 30, 2015, 7:40 p.m.) Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2057, MESOS-2069, MESOS-2070, MESOS-2072, MESOS-2073, and MESOS-2074 https://issues.apache.org/jira/browse/MESOS-2057 https://issues.apache.org/jira/browse/MESOS-2069 https://issues.apache.org/jira/browse/MESOS-2070 https://issues.apache.org/jira/browse/MESOS-2072 https://issues.apache.org/jira/browse/MESOS-2073 https://issues.apache.org/jira/browse/MESOS-2074 Repository: mesos Description --- Almost all of the functionality in epic MESOS-336. Downloaded files from CommandInfo::URIs can now be cached in a cache directory designated by a slave flag. This only happens when asked for by an extra flag in the URI and is thus backwards-compatible. The cache has a size limit also given by a new slave flag. Cache-resident files are evicted as necessary to make space for newly fetched ones. Concurrent attempts to cache the same URI leads to only one download. The fetcher program remains external for safety reasons, but is now augmented with more elaborate parameters packed into a JSON object to implement specific fetch actions for all of the above. Additional testing includes fetching from (mock) HDFS and coverage of the new features. Diffs - docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b docs/fetcher-cache-internals.md PRE-CREATION docs/fetcher.md PRE-CREATION include/mesos/fetcher/fetcher.proto 311af9aebc6a85dadba9dbeffcf7036b70896bcc include/mesos/mesos.proto 967b1e3bbfb3f6b71d5a15d02cba7ed5ec21816f include/mesos/type_utils.hpp 044637481e5405d4d6f61653a9f9386edd191deb src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/hdfs/hdfs.hpp 968545d9af896f3e72e156484cc58135405cef6b src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec src/slave/containerizer/docker.hpp b25ec55bf3cd30d6e8a804d09d90c632a7d12e3f src/slave/containerizer/docker.cpp f9fc89ad7e3c853c3f9f6dcf9aa68e54dc1888c6 src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 src/slave/containerizer/mesos/containerizer.hpp 5e5f13ed8a71ff9510b40b6032d00fd16d312622 src/slave/containerizer/mesos/containerizer.cpp f2587280dc0e1d566d2b856a80358c7b3896c603 src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 src/tests/docker_containerizer_tests.cpp c9d66b3fbc7d081f36c26781573dca50de823c44 src/tests/fetcher_cache_tests.cpp PRE-CREATION src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e src/tests/mesos.hpp 19db71217f0a3f1ab17a6fd4408f8251410d731d src/tests/mesos.cpp bc082e8d91deb2c5dd64bbc3f0a8a50fa7d19264 Diff:
Re: Review Request 30774: Fetcher Cache
On March 10, 2015, 8:35 a.m., Benjamin Hindman wrote: src/launcher/fetcher.cpp, lines 403-404 https://reviews.apache.org/r/30774/diff/33/?file=888350#file888350line403 As mentioned above, it would be great to really capture the relationship between the FetcherInfo and the FetcherInfo::Item. If The FetcherInfo encapsulates the FetcherInfo::Item I would also suggest switching the order of the parameters to signify that. Bernd Mathiske wrote: The main purpose here is to fetch this one particular item, not everything FetcherInfo carries. FetcherInfo is a secondary parameter that provides extra parameters like cache_directory, sandbox_directory, and framework_home. Putting it second makes this relationship clear IMHO. Do you suggest adding all these as individual parameters? Yes, the item is included in the list of items in FetcherInfo. Shall we break up FetcherInfo into several shells, the inner one without items? Now using split up parameters instead of FetcherInfo to pass around sandbox dir, cache dir, frameworks home. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review75754 --- On April 30, 2015, 7:40 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated April 30, 2015, 7:40 p.m.) Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Bugs: MESOS-2057, MESOS-2069, MESOS-2070, MESOS-2072, MESOS-2073, and MESOS-2074 https://issues.apache.org/jira/browse/MESOS-2057 https://issues.apache.org/jira/browse/MESOS-2069 https://issues.apache.org/jira/browse/MESOS-2070 https://issues.apache.org/jira/browse/MESOS-2072 https://issues.apache.org/jira/browse/MESOS-2073 https://issues.apache.org/jira/browse/MESOS-2074 Repository: mesos Description --- Almost all of the functionality in epic MESOS-336. Downloaded files from CommandInfo::URIs can now be cached in a cache directory designated by a slave flag. This only happens when asked for by an extra flag in the URI and is thus backwards-compatible. The cache has a size limit also given by a new slave flag. Cache-resident files are evicted as necessary to make space for newly fetched ones. Concurrent attempts to cache the same URI leads to only one download. The fetcher program remains external for safety reasons, but is now augmented with more elaborate parameters packed into a JSON object to implement specific fetch actions for all of the above. Additional testing includes fetching from (mock) HDFS and coverage of the new features. Diffs - docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b docs/fetcher-cache-internals.md PRE-CREATION docs/fetcher.md PRE-CREATION include/mesos/fetcher/fetcher.proto 311af9aebc6a85dadba9dbeffcf7036b70896bcc include/mesos/mesos.proto 967b1e3bbfb3f6b71d5a15d02cba7ed5ec21816f include/mesos/type_utils.hpp 044637481e5405d4d6f61653a9f9386edd191deb src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/hdfs/hdfs.hpp 968545d9af896f3e72e156484cc58135405cef6b src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec src/slave/containerizer/docker.hpp b25ec55bf3cd30d6e8a804d09d90c632a7d12e3f src/slave/containerizer/docker.cpp f9fc89ad7e3c853c3f9f6dcf9aa68e54dc1888c6 src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 src/slave/containerizer/mesos/containerizer.hpp 5e5f13ed8a71ff9510b40b6032d00fd16d312622 src/slave/containerizer/mesos/containerizer.cpp f2587280dc0e1d566d2b856a80358c7b3896c603 src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 src/tests/docker_containerizer_tests.cpp c9d66b3fbc7d081f36c26781573dca50de823c44 src/tests/fetcher_cache_tests.cpp PRE-CREATION src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e src/tests/mesos.hpp 19db71217f0a3f1ab17a6fd4408f8251410d731d src/tests/mesos.cpp bc082e8d91deb2c5dd64bbc3f0a8a50fa7d19264 Diff: https://reviews.apache.org/r/30774/diff/ Testing --- make check --- longer Description: --- -Replaces all other reviews for the fetcher cache except those related to stout: 30006, 30033, 30034, 30036, 30037, 30039, 30124, 30173, 30614, 30616, 30618, 30621, 30626. See descriptions of
Review Request 33792: Add InsensitiveHashMap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-328 https://issues.apache.org/jira/browse/MESOS-328 Repository: mesos Description --- Add InsensitiveHashMap. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 79239d738d0607364f8c3d7addfd54a642bdffc0 3rdparty/libprocess/3rdparty/stout/include/stout/insensitivehashmap.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/insensitivehashmap_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang
Review Request 33793: HTTP headers should be considered case-insensitive.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-328 https://issues.apache.org/jira/browse/MESOS-328 Repository: mesos Description --- HTTP headers should be considered case-insensitive. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21 3rdparty/libprocess/include/process/http.hpp 5210ce07c8ea47cf67681455c2f5eb0fda4bb426 Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang
Review Request 33794: Update existing lambdas to meet style guide
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33794/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-2670 https://issues.apache.org/jira/browse/MESOS-2670 Repository: mesos Description --- I use [.*]\s*( to find all the lambda usages. Diffs - 3rdparty/libprocess/examples/example.cpp 3fb4ef54e18b377e432b8f8fc918563403e23ab0 Diff: https://reviews.apache.org/r/33794/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 33794: Update existing lambdas to meet style guide
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33794/ --- (Updated May 3, 2015, 10:31 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-2670 https://issues.apache.org/jira/browse/MESOS-2670 Repository: mesos Description (updated) --- Update existing lambdas to meet style guide. I use \[.*\]\s*\( to find all the lambda usages. Diffs - 3rdparty/libprocess/examples/example.cpp 3fb4ef54e18b377e432b8f8fc918563403e23ab0 Diff: https://reviews.apache.org/r/33794/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 33792: Add InsensitiveHashMap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review82338 --- Patch looks great! Reviews applied: [33792] All tests passed. - Mesos ReviewBot On May 3, 2015, 9:37 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 3, 2015, 9:37 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-328 https://issues.apache.org/jira/browse/MESOS-328 Repository: mesos Description --- Add InsensitiveHashMap. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 79239d738d0607364f8c3d7addfd54a642bdffc0 3rdparty/libprocess/3rdparty/stout/include/stout/insensitivehashmap.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/insensitivehashmap_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 33793: HTTP headers should be considered case-insensitive.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793/#review82339
---
Bad patch!
Reviews applied: [33793]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d mesos-0.23.0; then find mesos-0.23.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.23.0 || { sleep 5 rm -rf
mesos-0.23.0; }; else :; fi
test -d mesos-0.23.0 || mkdir mesos-0.23.0
(cd 3rdparty make top_distdir=../mesos-0.23.0
distdir=../mesos-0.23.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.23.0
distdir=../../mesos-0.23.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.23.0/3rdparty/libprocess || mkdir
../../mesos-0.23.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.23.0
distdir=../../../mesos-0.23.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[4]: *** No rule to make target `stout/tests/insensitivehashmap_tests.cpp',
needed by `distdir'. Stop.
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[3]: *** [distdir] Error 1
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: *** [distdir] Error 1
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On May 3, 2015, 9:38 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793/
---
(Updated May 3, 2015, 9:38 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-328
https://issues.apache.org/jira/browse/MESOS-328
Repository: mesos
Description
---
HTTP headers should be considered case-insensitive.
Diffs
-
3rdparty/libprocess/3rdparty/Makefile.am
519e38c2c22904e75f36b936142a915a8f615b21
3rdparty/libprocess/include/process/http.hpp
5210ce07c8ea47cf67681455c2f5eb0fda4bb426
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
Re: Review Request 33794: Update existing lambdas to meet style guide
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33794/ --- (Updated May 3, 2015, 10:33 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-2670 https://issues.apache.org/jira/browse/MESOS-2670 Repository: mesos Description (updated) --- I use \[.*\]\s*\( to find all the lambda usages. Diffs - 3rdparty/libprocess/examples/example.cpp 3fb4ef54e18b377e432b8f8fc918563403e23ab0 Diff: https://reviews.apache.org/r/33794/diff/ Testing --- make check Thanks, haosdent huang
Review Request 33795: Add a shutdownExecutor() method to the scheduler driver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33795/ --- Review request for mesos. Repository: mesos Description --- Add a shutdownExecutor() method to the scheduler driver Diffs - include/mesos/scheduler.hpp 2ee6b5cc0745b3ac4637bb97843a00024fb94570 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e src/master/metrics.hpp ee3982e38f23b0dcf92d6b1c39b650c3582c16a2 src/master/metrics.cpp 973f0517400786fb16f86914d1d077c88965c9da src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 src/sched/sched.cpp 8c366ec3e3cf55dacf49483e1ceeef61ab0187b3 Diff: https://reviews.apache.org/r/33795/diff/ Testing --- Thanks, haosdent huang
