Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82760 --- LGTM except for the naming. I would call it ResourceEstimator

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review82773 --- Patch looks great! Reviews applied: [33918, 33919] All tests

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727 --- src/master/http.cpp

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
On May 6, 2015, 8:41 p.m., Isabel Jimenez wrote: Besides this, LGTM! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82725 --- Ship it! LGTM! - Isabel Jimenez On May 6, 2015, 5:15 p.m.,

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- (Updated May 6, 2015, 9:32 p.m.) Review request for mesos, Isabel Jimenez and

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82730 --- src/master/http.cpp

Re: Review Request 33875: Removed unused collect cycle in resource monitor

2015-05-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33875/#review82709 --- Ship it! lgtm modulo jie's comments. src/slave/monitor.hpp

Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82707 --- Patch looks great! Reviews applied: [33871, 33872] All tests