Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review83163 --- Patch looks great! Reviews applied: [34017, 34018] All tests

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-09 Thread Michael Park
On April 23, 2015, 1:48 p.m., Michael Park wrote: As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch. Jie Yu wrote: I suspect this is due to the default allocation interval (1 secs by default). Jie Yu

Re: Review Request 31667: Piped hashmapSlaveID, Resources from allocator through to sorter.

2015-05-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/ --- (Updated May 10, 2015, 12:21 a.m.) Review request for mesos, Alexander

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:24 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:36 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:37 p.m.) Review request for mesos and Ben Mahler.

Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:04 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:04 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:13 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
On May 4, 2015, 6:46 p.m., Alexander Rojas wrote: I am not really sure this is the way to go in order to create a case insensite hashmap. The class `hashmap` simply adds functionality to the `boost::unordered_map`. If one checks the API for the latter, the way needed to create an

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:23 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83156 --- Patch looks great! Reviews applied: [34016] All tests passed. -

Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- Review request for mesos. Repository: mesos Description --- According

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:45 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/ --- (Updated May 9, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:52 p.m.) Review request for mesos, Benjamin Hindman