Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84473 --- 3rdparty/libprocess/include/process/process.hpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated May 20, 2015, 8:39 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: Besides the below mentioned points looks good to me! We should just remember adding this to the libprocess user guide. - Joerg --- This is an automatically generated e-mail. To reply,

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: docs/powered-by-mesos.md, line 28 https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28 Is that dropped by a rebase or by you? Same below Thanks for fixing this so quickly :-). - Joerg

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/ --- (Updated May 20, 2015, 8:41 a.m.) Review request for mesos, Isabel Jimenez,

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Alexander Rojas
On May 5, 2015, 10:42 p.m., Vinod Kone wrote: include/mesos/executor/executor.proto, line 117 https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line117 No corresponding Type for this? Also, how and when is this used? Alexander Rojas wrote: I had

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
On May 20, 2015, 7:18 a.m., Joerg Schad wrote: 3rdparty/libprocess/src/process.cpp, line 373 https://reviews.apache.org/r/33295/diff/4/?file=947285#file947285line373 are universal/rvalue refs allowed by our style guide? If so should we add it to the styleguide? actually it is

Re: Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34378/#review84494 --- Ship it! Ship It! - Alexander Rojas On May 19, 2015, 1:23 a.m.,

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review84497 --- Ship it! I admit I don't like namespace aliases which have the

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84498 --- src/examples/test_hook_module.cpp

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84479 --- Ship it! Just as mentioned we should remember to add this to the

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated May 20, 2015, 9:46 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-20 Thread Nikita Vetoshkin
On May 20, 2015, 5:10 a.m., Nikita Vetoshkin wrote: 3rdparty/libprocess/include/process/http.hpp, line 352 https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352 strftime formatting is locale dependent. This example ``` #include locale.h #include

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-20 Thread Alexander Rojas
On May 20, 2015, 7:10 a.m., Nikita Vetoshkin wrote: 3rdparty/libprocess/include/process/http.hpp, line 352 https://reviews.apache.org/r/30032/diff/7/?file=963338#file963338line352 strftime formatting is locale dependent. This example ``` #include locale.h #include

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34260/#review84507 --- Ship it! Ship It! - Alexander Rojas On May 18, 2015, 12:42

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review84501 --- Ship it! Ship It! - Alexander Rojas On May 18, 2015, 7:41 p.m.,

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-20 Thread Alexander Rojas
On May 19, 2015, 10:13 p.m., Vinod Kone wrote: src/cli/mesos.cpp, line 31 https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31 So basename can never return an error? When did ::basename() return NULL? I checked in the `::basename` docs (`man 3 basename`) and

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84508 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 8:11

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84502 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-20 Thread Alexander Rojas
On May 12, 2015, 11:28 p.m., Michael Park wrote: Looks good overall! I think found one more: `src/process.cpp` ```cpp 2717: const string name = tokens.size() 1 ? tokens[1] : ; ``` I didn't even know you could capture by reference in this case! - Alexander

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Alexander Rojas
On May 7, 2015, 8:55 p.m., Joerg Schad wrote: Maybe we could use benchmark to ensure the overall change does not cause a noticable performance penalty (don't think so, but numbers are always good to verify) While nice to have benchmarks, I don't think this changes are optional

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84511 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 8:11

Review Request 34431: Add htb queueing discipline

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 34428: Extend queueing discipline wrappers to expose network isolator statistics

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34428/ --- (Updated May 20, 2015, 3:58 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34431: Add htb queueing discipline

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review84523 --- Bad patch! Reviews applied: [34321, 34321] Failed command:

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 6:22 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/ --- (Updated May 20, 2015, 6:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 7:10 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34483: Moved the repository url constant to reviewboardrc.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34483/#review84568 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 6:04 p.m., Jie

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Marco Massenzio
On May 20, 2015, 8:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 383-387 https://reviews.apache.org/r/34193/diff/2-3/?file=963013#file963013line383 What about: ``` programName_ = argc 0 ?

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/#review84589 --- support/post-reviews.py

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
On May 12, 2015, 9:05 p.m., Michael Park wrote: I found 2 instances which look like they were missed: `check.hpp` ```cpp 34: for (const Optionstd::string _error = _check(expression); \ ``` `flags/stringifier.hpp` ```cpp 68:const OptionT v = f-*flag; ```

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/#review84567 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Greg Mann
On May 20, 2015, 5:49 p.m., Timothy Chen wrote: src/examples/balloon_framework.cpp, line 207 https://reviews.apache.org/r/34317/diff/1/?file=962096#file962096line207 Why not Optionstring value = os::getenv(MESOS_BUILD_DIR)? I think that in the case of a re-used variable, a separate

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review84597 --- docs/mesos-c++-style-guide.md

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Marco Massenzio
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 633 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line633 Did you substitute the `std::endl` with `\n\n` on purpose? Why not stay

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Greg Mann
On May 20, 2015, 5:50 p.m., Timothy Chen wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 https://reviews.apache.org/r/34319/diff/3/?file=962168#file962168line157 Btw after looking at your other patches, I realize we don't really need hasenv anymore right?

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Michael Park
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511 https://reviews.apache.org/r/34193/diff/2/?file=963014#file963014line511 Since we're in an implementation file, we can `using std::ostringstream;` and then

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/ --- (Updated May 20, 2015, 9:28 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Marco Massenzio
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511 https://reviews.apache.org/r/34193/diff/2/?file=963014#file963014line511 Since we're in an implementation file, we can `using std::ostringstream;` and then

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Marco Massenzio
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 45 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line45 It is best practice to make base class constructors protected to prevent

Re: Review Request 34431: Add htb queueing discipline

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 20, 2015, 9:01 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34485: Renamed parent_branch to tracking_branch in post-reviews.py.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34485/#review84588 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 6:17 p.m., Jie

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 7:04 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
On May 19, 2015, 8:05 p.m., Ben Mahler wrote: Thanks for the test! I left some comments that are relevant to https://reviews.apache.org/r/33793/ as well, so be sure to update that review too. @arojas @bmahler Thank you very much for your reviews. I update the patch, could you help me

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 633 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line633 Did you substitute the `std::endl` with `\n\n` on purpose? Why not stay

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review84529 --- include/mesos/executor/executor.proto

Review Request 34483: Moved the repository url constant to reviewboardrc.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34483/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 34483: Moved the repository url constant to reviewboardrc.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34483/#review84557 --- Patch looks great! Reviews applied: [34483] All tests passed. -

Review Request 34482: Fixed a bug in post-reviews.py.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34482/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review84556 --- src/cli/mesos.cpp

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 6:51 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/#review84566 --- Patch looks great! Reviews applied: [34483, 34485, 34488] All

Re: Review Request 34426: Extend the Traffic Control queueing models to allow dynamically allocated Handles, extend API to allow searching by handle (or parent).

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated May 20, 2015, 5:55 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 7:08 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84548 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 34482: Fixed a bug in post-reviews.py.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34482/#review84552 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 5:48 p.m., Jie

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review84553 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review84551 --- src/examples/balloon_framework.cpp

Review Request 34485: Renamed parent_branch to tracking_branch in post-reviews.py.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34485/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 20, 2015, 7:09 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 34428: Extend queueing discipline wrappers to expose network isolator statistics

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34428/ --- (Updated May 20, 2015, 6:19 p.m.) Review request for mesos, Chi Zhang, Ian

Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 6:40 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-20 Thread Greg Mann
On May 20, 2015, 6:04 p.m., Timothy Chen wrote: src/cli/mesos.cpp, line 22 https://reviews.apache.org/r/34317/diff/1/?file=962095#file962095line22 optionally you can avoid the extra check by calling os::getenv(PATH).get() I would guess that we can rely on PATH being set, but

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
On May 20, 2015, 9:27 p.m., Vinod Kone wrote: support/post-reviews.py, line 200 https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200 if someone specifies --tracking-branch on the command line, does that mean it'll be passed to 'rbt' twice? This is the

Re: Review Request 33272: Fix capture by reference of temporary strings in Stout.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33272/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33274/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/ --- (Updated May 20, 2015, 10:36 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
On May 20, 2015, 9:27 p.m., Vinod Kone wrote: support/post-reviews.py, line 200 https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200 if someone specifies --tracking-branch on the command line, does that mean it'll be passed to 'rbt' twice? Jie Yu wrote:

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/ --- (Updated May 20, 2015, 11:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/ --- (Updated May 21, 2015, 12:18 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/#review84634 --- Patch looks great! Reviews applied: [34483, 34485, 34488] All

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-20 Thread Colin Williams
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote: This is a very good point, my original change had the values set as local variables, but when I read through the task again it seemed like it was asking for predefined constants. I'll make the changes and put them up during my morning

Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- (Updated May 21, 2015, 12:36 a.m.) Review request for mesos, Jie Yu and Niklas

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84609 --- Bad patch! Reviews applied: [34321, 34426, 34321] Failed command:

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/ --- (Updated May 20, 2015, 11:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84626 --- Ship it! Ship It! - Jie Yu On May 20, 2015, 11:13 p.m., Vinod

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34488/#review84630 --- Ship it! support/post-reviews.py

Re: Review Request 34304: Updated documentation of FrameworkInfo.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34304/ --- (Updated May 21, 2015, 12:34 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- (Updated May 21, 2015, 12:42 a.m.) Review request for mesos, Jie Yu and Niklas

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84642 --- Patch looks great! Reviews applied: [33271, 33274, 33276] All

Re: Review Request 34134: Add container rootfs to Isolator::prepare().

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34134/#review84641 --- LGTM - Paul Brett On May 13, 2015, 12:44 a.m., Ian Downes wrote:

Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. Repository:

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84608 --- support/post-reviews.py

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
On May 20, 2015, 11 p.m., Ian Downes wrote: support/post-reviews.py, line 31 https://reviews.apache.org/r/34503/diff/1/?file=965856#file965856line31 Not yours, but perhaps from subprocess import Popen? and call, PIPE and STDOUT. On May 20, 2015, 11 p.m., Ian Downes wrote:

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- (Updated May 20, 2015, 11:13 p.m.) Review request for mesos, Cody Maloney, Ian

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review84622 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m.,

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84620 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m.,

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33274/#review84621 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m.,

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated May 20, 2015, 11:44 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/#review84603 --- Patch looks great! Reviews applied: [33792, 34068] All tests

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84623 --- Patch looks great! Reviews applied: [33271, 33272, 33275] All

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 45 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line45 It is best practice to make base class constructors protected to prevent

Re: Review Request 34138: AppC hash computation.

2015-05-20 Thread Paul Brett
On May 13, 2015, 4:30 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/appc/hash.hpp, line 50 https://reviews.apache.org/r/34138/diff/1/?file=957269#file957269line50 Not sure if this is generally available, but just checked on my OSX laptop and it's not there.

Review Request 34529: Add non-const reference version of OptionT::get.

2015-05-20 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/ --- Review request for mesos. Bugs: MESOS-2716