Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 9, 2015, 9:22 a.m.) Review request for Benjamin Hindman and

Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/ --- Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone.

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/ --- (Updated June 9, 2015, 2:32 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87157 --- Patch looks great! Reviews applied: [35247] All tests passed. -

Re: Review Request 35207: Included doxygen documentation in docs/home.md.

2015-06-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35207/#review87154 --- Ship it! docs/home.md

Re: Review Request 35206: Added mainpage to doxygen documentation.

2015-06-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35206/#review87153 --- Ship it! Ship It! - Benjamin Hindman On June 8, 2015, 8:51

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review87149 --- Ship it! Ship It! - Benjamin Hindman On June 1, 2015, 5:26

Re: Review Request 34644: Update existing lambdas to meet style guide

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34644/#review87146 --- Ship it! Thanks for doing this! We'll clean up the nit when we

Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/#review87194 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 9, 2015, 3:09 p.m.) Review request for Benjamin Hindman and

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 9, 2015, 2:17 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/#review87224 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/ --- (Updated June 9, 2015, 3:56 p.m.) Review request for mesos, Adam B and Cody

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-09 Thread James Peach
On June 9, 2015, 12:26 a.m., Till Toenshoff wrote: 3rdparty/libprocess/configure.ac, line 31 https://reviews.apache.org/r/35234/diff/1/?file=980998#file980998line31 Can we switch to `#` prefixed comments here instead? Originally I used #-comments, but since autoconf completely

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Anand Mazumdar
On June 9, 2015, 6:34 a.m., Cody Maloney wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 58 https://reviews.apache.org/r/35179/diff/2/?file=980529#file980529line58 I'm still against using enable_if here, it's a lot of extra complexity (And will be slightly

Review Request 35257: Decode network statistics from helper

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35257/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35225/#review87225 --- src/linux/routing/queueing/htb.hpp

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

2015-06-09 Thread Bartek Plotka
On June 9, 2015, 5:26 p.m., Niklas Nielsen wrote: Hey Bartek, Let's await further work on this ticket before we have resolved the overall approach for this small patch set (taken that the resource statistics object is planned to change). You mean, these 3 fields wich change their

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
On June 9, 2015, 5:03 p.m., Cong Wang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, line 124 https://reviews.apache.org/r/35229/diff/1/?file=980896#file980896line124 TRAFFIC_CONTROL_STATISTICS is too generic, I don't see what it means from the name. The name

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-09 Thread Niklas Nielsen
On June 4, 2015, 10:52 a.m., Adam B wrote: docs/getting-started.md, lines 24-26 https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line24 It was suggested that we should keep this document shortsweet and only reference the latest Ubuntu LTS release, and then we can

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-09 Thread Jiang Yan Xu
On June 9, 2015, 10:41 a.m., Niklas Nielsen wrote: src/master/master.cpp, lines 5442-5444 https://reviews.apache.org/r/35119/diff/2/?file=980495#file980495line5442 No need for the else block here. True. I am dropping this because it's already committed. Will add you as a review

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/ --- (Updated June 9, 2015, 5:29 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/#review87238 --- LGTM - just added myself to the review to follow along

Re: Review Request 13675: Added a slave load hint for scheduler sorting.

2015-06-09 Thread Niklas Nielsen
On March 10, 2014, 3:07 p.m., Niklas Nielsen wrote: https://reviews.apache.org/r/17325 expose system load for both masters and slaves. So you should be able to get statistics with the offer.hostname at hand. Do you still want to hang statistics off the offer? Closing for now. -

Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35259/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs:

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Paul Brett
On June 9, 2015, 5:09 p.m., Cong Wang wrote: src/linux/routing/queueing/htb.hpp, line 45 https://reviews.apache.org/r/35225/diff/2/?file=980905#file980905line45 s/if a queueing discipline already exists/if an htb queueing discipline already exists/ ?? Could also be a qdisc of

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35225/ --- (Updated June 9, 2015, 5:22 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 11914: Get EC2 scripts into workable state

2015-06-09 Thread Niklas Nielsen
On June 4, 2015, 11:01 a.m., Niklas Nielsen wrote: Stale review: Charles, still want this in? Closing for now. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11914/#review86673

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-09 Thread Niklas Nielsen
On June 8, 2015, 5:34 p.m., Jie Yu wrote: I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 Niklas Nielsen wrote: The new proposal doesn't mention changing the callback, does it? Jie Yu

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-09 Thread Jie Yu
On June 9, 2015, 12:34 a.m., Jie Yu wrote: I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 Niklas Nielsen wrote: The new proposal doesn't mention changing the callback, does it? Jie Yu

Re: Review Request 34719: Added QOS_KILLED as status reason

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34719/#review87246 --- Keeping this patch set open, as the terminal reason work is coming

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/ --- (Updated June 9, 2015, 6:09 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35239/#review87252 --- src/master/http.cpp

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-09 Thread Colin Williams
On June 9, 2015, 6:19 p.m., Niklas Nielsen wrote: Hey Colin! Thanks for contributing this and I am sorry about the tardy turn-around time. The crux of the ticket was to consolidate the strings, so we only have to maintain them one place. With that in mind; instead of

Re: Review Request 29437: Bug fix: Start the executor registration timer, only when the container has launched successfully

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29437/#review87245 --- @tnachen: What is blocked this? Looks like it got a ship it, but

Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs:

Review Request 35262: Logged framework capabilities during (re-)registration.

2015-06-09 Thread Ben Mahler
/35262/diff/ Testing --- Ran the oversubscription tests to verify the output: ``` I0609 19:01:02.855468 13605 master.cpp:1783] Registering framework 20150609-190102-1828659978-38362-13474- (default) at scheduler-73035a36-e16a-4bdb-ae4c-992c6b3694fa@10.35.255.108:38362

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-09 Thread Bartek Plotka
On June 9, 2015, 12:34 a.m., Jie Yu wrote: I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 Niklas Nielsen wrote: The new proposal doesn't mention changing the callback, does it? Jie Yu

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review87234 --- Ship it! src/master/master.cpp

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35239/#review87253 --- Any reason not to just add a 'revocable_resources' instead of

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-06-09 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review87264 --- Ship it! Ship It! - Isabel Jimenez On June 1, 2015, 9:02 a.m.,

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Jiang Yan Xu
On June 9, 2015, 11:36 a.m., Ben Mahler wrote: Any reason not to just add a 'revocable_resources' instead of 'total_resources'? Looking to avoid the magic REV string proliferating, when we're not yet printing role here either. Ideally, when we add 'total_resources', we can do it in

Re: Review Request 35262: Logged framework capabilities during (re-)registration.

2015-06-09 Thread Jie Yu
e91e8815471b49d3c649470197d6da3f06de62fb Diff: https://reviews.apache.org/r/35262/diff/ Testing --- Ran the oversubscription tests to verify the output: ``` I0609 19:01:02.855468 13605 master.cpp:1783] Registering framework 20150609-190102-1828659978-38362-13474- (default

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87272 --- Patch looks great! Reviews applied: [35259, 35260] All tests

Re: Review Request 30774: Fetcher Cache

2015-06-09 Thread Bernd Mathiske
On June 5, 2015, 7:10 p.m., Ben Mahler wrote: Just took a cursory glance since this is a huge diff, could it have been broken apart further? We've found large diffs like this one are next to impossible to review thoroughly :) Agreed that this is normally the case. And this had been

Re: Review Request 35262: Logged framework capabilities during (re-)registration.

2015-06-09 Thread Mesos ReviewBot
20150609-190102-1828659978-38362-13474- (default) at scheduler-73035a36-e16a-4bdb-ae4c-992c6b3694fa@10.35.255.108:38362 with checkpointing disabled and capabilities [ REVOCABLE_RESOURCES ] ``` Thanks, Ben Mahler

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35225/#review87290 --- Ship it! Ship It! - Jie Yu On June 9, 2015, 5:22 p.m., Paul

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
On June 9, 2015, 11:11 a.m., Vinod Kone wrote: src/tests/fetcher_cache_tests.cpp, lines 360-361 https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line360 Why not just do AWAIT_READY(offers)? That does not compile here, because it contains a return of type void and

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/ --- (Updated June 9, 2015, 8:54 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-09 Thread Colin Williams
On June 9, 2015, 6:19 p.m., Niklas Nielsen wrote: Hey Colin! Thanks for contributing this and I am sorry about the tardy turn-around time. The crux of the ticket was to consolidate the strings, so we only have to maintain them one place. With that in mind; instead of

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Jiang Yan Xu
On June 9, 2015, 11:36 a.m., Ben Mahler wrote: Any reason not to just add a 'revocable_resources' instead of 'total_resources'? Looking to avoid the magic REV string proliferating, when we're not yet printing role here either. Ideally, when we add 'total_resources', we can do it in

Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35259/ --- (Updated June 9, 2015, 7:50 p.m.) Review request for mesos, Ben Mahler, Niklas

Review Request 35271: Removed unnecessary accessors in qdisc code.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35271/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 35272: Removed unnecessary accessors in route code.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35272/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 35273: Removed unnecessary accessors in filter code.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35273/ --- (Updated June 9, 2015, 10:59 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 35264: Added a slave integration test in MonitorTest.

2015-06-09 Thread Jie Yu
On June 9, 2015, 10:12 p.m., Niklas Nielsen wrote: src/tests/monitor_tests.cpp, line 221 https://reviews.apache.org/r/35264/diff/1/?file=981687#file981687line221 77 lines of straight line code; Can we easen up a bit and add structure with some comments explaining what's going on

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-09 Thread Jie Yu
On June 9, 2015, 11:49 p.m., Ben Mahler wrote: Would be nice to split apart this diff to make it easier to review thoroughly. For example, the following seem to fit into separate patches: (1) Adding Slave::usage for resource estimators. (2) Updating the monitor to use Slave::usage.

Review Request 35273: Removed unnecessary accessors in filter code.

2015-06-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35273/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative

2015-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87318 --- Ship it! Ship It! - Vinod Kone On June 9, 2015, 11:31 p.m.,

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Cody Maloney
On June 9, 2015, 6:34 a.m., Cody Maloney wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 58 https://reviews.apache.org/r/35179/diff/2/?file=980529#file980529line58 I'm still against using enable_if here, it's a lot of extra complexity (And will be slightly

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-09 Thread Jie Yu
On June 9, 2015, 10:04 p.m., Niklas Nielsen wrote: src/slave/monitor.hpp, line 53 https://reviews.apache.org/r/35260/diff/1/?file=981665#file981665line53 Want to add a deprecation todo? Chatted with BenM about this. He thinks that we may still want to keep resource monitor in the

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/ --- (Updated June 10, 2015, 12:08 a.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 35257: Decode network statistics from helper

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35257/ --- (Updated June 9, 2015, 9:55 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/ --- (Updated June 9, 2015, 9:56 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87300 --- One general comment: Should it be ResourceUsage::Executor or should

Review Request 35280: Added Test QoS Controller module

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35280/ --- Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu. Bugs:

Review Request 35279: Added QoS Controller module

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35279/ --- Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu. Bugs:

Review Request 35281: Added QoS module loader to ::create() factory.

2015-06-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35281/ --- Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu. Bugs:

Re: Review Request 35264: Added a slave integration test in MonitorTest.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87332 --- Patch looks great! Reviews applied: [35259, 35260, 35264] All

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-09 Thread Ben Mahler
On June 9, 2015, 5:36 p.m., Niklas Nielsen wrote: src/master/master.cpp, lines 3513-3514 https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3513 Does it make sense to point to some documentation (if it exists already, or inline) about how this resource math will

Re: Review Request 34921: Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.

2015-06-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34921/#review87336 --- Ship it! Ship It! - Ben Mahler On June 9, 2015, 2:58 a.m.,

Re: Review Request 35273: Removed unnecessary accessors in filter code.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35273/#review87342 --- Patch looks great! Reviews applied: [35271, 35272, 35273] All

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 9, 2015, 1:52 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
On June 9, 2015, 11:11 a.m., Vinod Kone wrote: src/tests/fetcher_cache_tests.cpp, lines 201-207 https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line201 While this looks good as a temporary fix, what is the long term strategy here? I really don't like

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 9, 2015, 1:29 p.m.) Review request for Benjamin Hindman and

Re: Review Request 35281: Added QoS module loader to ::create() factory.

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35281/#review87346 --- Patch looks great! Reviews applied: [35278, 35279, 35280, 35281]

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review87343 --- Patch looks great! Reviews applied: [30952] All tests passed. -