Re: Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34392/ --- (Updated June 15, 2015, 1:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35354/ --- (Updated June 15, 2015, 11:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/ --- (Updated June 15, 2015, 1:51 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35353/ --- (Updated June 15, 2015, 11:24 a.m.) Review request for mesos, Ben Mahler and

Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Repository:

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/#review87916 --- Patch looks great! Reviews applied: [35455] All tests passed. -

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/#review87915 --- Ship it! docs/getting-started.md

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- (Updated June 15, 2015, 12:11 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- (Updated June 15, 2015, 12:58 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34392/#review87919 --- Patch looks great! Reviews applied: [34392] All tests passed. -

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- (Updated June 15, 2015, 12:42 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 15, 2015, 12:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review87918 --- src/slave/slave.cpp

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review87920 --- Patch looks great! Reviews applied: [35433] All tests passed. -

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- (Updated June 15, 2015, 12:36 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/ --- (Updated June 15, 2015, 12:54 p.m.) Review request for mesos, Benjamin Hindman

Review Request 35463: Fix typos in stout README.

2015-06-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35463/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/ --- (Updated June 15, 2015, 3:25 p.m.) Review request for mesos, Adam B and Cody

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/#review87928 --- Patch looks great! Reviews applied: [35438] All tests passed. -

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/ --- (Updated June 15, 2015, 7:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35463: Fix typos in stout README.

2015-06-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35463/#review87925 --- Ship it! Ship It! - Till Toenshoff On June 15, 2015, 3:40 p.m.,

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- (Updated June 15, 2015, 5:26 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 35455: Update 'Getting Started' documentation.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35455/#review87922 --- Patch looks great! Reviews applied: [35455] All tests passed. -

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 15, 2015, 5:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35353/ --- (Updated June 15, 2015, 5:51 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

2015-06-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34908/#review88016 --- Ship it! docs/configuration.md

Re: Review Request 34427: AppC provisioner backend using bind mounts.

2015-06-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34427/#review88020 --- src/slave/containerizer/provisioners/appc/bind_backend.hpp

Re: Review Request 34943: Added validation to flags.

2015-06-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review88003 --- Long missed feature indeed :) ... thanks for reviving this. You

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87936 --- 3rdparty/libprocess/include/process/address.hpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review87939 --- Patch looks great! Reviews applied: [34703, 30032] All tests

Re: Review Request 35410: Minor cleanups to the slave.

2015-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35410/#review87943 --- Ship it! Ship It! - Jie Yu On June 13, 2015, 2:04 a.m., Ben

Re: Review Request 35470: Fixed the flaky oversbuscription tests.

2015-06-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35470/#review87961 --- Ship it! Ship It! - Ben Mahler On June 15, 2015, 7:02 p.m., Jie

Review Request 35470: Fixed the flaky oversbuscription tests.

2015-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35470/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2869

Re: Review Request 35411: Send oversubscribable resources during (re-)registration.

2015-06-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35411/#review87959 --- Ship it! src/slave/slave.cpp

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-15 Thread Niklas Nielsen
On June 9, 2015, 6:25 p.m., Ben Mahler wrote: src/tests/master_tests.cpp, lines 3031-3034 https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031 Why bother with all this? Why not just have `key1`, `value1`, `key2`, `value2` inlined appropriately throughout

Re: Review Request 35410: Minor cleanups to the slave.

2015-06-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35410/#review87956 --- Ship it! Ship It! - Vinod Kone On June 13, 2015, 2:04 a.m., Ben

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33208/#review87958 --- Hey Robert; BenH helped out and wrote a PoC patch here

Re: Review Request 35411: Send oversubscribable resources during (re-)registration.

2015-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35411/#review87944 --- Ship it! Ship It! - Jie Yu On June 13, 2015, 2:04 a.m., Ben

Re: Review Request 35467: Fix a comment in Slave.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35467/#review87945 --- Patch looks great! Reviews applied: [35467] All tests passed. -

Re: Review Request 34375: Removed use of namespace aliases.

2015-06-15 Thread Ben Mahler
On May 19, 2015, 2:02 a.m., Ben Mahler wrote: This might be a valid namespace alias use case that we hadn't considered, because there is no way to be able to write just `http::Response` otherwise, is there? Seems quite verbose to write process::http everywhere, and on the otherhand

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review87954 --- Patch looks great! Reviews applied: [34835] All tests passed. -

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-15 Thread Colin Williams
On June 10, 2015, 1:25 a.m., Ben Mahler wrote: src/tests/master_tests.cpp, lines 3031-3034 https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031 Why bother with all this? Why not just have `key1`, `value1`, `key2`, `value2` inlined appropriately throughout

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87933 --- Patch looks great! Reviews applied: [35179] All tests passed. -

Re: Review Request 35411: Send oversubscribable resources during (re-)registration.

2015-06-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35411/#review87968 --- Just wanted to tag on this review and follow the update changes -

Re: Review Request 35470: Fixed the flaky oversbuscription tests.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35470/#review87965 --- Patch looks great! Reviews applied: [35470] All tests passed. -

Re: Review Request 35441: Removed unused macros.

2015-06-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35441/#review87966 --- Ship it! Ship It! - Niklas Nielsen On June 14, 2015, 10:26

Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

2015-06-15 Thread Jie Yu
On June 14, 2015, 10:46 a.m., Benjamin Hindman wrote: Just so I understand, does this mean if we happen to get in the unfortunate situation where a slave has neglected to get the dynamic reservation because it was just starting up and then it gets the task launch it will shutdown the

Re: Review Request 35473: Removed a few incorrect CHECKs in DRF sorter.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35473/#review87982 --- Patch looks great! Reviews applied: [35473] All tests passed. -

Re: Review Request 35473: Removed a few incorrect CHECKs in DRF sorter.

2015-06-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35473/#review87980 --- Ship it! I personally find it easier to read if we don't have the

Review Request 35473: Removed a few incorrect CHECKs in DRF sorter.

2015-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35473/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs:

Re: Review Request 35411: Send oversubscribable resources during (re-)registration.

2015-06-15 Thread Ben Mahler
On June 15, 2015, 8:21 p.m., Niklas Nielsen wrote: src/tests/oversubscription_tests.cpp, line 498 https://reviews.apache.org/r/35411/diff/1/?file=983985#file983985line498 Which kind of update message? :) s/update/'SlaveUpdate'/ ? Changed it to forwards the estimation to match

Re: Review Request 35441: Removed unused macros.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35441/#review87972 --- Ship it! Ship It! - Michael Park On June 14, 2015, 5:26 p.m.,

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 15, 2015, 5:22 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
On June 3, 2015, 1:17 p.m., Niklas Nielsen wrote: src/hook/manager.cpp, line 95 https://reviews.apache.org/r/30339/diff/3/?file=975940#file975940line95 Don't you need to acquire the mutex here? Good catch. Fixed. - Kapil

Re: Review Request 35473: Removed a few incorrect CHECKs in DRF sorter.

2015-06-15 Thread Ben Mahler
On June 15, 2015, 9:40 p.m., Ben Mahler wrote: src/master/allocator/sorter/drf/sorter.cpp, lines 176-188 https://reviews.apache.org/r/35473/diff/1/?file=984846#file984846line176 How about the same logic in both? ``` { if (_resources.empty()) { //

Re: Review Request 35473: Removed a few incorrect CHECKs in DRF sorter.

2015-06-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35473/ --- (Updated June 15, 2015, 10:03 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 35441: Removed unused macros.

2015-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35441/#review87995 --- Ship it! Ship It! - Alexander Rojas On June 14, 2015, 7:26

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87999 --- Patch looks great! Reviews applied: [35179] All tests passed. -

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/#review87895 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87989 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-15 Thread Michael Park
On June 15, 2015, 5:28 p.m., Jojy Varghese wrote: 3rdparty/libprocess/include/process/address.hpp, line 84 https://reviews.apache.org/r/29406/diff/29/?file=984330#file984330line84 There are a few if family == INET (or similar) in the code. By specializing the net address

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 15, 2015, 6:26 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 35404: Fixed http::Request::client to be set correctly.

2015-06-15 Thread Ben Mahler
On June 12, 2015, 11:20 p.m., Jie Yu wrote: Have you tested this? Yep, the test was updated to properly test this, and I verified manually. :) On June 12, 2015, 11:20 p.m., Jie Yu wrote: 3rdparty/libprocess/src/process.cpp, line 593

Re: Review Request 35403: Added the ability to get the peer address of a connected or accepted Socket.

2015-06-15 Thread Ben Mahler
On June 12, 2015, 11:06 p.m., Niklas Nielsen wrote: Maybe add @joris to this review? This change is pretty trivial, it's symmetric to the existing Socket::address, but I'd be happy to follow up if he has any feedback! :) - Ben ---

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Michael Park
On June 15, 2015, 10:57 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, lines 49-51 https://reviews.apache.org/r/35179/diff/6/?file=984730#file984730line49 Not yours, but could you fix the formatting here to not wrap after `return` please?

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review87991 --- Patch looks great! Reviews applied: [30339] All tests passed. -

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/#review88000 --- Ship it! Ship It! - Michael Park On June 14, 2015, 4:17 p.m.,

Re: Review Request 34943: Added validation to flags.

2015-06-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review87996 --- Very neat! LGTM - however, my gut feeling is that we should only

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-15 Thread Michael Park
On June 15, 2015, 11:47 p.m., Michael Park wrote: Ship It! Looks like you might have to rebase this one more time? - Michael --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-15 Thread Michael Park
On June 15, 2015, 11:47 p.m., Michael Park wrote: Ship It! Michael Park wrote: Looks like you might have to rebase this one more time? Never mind, it applies just fine. - Michael --- This is an automatically generated

Review Request 35482: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-15 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35482/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 35482: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35482/#review88008 --- Bad patch! Reviews applied: [35482] Failed command: