Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- Review request for mesos, Adam B and Jie Yu. Repository: mesos Description --- Disallow special characters in role name. Diffs - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35717: Add reservations support to master's state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 6:02 p.m.) Review request for mesos and Adam B. Bugs: MESOS-692 https://issues.apache.org/jira/browse/MESOS-692 Repository: mesos Description --- Add reservations support to master's state.json Diffs (updated) - src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 21, 2015, 2:15 p.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88697 --- Patch looks great! Reviews applied: [9] All tests passed. - Mesos ReviewBot On June 21, 2015, 9:57 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:57 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang
Review Request 35715: Added revocable resource state validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos Description --- In `mesos.proto`, it specifies the expected state of revocable resource: ``` // ... Note that if this is set, 'disk' or 'reservation' cannot be set. optional RevocableInfo revocable = 9; ``` This expectation should be validated in `Resources::validate(const Resource resoure)` Diffs - src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332 Diff: https://reviews.apache.org/r/35715/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35717: Add reservations support to master's state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review88703 --- Thanks for doing this! Looks good to me overall. src/common/http.cpp (line 88) https://reviews.apache.org/r/35717/#comment141259 `s/key/role/` src/master/http.cpp (line 234) https://reviews.apache.org/r/35717/#comment141260 This is a bug from before, we should use `slave.totalResources` here instead. - Michael Park On June 21, 2015, 5:35 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 5:35 p.m.) Review request for mesos and Adam B. Bugs: MESOS-692 https://issues.apache.org/jira/browse/MESOS-692 Repository: mesos Description --- Add reservations support to master's state.json Diffs - src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 34881: let libprocess to compile on arm64 servers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34881/#review88722 --- 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch (line 18) https://reviews.apache.org/r/34881/#comment141289 Where did this header come from? If we were to just update protobuf to a newer version would it just compile? - Cody Maloney On June 1, 2015, 7:10 a.m., Dong Robin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34881/ --- (Updated June 1, 2015, 7:10 a.m.) Review request for mesos. Bugs: MESOS-2786 https://issues.apache.org/jira/browse/MESOS-2786 Repository: mesos Description --- To compile libprocess on arm64(aarch64) servers, we need to add patches for 3rd software to recognize aarch64 architecture and replace x86 assemble language to standard gcc buildin function Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION Diff: https://reviews.apache.org/r/34881/diff/ Testing --- Build and run mesos-mater/mesos-slave succesly on arm64 server. Thanks, Dong Robin
Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/#review88727 --- Ship it! Out of order, but otherwise good. Fix, then ShipIt! 3rdparty/libprocess/include/process/http.hpp (line 473) https://reviews.apache.org/r/35714/#comment141299 Let's keep these in numerical order, so put this after 404, before 500, please. - Adam B On June 21, 2015, 9:16 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/ --- (Updated June 21, 2015, 9:16 a.m.) Review request for mesos, Adam B and Jie Yu. Repository: mesos Description --- Needed in subsequent patch for /reserve master endpoint. Diffs - 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417 Diff: https://reviews.apache.org/r/35714/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review88717 --- Patch looks great! Reviews applied: [35721] All tests passed. - Mesos ReviewBot On June 22, 2015, 1:56 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 22, 2015, 1:56 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the owner of persistent volumes to frameworkInfo.user . Diffs - src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d src/messages/messages.proto 1c8d79e3fca365520cdd67051f8730593955cab6 src/slave/slave.hpp f1cf3b85ccb3eaf614fe844c830f7cc44f7916fe src/slave/slave.cpp 40c0c33add392591af4767f76ce566196f24e6ee Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 2:35 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris Van Remoortere, and Vinod Kone. Changes --- Added tests for the error cases. Bugs: MESOS-2600 https://issues.apache.org/jira/browse/MESOS-2600 Repository: mesos Description --- This is still a work in progress, but I'm sharing to gather some feedback around: (1) I've added `updateAvailable` to the allocator API. Is this necessary or is there maybe a better way? (2) To determine the amount of available resources, I used: `available = total - (offered + used)`. Is this still correct with oversubscription in the picture? (3) I'm creating an `Offer.Operation` to perform the necessary updates in the allocator and such. Feels weird to use an offer operation when there's not an actual offer. Is this fine for now? Diffs (updated) - include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/master/allocator/mesos/allocator.hpp 6cfa04650d91a80211cfbc0809236f9438926c78 src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp` which still need to be fleshed out for error cases (missing parameters, unauthorized client, etc). Thanks, Michael Park
Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/ --- (Updated June 22, 2015, 5:06 a.m.) Review request for mesos, Adam B and Jie Yu. Changes --- Addressed AdamB's comment. Repository: mesos Description --- Needed in subsequent patch for /reserve master endpoint. Diffs (updated) - 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417 src/Makefile.am dfebd2b14c9cb45c437509809fdf5ac3b0c8838c src/authentication/cram_md5/authenticatee.hpp 9d6293c32722272228652d0241c59c7eeb88d0a3 src/authentication/cram_md5/authenticatee.cpp 63ae17e5ed4702eb48feb2217e8f30556de78f42 src/slave/slave.cpp 40c0c33add392591af4767f76ce566196f24e6ee src/tests/cram_md5_authentication_tests.cpp 9d15b55f881aaecba32c8ce0afa6fa1ccd236e21 Diff: https://reviews.apache.org/r/35714/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:29 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2600 https://issues.apache.org/jira/browse/MESOS-2600 Repository: mesos Description --- This is still a work in progress, but I'm sharing to gather some feedback around: (1) I've added `updateAvailable` to the allocator API. Is this necessary or is there maybe a better way? (2) To determine the amount of available resources, I used: `available = total - (offered + used)`. Is this still correct with oversubscription in the picture? (3) I'm creating an `Offer.Operation` to perform the necessary updates in the allocator and such. Feels weird to use an offer operation when there's not an actual offer. Is this fine for now? Diffs (updated) - include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448 src/Makefile.am dfebd2b14c9cb45c437509809fdf5ac3b0c8838c src/master/allocator/mesos/allocator.hpp 6cfa04650d91a80211cfbc0809236f9438926c78 src/master/allocator/mesos/hierarchical.hpp 7097482fc0adad1c177c15c35edd51c10754f89c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park
Re: Review Request 34427: AppC provisioner backend using bind mounts.
On May 21, 2015, 12:29 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/appc/bind_backend.hpp, line 60 https://reviews.apache.org/r/34427/diff/1/?file=964174#file964174line60 I think we typcically add namespaces in cpp files to avoid process:: and std:: everywhere, just a nit. This is currently header-only. Will correct if moved to source. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34427/#review84771 --- On May 19, 2015, 11:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34427/ --- (Updated May 19, 2015, 11:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Note: This is a specialized backend; see notes in bind_backend.hpp. Reproduced here for your convenience: This is a specialized backend that may be useful for deployments using large (multi-GB) single-layer images *and* where more recent kernel features such as overlayfs are not available. For small images (10's to 100's of MB) the Copy backend may be sufficient. 1) It supports only a single layer. Multi-layer images will fail to provision and the container will fail to launch! 2) The filesystem is read-only because all containers using this image share the source. Select writable areas can be achieved by mounting read-write volumes to places like /tmp, /var/tmp, /home, etc. using the ContainerInfo. These can be relative to the executor work directory. 3) It relies on the image persisting in the store. 4) It's fast because the bind mount requires (nearly) zero IO. Diffs - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/appc/bind_backend.hpp PRE-CREATION Diff: https://reviews.apache.org/r/34427/diff/ Testing --- manual testing of a single layer image with RW relative bind mount for /tmp. Thanks, Ian Downes
Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:11 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris Van Remoortere, and Vinod Kone. Changes --- Rebased. Bugs: MESOS-2600 https://issues.apache.org/jira/browse/MESOS-2600 Repository: mesos Description --- This is still a work in progress, but I'm sharing to gather some feedback around: (1) I've added `updateAvailable` to the allocator API. Is this necessary or is there maybe a better way? (2) To determine the amount of available resources, I used: `available = total - (offered + used)`. Is this still correct with oversubscription in the picture? (3) I'm creating an `Offer.Operation` to perform the necessary updates in the allocator and such. Feels weird to use an offer operation when there's not an actual offer. Is this fine for now? Diffs (updated) - include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448 src/Makefile.am dfebd2b14c9cb45c437509809fdf5ac3b0c8838c src/master/allocator/mesos/allocator.hpp 6cfa04650d91a80211cfbc0809236f9438926c78 src/master/allocator/mesos/hierarchical.hpp 7097482fc0adad1c177c15c35edd51c10754f89c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park
Re: Review Request 35717: Add reservations support to master's state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 6:04 p.m.) Review request for mesos and Adam B. Bugs: MESOS-692 https://issues.apache.org/jira/browse/MESOS-692 Repository: mesos Description --- Add reservations support to master's state.json Diffs (updated) - src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35717: Add reservations support to master's state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review88707 --- Ship it! src/master/http.cpp (line 234) https://reviews.apache.org/r/35717/#comment141263 No need to make a copy here. If we just want a shorter name, let's alias it with a const-ref. `const Resources totalResources = slave.totalResources;` - Michael Park On June 21, 2015, 6:07 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 21, 2015, 6:07 p.m.) Review request for mesos, Adam B and Michael Park. Bugs: MESOS-692 https://issues.apache.org/jira/browse/MESOS-692 Repository: mesos Description --- Add reservations support to master's state.json Diffs - src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88691 --- Patch looks great! Reviews applied: [9] All tests passed. - Mesos ReviewBot On June 21, 2015, 5:37 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 5:37 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:42 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs (updated) - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: src/examples/java/TestPersistentVolumeFramework.java, lines 529-542 https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line529 Please consider using Apache Commons CLI instead: https://commons.apache.org/proper/commons-cli/ haosdent huang wrote: Yes, but it would add a new dependence to Maven. Is it acceptable? Other exist java examples also simple handle the args. Marco Massenzio wrote: I am not sure what the official policy is here - but this is a widely used library (and not a major dependency either) so I think we should be fine with it. Anyone got any opinion on this? Adam B wrote: Anything from Apache Commons Proper should be fine. We're all Apache here. @marco, @adam-mesos . I still don't like add log4j or commons-cli to this simple examples, because * Add external dependences to example may let user hard to run. Dependences may also conflict with user exist dependences. * If we want to add external jar dependences, we need add a pom.xml or a gradle file. Currently our java examples even don't have packages. Change a example to maven project maybe affect more code. If we decide to change examples to a maven project or gradle project, I need should open a new review to change them. So I just a Flags java implementation to handle command line options in this patch, I think it should be more readable now. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review86113 --- On June 21, 2015, 9:42 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:42 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang