Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 8:36 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
On June 24, 2015, 9:30 a.m., Adam B wrote: Looks great! We recently added validation lambdas to flag definitions, so you may be able to take advantage of that. We probably also want to do validation in the slave for the --resources flag, since resources can be declared as reserved for particular roles, and reserving a resource for an invalid role would be bad. I don't know if we even validate the reservation roles as known roles in the master upon slave registration. The only difference with --resources is that resources can use `*` to declare resources as unreserved. I check the Master::registerSlave, master don't check reservation roles. So I add this check to `src/slave/flags.cpp`. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89140 --- On June 27, 2015, 8:36 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 8:36 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:32 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing (updated) --- make -j8 check Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
On June 24, 2015, 6:34 p.m., Jie Yu wrote:
src/master/master.hpp, lines 630-651
https://reviews.apache.org/r/35711/diff/4/?file=989196#file989196line630
Can you move this function to src/master/validation.hpp|cpp
```
namespace role {
OptionError validate(const std::string role);
}
```
Because both master and slave need this check, I create
src/common/validation.hpp|cpp .
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review89222
---
On June 27, 2015, 11:35 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 27, 2015, 11:35 a.m.)
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210
Repository: mesos
Description
---
Disallow special characters in role name.
Diffs
-
src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5
src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521
src/common/validation.hpp PRE-CREATION
src/common/validation.cpp PRE-CREATION
src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8
src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
src/tests/common/validation_tests.cpp PRE-CREATION
src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e
Diff: https://reviews.apache.org/r/35711/diff/
Testing
---
make -j8 check
Thanks,
haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs (updated) - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.
On June 26, 2015, 2:30 a.m., Adam B wrote: Nice work! So, running the command as root first will guarantee that lt-mesos-executor exists before trying to run the task as the test-user `nobody`? We might be able to fix this in a cleaner way, but this looks good enough to me. Just fix the few minor points I raised and update the comments, and then I'll commit it. Please fill out the Testing Done section to explain how you verified that this test failed before your change and now passes. @adam-mesos, Thank you very much for your review. You metioned that `We might be able to fix this in a cleaner way`, could you tell me more details about it? I think use a more cleaner way to fix this problem could make us maintain this test case more easier. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/#review89458 --- On June 27, 2015, 4:37 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 4:37 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2199 https://issues.apache.org/jira/browse/MESOS-2199 Repository: mesos Description --- Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser. Diffs - src/tests/slave_tests.cpp e9002e807b500503c5bccf7ce638d98643f229ed Diff: https://reviews.apache.org/r/35728/diff/ Testing --- ### 1. Reproduce problem in old code ```bash # Enter mesos source directory and remove build directory cd mesos rm -rf build # Rebuild mesos mkdir -p build ./bootstrap cd build ../configure # Run the single test make -j8 check GTEST_FILTER=SlaveTest.ROOT_RunTaskWithCommandInfoWithUser ``` When running this test case, the mesos containier running under user `nobody`. And when the containier start `build/src/mesos-executor`, `build/src/mesos-executor` would check the `build/src/.libs/lt-mesos-executor` exists or not. Because we never running other test cases before, `build/src/.libs/lt-mesos-executor` is not exists here. And then `build/src/mesos-executor` would try to compile and generate `build/src/.libs/lt-mesos-executor`. Because `build/src/mesos-executor` is running under user `nobody`, it don't have permissions to output files to `build` directory. This test cases failed finally. ### 2. My way to fix this problem I start a prepare task with root first. And after this task finished with success, we could sure that `build/src/.libs/lt-mesos-executor` is exists. So when we start `build/src/mesos-executor` with user `nobody`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89627 --- src/Makefile.am (line 1489) https://reviews.apache.org/r/35711/#comment142281 I also replace spaces to tabs here. - haosdent huang On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89626 --- src/Makefile.am (line 362) https://reviews.apache.org/r/35711/#comment142280 Here are use spaces before, so I replace spaces to tabs. - haosdent huang On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 4:37 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2199 https://issues.apache.org/jira/browse/MESOS-2199 Repository: mesos Description --- Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser. Diffs - src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e Diff: https://reviews.apache.org/r/35728/diff/ Testing (updated) --- ### 1. Reproduce problem in old code ```bash # Enter mesos source directory and remove build directory cd mesos rm -rf build # Rebuild mesos mkdir -p build ./bootstrap cd build ../configure # Run the single test make -j8 check GTEST_FILTER=SlaveTest.ROOT_RunTaskWithCommandInfoWithUser ``` When running this test case, the mesos containier running under user `nobody`. And when the containier start `build/src/mesos-executor`, `build/src/mesos-executor` would check the `build/src/.libs/lt-mesos-executor` exists or not. Because we never running other test cases before, `build/src/.libs/lt-mesos-executor` is not exists here. And then `build/src/mesos-executor` would try to compile and generate `build/src/.libs/lt-mesos-executor`. Because `build/src/mesos-executor` is running under user `nobody`, it don't have permissions to output files to `build` directory. This test cases failed finally. ### 2. My way to fix this problem I start a prepare task with root first. And after this task finished with success, we could sure that `build/src/.libs/lt-mesos-executor` is exists. So when we start `build/src/mesos-executor` with user `nobody`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang
Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 4:37 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2199 https://issues.apache.org/jira/browse/MESOS-2199 Repository: mesos Description --- Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser. Diffs (updated) - src/tests/slave_tests.cpp e9002e807b500503c5bccf7ce638d98643f229ed Diff: https://reviews.apache.org/r/35728/diff/ Testing --- ### 1. Reproduce problem in old code ```bash # Enter mesos source directory and remove build directory cd mesos rm -rf build # Rebuild mesos mkdir -p build ./bootstrap cd build ../configure # Run the single test make -j8 check GTEST_FILTER=SlaveTest.ROOT_RunTaskWithCommandInfoWithUser ``` When running this test case, the mesos containier running under user `nobody`. And when the containier start `build/src/mesos-executor`, `build/src/mesos-executor` would check the `build/src/.libs/lt-mesos-executor` exists or not. Because we never running other test cases before, `build/src/.libs/lt-mesos-executor` is not exists here. And then `build/src/mesos-executor` would try to compile and generate `build/src/.libs/lt-mesos-executor`. Because `build/src/mesos-executor` is running under user `nobody`, it don't have permissions to output files to `build` directory. This test cases failed finally. ### 2. My way to fix this problem I start a prepare task with root first. And after this task finished with success, we could sure that `build/src/.libs/lt-mesos-executor` is exists. So when we start `build/src/mesos-executor` with user `nobody`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang
Review Request 35974: Fix missing new line in ssl_client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/ssl_client.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35974/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35974: Fix missing new line in ssl_client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/#review89633 --- Ship it! - Joerg Schad On June 27, 2015, 7:30 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/ --- (Updated June 27, 2015, 7:30 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/ssl_client.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35974/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35974: Fix missing new line in ssl_client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/#review89632 --- Ship it! Ship It! - Kapil Arya On June 27, 2015, 3:30 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/ --- (Updated June 27, 2015, 3:30 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/ssl_client.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35974/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 28, 2015, 3:33 a.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description (updated) --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md) Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Review Request 35981: Added persistent volume user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Bugs: MESOS-2405 https://issues.apache.org/jira/browse/MESOS-2405 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) Diffs - docs/persistent-volume.md PRE-CREATION Diff: https://reviews.apache.org/r/35981/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 35911: Moved StatusUpdate.uuid from required to optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35911/#review89651 --- Ship it! Ship It! - Vinod Kone On June 27, 2015, 12:36 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35911/ --- (Updated June 27, 2015, 12:36 a.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-2940 https://issues.apache.org/jira/browse/MESOS-2940 Repository: mesos Description --- The `TaskStatus` contains an optional `UUID`, which should be unset for master-generated updates. This udpates the `StatusUpdate` 'uuid' to also be optional. Since the master and slave assume the 'uuid' is set, this adds CHECKs for now. Later, we'll want to properly validate this instead. I left a TODO for this. Diffs - include/mesos/mesos.proto 81008ed85daea798ed19d1031de8421a7dc3fb19 src/common/type_utils.cpp f88dff76a0dd57f5e16dc4d908655b4bb9d460a5 src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df src/messages/messages.proto 1c8d79e3fca365520cdd67051f8730593955cab6 src/sched/sched.cpp bc76c71ae9d44b291049223366e38cb0fd0c src/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b src/slave/slave.cpp b3e1ccc28d2698d8bc91829d70787dc2fc17b80d src/slave/status_update_manager.cpp 0ad24500c3007202263794fd094fa60535d8f58c Diff: https://reviews.apache.org/r/35911/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 28, 2015, 3:23 a.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Changes --- Conform to the Mesos Markdown Style. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description --- The Github rendered version is available at: https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 3aa9487bed2df038ca27a8bb94c24608ca7910a4 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 967201888114e01f1a2d3c9cfaae847f1ce42d13 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp bba8303347aac3f70566a9e69625a928cfb1bd24 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 5d0970fe9f712d7162eec522c83905292892c94d 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp ae54566b9d0160def6146aa0ce634bdbf0967142 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c 3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp f766359fdd5a75e3a80d19be3e5c233e87357bde 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp a0ea23797376288e8dc96886fd3c0702e5edf846 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 818560f8ce20126e0aa4af6ce368c973c9616c74 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp c6cfb60272d3754fdfdd4a8f9eefe56458d9cbf7 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 5570d62729453a639a94c5569eb510ff2f1395a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp fed005e0bbbcfb7a8a9e4cccf1e47e1ab3d91394 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp dfb2d948f2c20d02f179b4137e59d15a8b3b9c3b 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 0e94e22817e21fc7944a995092e54bf302ab0e2c 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp a4afdad0b5f053186ace4d6a37b41cd02e7d415b 3rdparty/libprocess/3rdparty/stout/include/stout/preprocessor.hpp 11ec3d5349e2087f7352ebadf247ad509ab11c17 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 8c75f6b28c18596018eaefe427b238424aae2fd9 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 8934ba79685685d5f5eae5991057c6ad3c8eea8e 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 552d6e97c882a36d6a889af205c422e51f544b34 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 5ad611497a47be64c539e832b9a1c23e6cf9586d 3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp faca859969a95b51d5fda5542d11906ff03dcf00 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8a0ba5fc004c1dae265aa17e2a014279cd97281 3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b199dc8e8ed538ad771504f0dbee4132fe7 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b9636b9a4e2be57465eea01af6cbc867be 3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31b30ea3fb26d9ca3126daa26a325b61daf 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b6f32403fc2e167364744bb13b2e4969e2 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a716788ed58db35e9fbe5621c07a40d89e7674 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f080a08c203c8986ebbcb92540047ecfabca 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99df5fcf015b9dcc84f12798f8e2532e377 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf746445704cbf4102989cc9fb911a2f6ab3 3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be3640fe896f66565760d93344cf0c264b9 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942cdebc2797b42ac4cf0ffd5b202c9733bf6 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5db57581e0392b31d8187531a9b672d47b 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d9481c02ccbee323fd7e1319b811d344fb1d 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 3211a0d6b88d06b396678eaf20128698f576d198
Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 28, 2015, 5:51 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Summary (updated) - Set the ownership of persistent volume to match the sandbox directory. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the owner of persistent volumes to frameworkInfo.user . Diffs - src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 28, 2015, 3:27 a.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Changes --- Rebased. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description --- The Github rendered version is available at: https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md Diffs (updated) - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 28, 2015, 3:28 a.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description (updated) --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md) Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 35981: Added persistent volume user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89655 --- Patch looks great! Reviews applied: [32982, 35981] All tests passed. - Mesos ReviewBot On June 28, 2015, 3:35 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated June 28, 2015, 3:35 a.m.) Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Bugs: MESOS-2405 https://issues.apache.org/jira/browse/MESOS-2405 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) Diffs - docs/persistent-volume.md PRE-CREATION Diff: https://reviews.apache.org/r/35981/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 28, 2015, 5:42 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the owner of persistent volumes to frameworkInfo.user . Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 28, 2015, 5:46 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the owner of persistent volumes to frameworkInfo.user . Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
