---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---
(Updated Aug. 11, 2015, 10:58 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 11, 2015, 10:57 p.m.)
Review request for mesos, Ben Mahler and
On Aug. 11, 2015, 6 a.m., Benjamin Hindman wrote:
src/hdfs/hdfs.hpp, lines 123-127
https://reviews.apache.org/r/36979/diff/3/?file=1033647#file1033647line123
Wait, how was `|| true` the existing semantics? We are definitely
capturing stderr into stdout, but I don't see anything
On Aug. 11, 2015, 5:39 a.m., Michael Park wrote:
Looks good overall! Same question as
[r37188](https://reviews.apache.org/r/37188/): why did you decide to leave
the `hash_value` functions and call it from `std::hash` specializations
rather than moving the logic?
I assumed that there
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/#review94894
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 7, 2015, 10:44 p.m.,
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21
https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21
Looks like your updating the patchfile here to include my glog PR that
opens it to working on MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 11, 2015, 11:56 a.m.)
Review request for mesos, Alexander Rojas
On Aug. 11, 2015, 6 a.m., Benjamin Hindman wrote:
src/tests/containerizer/port_mapping_tests.cpp, line 975
https://reviews.apache.org/r/36979/diff/3/?file=1033651#file1033651line975
Minor nit, how about here and below:
ASSERT_FALSE(strings::contains(invalid.error(),
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/
---
(Updated Aug. 11, 2015, 7:36 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/
---
(Updated Aug. 11, 2015, 9:34 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/
---
(Updated Aug. 11, 2015, 7:37 a.m.)
Review request for mesos, Benjamin Hindman
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55
https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line55
Sorry, maybe I'm a bit slow this morning -- but how are you running
this? Windows doesn't have the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---
(Updated Aug. 11, 2015, 11:57 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---
(Updated Aug. 11, 2015, 11:58 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/#review94881
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37289/#review94903
---
Patch looks great!
Reviews applied: [37289]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---
(Updated Aug. 11, 2015, 2:30 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 11, 2015, 1:57 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/#review94913
---
Ship it!
Ship It!
- Guangya Liu
On 八月 7, 2015, 10:44 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94912
---
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36429/#review94920
---
Wouldn't it be good if we could have some comments as to how this
On Aug. 11, 2015, 3:57 p.m., Marco Massenzio wrote:
Wouldn't it be good if we could have some comments as to how this class is
supposed to be used, what does it encapsulate, etc.?
At the very least a URL to a design doc or something?
Also, all the methods are completely
On July 29, 2015, 4:04 p.m., James DeFelice wrote:
src/slave/containerizer/isolators/filesystem/linux.cpp, line 238
https://reviews.apache.org/r/36429/diff/1/?file=1009137#file1009137line238
why MS_SHARED (bidirectional) vs MS_SLAVE (one-way)?
MS_SLAVE would probably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/#review90790
---
Ship it!
LGTM!
- Jie Yu
On Aug. 5, 2015, 7:12 p.m., Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review94941
---
Looking. Minor issues. Please make sure when you fix an issue, you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review94843
---
Looks pretty good, just some minor things.
src/master/master.hpp
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55
https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line55
Sorry, maybe I'm a bit slow this morning -- but how are you running
this? Windows doesn't have the
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77
https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line77
So, why change the value to `TRUE` here? Is there some consequence of
this, or is it just clearer to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94946
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 5:04 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review94952
---
Patch looks great!
Reviews applied: [37082, 37192]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37308/#review94953
---
include/mesos/mesos.proto (line 1402)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35668/#review94955
---
Ship it!
Ship It!
- Jie Yu
On June 19, 2015, 9:03 p.m., Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 11, 2015, 5:03 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/
---
(Updated Aug. 11, 2015, 5:04 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37307/#review94939
---
Ship it!
Ship It!
- Jie Yu
On Aug. 10, 2015, 6:31 p.m., Jiang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
---
(Updated Aug. 11, 2015, 5:58 p.m.)
Review request for mesos, Ben Mahler and
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77
https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line77
So, why change the value to `TRUE` here? Is there some consequence of
this, or is it just clearer to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34142/#review94969
---
src/slave/containerizer/provisioners/appc.cpp (lines 471 - 481)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/#review94974
---
3rdparty/libprocess/3rdparty/CMakeLists.txt (line 166)
On July 27, 2015, 11:36 p.m., Adam B wrote:
Great first patch. Thanks for updating FrameworkInfo on reregistration with
the master too!
A handful of nits in my first pass. I'll take another look once you've
simplified the tests with Kapil's suggestions.
Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review94959
---
src/scheduler/scheduler.cpp (lines 328 - 332)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review94970
---
Ship it!
src/tests/common/http_tests.cpp (lines 38 - 40)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/#review94968
---
Ship it!
I think this can be pulled out of this chain to commit it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/#review94958
---
Ship it!
Couple of comments below, but I'll make the adjustments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/#review94976
---
src/tests/scheduler_tests.cpp (lines 168 - 170)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 11, 2015, 8:11 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94880
---
Ship it!
src/hdfs/hdfs.hpp (lines 69 - 88)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37002/#review95010
---
Ship it!
LGTM module comments.
FYI - Adam is out for the next
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/
---
(Updated Aug. 11, 2015, 10:10 p.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/
---
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95015
---
Ship it!
LGTM
- Anand Mazumdar
On Aug. 11, 2015, 10:13 p.m.,
On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote:
Thanks for doing this. Looking pretty good, just some minor comments.
Tim Anderegg wrote:
Thanks for taking the time to review, Vinod. I'll make those changes
tomorrow.
OK, submitted a revision. I'm not sure why the Mesos bot build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37110/#review95011
---
src/tests/authorization_tests.cpp (line 360)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/
---
(Updated Aug. 11, 2015, 10:18 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review95018
---
Ship it!
Thank you.
Ignore the bot failure. It's not related to
On Aug. 11, 2015, 10:19 p.m., Vinod Kone wrote:
Thank you.
Ignore the bot failure. It's not related to your patch.
Cool, I thought as much, thanks again for the feedback.
- Tim
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37125/#review95020
---
Ship it!
LGTM modulo my (blocking) concern about allowing a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95022
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 10:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37309/#review95023
---
src/slave/containerizer/provisioners/appc/paths.hpp (line 55)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---
(Updated Aug. 11, 2015, 11:24 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/
---
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/#review95021
---
src/master/http.cpp (line 593)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review95034
---
Bad patch!
Reviews applied: [37196, 37197, 37198, 37199, 37200,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37266/
---
(Updated Aug. 12, 2015, 1:16 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review95052
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 10:57 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37382/
---
Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---
(Updated Aug. 11, 2015, 11:26 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/#review95027
---
Ship it!
Sorry this took so long, I'll get this committed for you
On Aug. 11, 2015, 6:55 p.m., Vinod Kone wrote:
src/scheduler/scheduler.cpp, line 329
https://reviews.apache.org/r/37303/diff/2/?file=1036937#file1036937line329
indent by 4 spaces.
Not used now. Fixed the other one.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---
(Updated Aug. 11, 2015, 11:34 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95029
---
Ship it!
LGTM !
- Anand Mazumdar
On Aug. 11, 2015, 11:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
---
(Updated Aug. 12, 2015, 1:16 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37378/#review95053
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 12, 2015, 12:14 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/#review95005
---
src/slave/containerizer/provisioners/appc/store.hpp (line 39)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/#review95042
---
Patch looks great!
Reviews applied: [37336]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated Aug. 12, 2015, 2:44 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---
(Updated Aug. 11, 2015, 11:23 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---
(Updated Aug. 11, 2015, 11:21 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37246/
---
(Updated Aug. 11, 2015, 11:32 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review95036
---
Thanks Anand, mostly thinking we can clean up the read logic if we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
---
(Updated Aug. 11, 2015, 11:29 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37192/#review95031
---
Patch looks great!
Reviews applied: [37082, 37192]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
---
(Updated Aug. 11, 2015, 11:36 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37378/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95047
---
Patch looks great!
Reviews applied: [37377]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review95059
---
Sorry for not elaborating on all of these, I added some more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---
(Updated Aug. 12, 2015, 1:10 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
---
(Updated Aug. 12, 2015, 1:10 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37266/
---
(Updated Aug. 12, 2015, 1:10 a.m.)
Review request for mesos.
Bugs:
On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote:
src/slave/containerizer/isolators/filesystem/linux.cpp, lines 267-269
https://reviews.apache.org/r/37236/diff/2/?file=1036681#file1036681line267
mesos.proto documentation on Volume::container_path and
Volume::host_path both require
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37330/#review95046
---
src/slave/containerizer/isolators/filesystem/linux.cpp (line 399)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95051
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 11:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37378/#review95056
---
Patch looks great!
Reviews applied: [37082, 37192, 37378]
All
On Aug. 12, 2015, 1:20 a.m., Ben Mahler wrote:
Thanks Anand, mostly thinking we can clean up the read logic if we have a
struct to capture the reader / decoder.
Isn't it much more simpler here? It's just a one liner if check to check if
the reader is reader is not None and != for stale
95 matches
Mail list logo
