Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/ --- (Updated Sept. 9, 2015, 11:57 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/#review98375 --- Ship it! src/tests/resources_tests.cpp (lines 153 - 158)

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98216 --- Partial review, mostly high level.

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 10, 2015, 7:31 a.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/#review98376 --- Ship it! Ship It! - Michael Park On Sept. 9, 2015, 2:45 p.m.,

Re: Review Request 37589: Remove unnecessary usage information.

2015-09-10 Thread haosdent huang
> On Aug. 30, 2015, 10:31 p.m., Michael Park wrote: > > This is great! Many of these were slightly incorrect. They're all fixed now > > :) > > e.g. `/statistics.json` -> `/monitor/statistics.json` > > Michael Park wrote: > I've committed this patch for you with a trivial rebase. Thank you

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

2015-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/ --- (Updated Sept. 10, 2015, 10:12 a.m.) Review request for mesos, Joris Van

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38075/ --- (Updated Sept. 9, 2015, 11:59 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38240/ --- (Updated Sept. 10, 2015, midnight) Review request for mesos and Jie Yu.

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review98329 --- I've made a few nit comments below but I have some higher-level

Re: Review Request 38252: Remove namespaces method in LinuxFilesystemIsolatorProcess.

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38252/ --- (Updated Sept. 10, 2015, 9:53 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/ --- (Updated Sept. 10, 2015, 12:04 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 37773: Docker: Adding registry client.

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review98368 --- Patch looks great! Reviews applied: [37871, 37427, 37773] All

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/#review98371 --- 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review98370 --- Ship it! Looks good!

Review Request 38253: [MESOS-2875] Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- Review request for mesos. Bugs: MESOS-2875

Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review98363 --- Patch looks great! Reviews applied: [37968] All tests passed. -

Re: Review Request 37505: Fix broken health check in docker executor.

2015-09-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review98364 --- src/tests/health_check_tests.cpp (line 258)

Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review98366 --- Ship it! I've committed this for you with the following minor

Re: Review Request 37586: Generate usage help information in libprocess.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/#review98377 --- Ship it! Ship It! - Michael Park On Sept. 4, 2015, 6:53 p.m.,

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38075/#review98381 --- Patch looks great! Reviews applied: [38239, 38240, 38241, 38075]

Re: Review Request 38241: Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38241/ --- (Updated Sept. 9, 2015, 11:59 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 37589: Remove unnecessary usage information.

2015-09-10 Thread Michael Park
> On Aug. 30, 2015, 10:31 p.m., Michael Park wrote: > > This is great! Many of these were slightly incorrect. They're all fixed now > > :) > > e.g. `/statistics.json` -> `/monitor/statistics.json` I've committed this patch for you with a trivial rebase. - Michael

Review Request 38252: Remove namespaces method in LinuxFilesystemIsolatorProcess.

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38252/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-3349

Re: Review Request 37505: Fix broken health check in docker executor.

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Sept. 10, 2015, 7:16 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38253: [MESOS-2875] Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98393 --- src/slave/slave.cpp (line 4373)

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/#review98396 --- Patch looks great! Reviews applied: [38251] All tests passed. -

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

2015-09-10 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/#review98394 --- src/master/master.cpp

Re: Review Request 37505: Fix broken health check in docker executor.

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review98385 --- Patch looks great! Reviews applied: [37505] All tests passed. -

Re: Review Request 38252: Remove namespaces method in LinuxFilesystemIsolatorProcess.

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38252/#review98388 --- Patch looks great! Reviews applied: [38252] All tests passed. -

Re: Review Request 38240: Renamed appc_backend flag to appc_provisioner_backend.

2015-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38240/#review98395 --- Ship it! Ship It! - Guangya Liu On Sept. 10, 2015, 7 a.m.,

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98391 --- Patch looks great! Reviews applied: [38137] All tests passed. -

Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-3340

Review Request 38256: Update framework-rate-limiting.md

2015-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38256/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 38253: [MESOS-2875] Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98399 --- Patch looks great! Reviews applied: [38253] All tests passed. -

Re: Review Request 38256: Update framework-rate-limiting.md

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38256/#review98407 --- Patch looks great! Reviews applied: [38256] All tests passed. -

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/ --- (Updated Sept. 10, 2015, 4:51 p.m.) Review request for mesos, Adam B and

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-10 Thread Alexander Rukletsov
> On Sept. 10, 2015, 9:54 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 37 > > > > > > We don't need `inline` here as this is a `cpp` file. Right, good catch! > On

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/#review98425 --- Patch looks great! Reviews applied: [38056] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98413 --- Patch looks great! Reviews applied: [38259] All tests passed. -

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-10 Thread Timothy Chen
> On Sept. 10, 2015, 12:21 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/docker.hpp, line 88 > > > > > > Any reason those fields are not const? Changed to protobuf now. - Timothy

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread haosdent huang
> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > LGTM. But I not sure if this match @marco expect. Could you add he as > > reviewers? So currently your approach is show error message when > > `duplicates` is true. Use command line parameters when command line > > variables conflict

Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

2015-09-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/#review98418 --- src/Makefile.am (line 485)

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98410 --- LGTM. But I not sure if this match @marco expect. Could you add he

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-10 Thread Alexander Rukletsov
> On Sept. 10, 2015, 8:44 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 606 > > > > > > Would `_value` be better than `v` here? Maybe `elem`...? I don't like `_*`

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 6:04 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review98437 --- Bad patch! Reviews applied: [36126] Failed command:

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-10 Thread Alexander Rukletsov
> On Sept. 10, 2015, 8:44 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 626-627 > > > > > > > overload will not work because ... > > > > As I mentioned

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-10 Thread Alexander Rukletsov
> On Sept. 10, 2015, 9:54 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 191-192 > > > > > > The above test already performs the roundtrip of Protobuf -> JSON -> >

Re: Review Request 37876: stout: Replace GCC intrinsics with std::atomic.

2015-09-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37876/ --- (Updated Sept. 10, 2015, 6:53 p.m.) Review request for mesos, Joris Van

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated Sept. 10, 2015, 5:33 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/ --- (Updated Sept. 10, 2015, 10:42 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/ --- (Updated Sept. 10, 2015, 5:43 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38075/#review98448 --- Ship it! src/tests/containerizer/appc_provisioner_tests.cpp (line

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

2015-09-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/ --- (Updated Sept. 10, 2015, 6:45 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

2015-09-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/ --- (Updated Sept. 10, 2015, 6:46 p.m.) Review request for mesos, Joseph Wu and

Review Request 38265: mesos: Update style guide for usage of std::atomic.

2015-09-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38265/ --- Review request for mesos. Repository: mesos Description --- mesos:

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-10 Thread Alexander Rukletsov
> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 442-444 > > > > > > Let's let compiler do it's job: how about passing `left` by value and > > not creating a copy manually?

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-10 Thread Alexander Rukletsov
> On Sept. 9, 2015, 3:46 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 250-271 > > > > > > I think we can conflate this two cases, how about this: > > ``` > > if (range->end() + 1 >=

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
> On Sept. 9, 2015, 10:46 p.m., Adam B wrote: > > Looks great! I'm not sure if we needed to change all the internal > > references to remove .json, since we're keeping that endpoint for > > compatibility, but it's good that we're testing the new endpoint. > > > > Did you test to verify that

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:58 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:59 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38239: Renamed appc.{hpp|cpp} to slave/containerizer/provisioners/appc/provisioner.{hpp|cpp}.

2015-09-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38239/#review98442 --- Ship it! Ship It! - Jie Yu On Sept. 10, 2015, 5:42 p.m., Jiang

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 10, 2015, 11:25 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38241: Fixed an issue that caused provisioned filesystems specified in --default_container_info to be not recovered.

2015-09-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38241/#review98443 --- Ship it!

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 10, 2015, 6:36 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review98454 --- Bad patch! Reviews applied: [36126] Failed command:

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Isabel Jimenez
> On Sept. 9, 2015, 10:51 p.m., Adam B wrote: > > Minor comments, but it looks shippable to me after those are resolved. > > > > Did you test to verify that the old endpoints still work as expected? Yes I tested the old endpoints :) - Isabel

Re: Review Request 38233: os: add swap information to memory().

2015-09-10 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38233/ --- (Updated Sept. 10, 2015, 5:57 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 37878: mesos: Replace volatile with std::atomic.

2015-09-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37878/ --- (Updated Sept. 10, 2015, 6:55 p.m.) Review request for mesos, Joris Van

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/ --- (Updated Sept. 10, 2015, 6:54 p.m.) Review request for mesos, Joris Van

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98490 --- Ship it! Ship It! - Yong Qiao Wang On 九月 10, 2015, 10:32 p.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:38 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Artem Harutyunyan
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp, line 57 > > > > > > A comment describing why do we need this function would be great. >

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Joris Van Remoortere
> On Sept. 8, 2015, 10:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's

Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38077/#review98512 --- The above reviewbot failure is related to the recently committed

Re: Review Request 38282: Fixed flaky ReservationEndpointsTest.AvailableResources test.

2015-09-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38282/#review98523 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 11, 2015,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 10:32 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38284/#review98525 --- Ship it! Ship It! - Chi Zhang On Sept. 11, 2015, 1:12 a.m., Jie

Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38284/ --- Review request for mesos, Chi Zhang, Vinod Kone, and Jiang Yan Xu. Repository:

Re: Review Request 37370: Fix CMake build compile error; don't compile GMock with cxx11 flag.

2015-09-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37370/#review98506 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 10, 2015,

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 9:46 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Joseph Wu
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's

Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.

2015-09-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37877/#review98522 --- 3rdparty/libprocess/src/latch.cpp (line 41)

Re: Review Request 38282: Fixed flaky ReservationEndpointsTest.AvailableResources test.

2015-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38282/#review98528 --- Ship it! Ship It! - Guangya Liu On 九月 11, 2015, 12:50 a.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:33 p.m.) Review request for mesos, Adam B, Anand

Review Request 38278: Updating unversioned Executor protobuf

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38278/ --- Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Repository:

Review Request 38282: Fixed flaky ReservationEndpointsTest.AvailableResources test.

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38282/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3411

Re: Review Request 37370: Fix CMake build compile error; don't compile GMock with cxx11 flag.

2015-09-10 Thread Alex Clemmer
> On Sept. 8, 2015, 11:12 p.m., Artem Harutyunyan wrote: > > This file has not been commited, so I suggest to drop this review and make > > this change in the original review that introduces the affected line. > > Alex Clemmer wrote: > It actually has been committed. haosdent broke the

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Artem Harutyunyan
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's

Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38284/#review98527 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 10, 2015, 6:12 p.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
> On Sept. 10, 2015, 1:17 a.m., Vinod Kone wrote: > > include/mesos/v1/executor/executor.proto, lines 89-90 > > > > > > Much like with the scheduler, invalid calls result in BadRequest. We > > should really update

Re: Review Request 38265: mesos: Update style guide for usage of std::atomic.

2015-09-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38265/#review98519 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 10, 2015,

Re: Review Request 38282: Fixed flaky ReservationEndpointsTest.AvailableResources test.

2015-09-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38282/#review98521 --- Ship it! Ship It! - Joseph Wu On Sept. 10, 2015, 5:50 p.m.,

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-10 Thread Michael Park
> On Sept. 10, 2015, 9:54 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 191-192 > > > > > > The above test already performs the roundtrip of Protobuf -> JSON -> >

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-09-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review98533 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 912)

Re: Review Request 38289: Handle bad request in Docker registry client.

2015-09-10 Thread Timothy Chen
> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 572 > > > > > > You will have to set O_NONBLOCK on the file descriptor. This is done in

Re: Review Request 38289: Handle bad request in Docker registry client.

2015-09-10 Thread Timothy Chen
> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 386 > > > > > > This block should be refactored out so that it can be handled in line >

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 569 > > > > > > Is it possible to change to foreach here? > > Klaus Ma wrote: >

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-09-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98531 --- Ship it! Still a Ship it, just another comment.

  1   2   >