Re: Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

2015-09-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38321/ --- (Updated Sept. 12, 2015, 6:08 p.m.) Review request for mesos and Adam B.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98746 --- Some preliminary comments.

Re: Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

2015-09-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38321/#review98753 --- Patch looks great! Reviews applied: [36126, 36125, 36127, 38321]

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-12 Thread Robert Lacroix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review98758 --- Ship it! Ship It! - Robert Lacroix On Sept. 6, 2015, 2:40 a.m.,

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/ --- (Updated Sept. 13, 2015, 4:34 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38328: Added a helper to get stat.st_dev in stout.

2015-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38328/#review98738 --- Ship it! Ship It! - haosdent huang On Sept. 12, 2015, 6:36

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98743 --- Ship it! Ship It!

Review Request 38328: Added a helper to get stat.st_dev in stout.

2015-09-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38328/ --- Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang

Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/ --- Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98735 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 91)

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? Good catch!

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/ --- (Updated Sept. 12, 2015, 7:26 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98745 --- Patch looks great! Reviews applied: [38328, 38329] All tests

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-12 Thread Jiang Yan Xu
> On Sept. 10, 2015, 3:04 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/docker.cpp, lines 104-107 > > > > > > I guess you are modeling this after the `docker pull` syntax here: > >

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-09-12 Thread Adam B
> On July 7, 2015, 11:40 a.m., Vinod Kone wrote: > > CHANGELOG, line 337 > > > > > > I would just put this under deprecations section. > > > > Also, mind updating MESOS-2058 in deprecation section to do >

Re: Review Request 21713: Route overload to add auth HTTP Response + tests

2015-09-12 Thread Adam B
> On June 3, 2014, 10:29 a.m., Adam B wrote: > > Great stuff. Just a couple of comments from me. @ijimenez Is this patch still necessary? If not, let's discard it. If so, please rebase and revive it. Thanks. - Adam --- This is an

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-09-12 Thread Adam B
> On Aug. 3, 2015, 6:41 p.m., Adam B wrote: > > Looks great! Just a couple of questions. > > Did you run `sudo make check`, since you modified `ROOT_` tests? @karya, should we revive this patch now, or discard it? - Adam --- This is an

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-12 Thread Jiang Yan Xu
> On Sept. 10, 2015, 3:04 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/docker/local_store.cpp, lines 158-160 > > > > > > Can we actually use fetcher here? > > Timothy Chen wrote: > Not