Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3433

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/#review99357 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp

Review Request 38452: Updated C++ style guide for namespace usage

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3450

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/#review99359 --- Patch looks great! Reviews applied: [38447] All tests passed. -

Re: Review Request 38124: Add V1 Support for QuiesceOffers

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/#review99358 --- Ship it! Ship It! - Jian Qiu On Sept. 16, 2015, 6:01 a.m.,

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-17 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 17, 2015, 4:25 p.m.) Review request for mesos, Artem

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review99363 --- Patch looks great! Reviews applied: [38452] All tests passed. -

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 17, 2015, 9:55 a.m.) Review request for mesos, haosdent huang,

Review Request 38455: CMake: Remove thread_tests.cpp from Stout tests.

2015-09-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38455/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38456: CMake: Fix MESOS-3395, MESOS-3394, add canonical third-party lib source.

2015-09-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38456/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99368 --- Patch looks great! Reviews applied: [38399] All tests passed. -

Review Request 38457: CMake: Fix MESOS-3250, a dynamic load in Stout tests on OS X.

2015-09-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 17, 2015, 10:03 a.m.) Review request for mesos, Artem

Re: Review Request 38455: CMake: Remove thread_tests.cpp from Stout tests.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38455/#review99372 --- Patch looks great! Reviews applied: [38455] All tests passed. -

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99369 --- Patch looks great! Reviews applied: [38454] All tests passed. -

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-17 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 17, 2015, 4:31 p.m.) Review request for mesos, Artem

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99361 --- Ship it! Could you use ``` sudo ./mesos-tests.sh

Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99365 --- Ship it! Ship It! - Guangya Liu On Sept. 17, 2015, 8:28 a.m.,

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
> On Sept. 17, 2015, 8:48 a.m., haosdent huang wrote: > > Could you use > > > > ``` > > sudo ./mesos-tests.sh > > --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" > > --gtest_repeat=1000 --gtest_break_on_failure > > ``` > > > > to test it? Done, thanks for reminding! -

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99376 --- I think that you also need some test cases for

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review99400 --- Thanks for fixing this, but I'm wondering how this fixes the issue.

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99401 --- I'm excited about this! Tested on OSX and (at least, as far as

Re: Review Request 38456: CMake: Fix MESOS-3395, MESOS-3394, add canonical third-party lib source.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38456/#review99399 --- Ship it! Changes looks good. General question: How do you

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99394 --- Patch looks great! Reviews applied: [38003] All tests passed. -

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 17, 2015, 3:07 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99378 --- Patch looks great! Reviews applied: [38456, 38457] All tests

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review99420 --- Patch looks great! Reviews applied: [38253] All tests passed. -

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work?

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 17, 2015, 5:41 p.m.) Review request for mesos and Niklas

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review99411 --- Patch looks great! Reviews applied: [38443] All tests passed. -

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-17 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Sept. 17, 2015, 5:06 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread haosdent huang
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work?

Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99387 --- I've commented on some issues. Several patterns I would like to ask

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99402 --- Note: I was hoping you would put changes in the docs and to the

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-17 Thread Jojy Varghese
> On Sept. 17, 2015, 2:54 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 499 > > > > > > If history array contains non JSON Object from the response I think it >

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38030/#review99423 --- src/Makefile.am (line 111)

Re: Review Request 38076: [4/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38076/ --- (Updated Sept. 17, 2015, 12:14 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 17, 2015, 12:14 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38077/ --- (Updated Sept. 17, 2015, 12:14 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review99424 --- Just a few comments related to what I picked up from the sync.

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review99427 --- docs/reporting-a-bug.md (line 11)

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38030/ --- (Updated Sept. 17, 2015, 12:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38455: CMake: Remove thread_tests.cpp from Stout tests.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38455/#review99434 --- Looks like this test doesn't exist anymore. At the same time,

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Jie Yu
> On Sept. 17, 2015, 7:17 p.m., Jie Yu wrote: > > src/Makefile.am, line 111 > > > > > > Have you guys looked at the code in the picojson? > > https://github.com/kazuho/picojson/blob/master/picojson.h#L61 > >

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99422 --- Bad patch! Reviews applied: [38279] Failed command:

Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38077/#review99433 --- Patch looks great! Reviews applied: [38028, 38030, 38031, 38076,

Re: Review Request 38028: [1/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38028/ --- (Updated Sept. 17, 2015, 12:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38030/ --- (Updated Sept. 17, 2015, 2:01 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99442 --- Ship it! feel free to resolve the open issues.

Re: Review Request 38120: Add Java Support for QuiesceOffers

2015-09-17 Thread Vinod Kone
> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > can you also update the java test framework to test this call? > > Guangya Liu wrote: > I see that the reviveOffers also do not have a example, I want to handle > those two APIs together in another patch,

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/ --- (Updated Sept. 17, 2015, 2:58 p.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review99452 --- Patch looks great! Reviews applied: [38468] All tests passed. -

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/#review99457 --- Bad patch! Reviews applied: [38447] Failed command:

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99450 --- src/tests/mesos.hpp (line 1608)

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38447/#review99451 --- Ship it! Ship It! - Jie Yu On Sept. 17, 2015, 10:03 p.m., Jiang

Re: Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

2015-09-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38471/#review99454 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 17, 2015, 2:59 p.m.,

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review99440 --- Patch looks great! Reviews applied: [38468] All tests passed. -

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/ --- (Updated Sept. 17, 2015, 9:28 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38124: Add V1 Support for QuiesceOffers

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/#review99449 --- Ship it! src/tests/scheduler_tests.cpp (line 1021)

Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38471/ --- Review request for mesos, haosdent huang, Timothy Chen, and Jiang Yan Xu.

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-17 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review99456 --- LGTM, thanks for doing this, Neil! - Artem Harutyunyan On Sept.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99443 --- Ship it! include/mesos/scheduler.hpp (line 271)

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99445 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 247)

Re: Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38471/ --- (Updated Sept. 17, 2015, 9:59 p.m.) Review request for mesos, haosdent huang,

Review Request 38472: Made filesystem/posix the default filesystem isolator.

2015-09-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38472/ --- Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu.

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99453 --- Can you write a test for this? src/master/master.cpp (lines 5552

Re: Review Request 38472: Made filesystem/posix the default filesystem isolator.

2015-09-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38472/#review99455 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 17, 2015, 3:11 p.m.,

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-17 Thread Niklas Nielsen
> On Sept. 14, 2015, 1:20 p.m., Niklas Nielsen wrote: > > Per Connors comment, we need a test to exercise the new code Ping - let's get this in soon :) - Niklas --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-17 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Sept. 18, 2015, 1:17 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review99467 --- Patch looks great! Reviews applied: [38003] All tests passed. -

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review99472 --- Patch looks great! Reviews applied: [38443] All tests passed. -

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/#review99461 --- Patch looks great! Reviews applied: [38470] All tests passed. -

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 18, 2015, 12:13 a.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-17 Thread Klaus Ma
> On Sept. 17, 2015, 9:13 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 3733 > > > > > > why the change in formatting? we allow 80 char comments now? do you mean the following comments?

Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

2015-09-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38470/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 17, 2015, 11:34 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 18, 2015, 3:55 a.m.) Review request for mesos, Alexander

Re: Review Request 38120: Add Java Support for QuiesceOffers

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38120/ --- (Updated 九月 18, 2015, 3:55 a.m.) Review request for mesos, Alexander

Re: Review Request 38124: Add V1 Support for QuiesceOffers

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/ --- (Updated 九月 18, 2015, 3:57 a.m.) Review request for mesos, Alexander

Re: Review Request 38120: Add Java Support for QuiesceOffers

2015-09-17 Thread Guangya Liu
> On 九月 15, 2015, 7:12 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > can you also update the java test framework to test this call? > > Guangya Liu wrote: > I see that the reviveOffers also do not have a example, I want to handle > those two APIs together in another patch, make

Re: Review Request 38121: Add Python Support for QuiesceOffers

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38121/ --- (Updated 九月 18, 2015, 3:56 a.m.) Review request for mesos, Alexander

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
> On Sept. 17, 2015, 4:39 p.m., Marco Massenzio wrote: > > Thanks for fixing this, but I'm wondering how this fixes the issue. > > (in fact, not even what is it testing). > > > > If you invoke `cat` without input, it will just hang there waiting on > > STDIN, how does this make the test work?

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 18, 2015, 2:51 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 38119: Add metrics of messages_quiesce_offers

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38119/ --- (Updated 九月 18, 2015, 3:55 a.m.) Review request for mesos, Alexander

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 18, 2015, 3:54 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)

2015-09-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/#review99481 --- Ship it! Thanks for your patience!

Re: Review Request 38124: Add V1 Support for QuiesceOffers

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38124/#review99485 --- Patch looks great! Reviews applied: [37532, 37873, 38119, 38120,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 18, 2015, 5:17 a.m.) Review request for mesos, Bernd Mathiske