Re: Review Request 38158: Refactored Value::Ranges coalesce().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review99491
---


Patch looks great!

Reviews applied: [38158]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 5:17 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
> 
> (Updated Sept. 18, 2015, 5:17 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The goal of this refactoring was to reuse the Ranges objects as much as 
> possible, as prior there was substantial time spend in allocation/destruction 
> (MESOS-3051).
> 
> 
> Diffs
> -
> 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/38158/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38470/#review99496
---

Ship it!


Ship It!

- Guangya Liu


On 九月 17, 2015, 10:50 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38470/
> ---
> 
> (Updated 九月 17, 2015, 10:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add regression test.  Note that the test may be slow until inverse offers 
> filters are actually implemented.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
> 
> Diff: https://reviews.apache.org/r/38470/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38158: Refactored Value::Ranges coalesce().

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/
---

(Updated Sept. 18, 2015, 6:39 a.m.)


Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till 
Toenshoff.


Bugs: MESOS-3051
https://issues.apache.org/jira/browse/MESOS-3051


Repository: mesos


Description
---

The goal of this refactoring was to reuse the Ranges objects as much as 
possible, as prior there was substantial time spend in allocation/destruction 
(MESOS-3051).


Diffs (updated)
-

  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
  src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
  src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 

Diff: https://reviews.apache.org/r/38158/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/#review99631
---


Patch looks great!

Reviews applied: [38244, 38246, 38324, 38475]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 10 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38475/
> ---
> 
> (Updated Sept. 18, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Checks that filters change which inverse offer is sent when.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 9892bc329ff850f638e9f5e79d047efaf2fcb037 
> 
> Diff: https://reviews.apache.org/r/38475/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

[Michael Park]

> On Sept. 9, 2015, 11:46 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, lines 
> > 96-97
> > 
> >
> > `s/std::make_pair(key, value)/{key, value}/`
> 
> Alexander Rojas wrote:
> I wasn't sure if we are allowing initializer lists constructors. Some 
> people have complained about them in my reviews. Can you clarify? I for 
> myself am all in.

I'm not sure, let's keep `std::make_pair` in case people have complaints.


> On Sept. 9, 2015, 11:46 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp, lines 
> > 107-117
> > 
> >
> > Can we just `auto` all of this away?
> > 
> > ```
> > auto range =
> >   std::unordered_multimap::equal_range(key);
> > for (auto it = range.first; it != range.second; ++it) {
> >   values.push_back(it->second);
> > }
> > ```
> 
> Alexander Rojas wrote:
> Same here, I have gotten complains about using auto. Are we allowed to 
> use it, if so in which cases?

We have a relatively clear guideline for the use of `auto`. The following 
example is mentioned as a valid use case:
```cpp
// 1: OK.
const auto i = values.find(keys.front());
// Compare with
const typename map::iterator i = values.find(keys.front());
```
Since `equal_range` is a standard library function like `find`, I think it's 
perfectly fine to use `auto` here.


> On Sept. 9, 2015, 11:46 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp, lines 34-37
> > 
> >
> > Can I ask why we want these? Presumably the purpose of these classes 
> > are to eliminate the need for their `std::` counterparts.
> > 
> > If we look at a class like `Set`, it inherits from `std::set` but 
> > doesn't construct off of `std::set`. Similarly, `hashmap` inherits from 
> > `std::unordered_map`, but doesn't construct off of `std::unordered_map`.
> 
> Alexander Rojas wrote:
> I have no strong feelings about removing them. But if you check `hashset` 
> it has a constructor from a `set` just like this one, so I am just trying to 
> keep up with their signatures. I did find weird to have a constructor from 
> `set` to `hashset` though. I'll drop this and if you think I really ought to 
> remove it, please reopen.

__TL;DR:__ The mapping from `std::set` -> `hashset` is different than 
`std::multimap` -> `multimap`. Let's remove it.
> But if you check hashset it has a constructor from a set just like this one

I don't think they're quite the same. `hashset` and others construct off of a 
similar but different data structure, not from the thing that they're intended 
to be replacing. As in, since `hashset` is intended to replace 
`std::unordered_set`, it doesn't construct off `std::unordered_set`. This 
`multimap` is intended to replace `std::multimap`, so it shouldn't construct 
off of `std::multimap`, but it __could__ construct off of other similar classes 
such as `std::map`, for example.
> I did find weird to have a constructor from set to hashset though

Yep, that's because this pattern of constructing off of other similar classes 
runs into the `N^2` combinatorial problem. As in, why shouldn't `hashset` 
construct off of `std::vector`, `std::list`, `std::deque`, `std::array`, etc? 
This is why iterators were introduced into the standard library in the first 
place, in order to decouple them. We could use templates and contrain it such 
that we only accept containers that can be iterated on, but there's a lot of 
work going into a v2 of the standard library with the emergence of concepts 
into the language.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/#review98293
---


On Sept. 16, 2015, 6:14 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37714/
> ---
> 
> (Updated Sept. 16, 2015, 6:14 a.m.)
> 
> 
> Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-2924
> https://issues.apache.org/jira/browse/MESOS-2924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds extra template parameters to `multihashmap` which offer control over the 
> hash function to use as well as the equality operator.
> 
> Implements initializer_list, copy and move constructors for both, 
> `multihashmap` and `Multimap` in a similar way as it was done for `hashmap` 
> and `hashset`.
> 
> 
> Diffs
> -
> 
>   

Re: Review Request 38074: Calculate schedule latency with trace events

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38074/#review99634
---


Patch looks great!

Reviews applied: [37540, 37541, 38074]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 10:13 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38074/
> ---
> 
> (Updated Sept. 18, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Finally, calculate schedule latency with the sched trace events, and add it 
> to our statistics
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 
> 1f722ef3ef7ab7fce5542d4affae961d6cec2406 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
> 
> Diff: https://reviews.apache.org/r/38074/diff/
> 
> 
> Testing
> ---
> 
> manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 38279: Enabled resources/attributes discovery

[Felix Abecassis]

> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote:
> > src/hook/manager.cpp, line 261
> > 
> >
> > Please add a comment describing how the order of hook execution is 
> > determined.  e.g. order in which they appear in the modules json passed to 
> > the slave, etc.

Actually, it seems there is no predefined order right now since 
src/hook/manager.cpp is using a hashmap, should I open another issue to discuss 
how to fix this?


- Felix


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review98860
---


On Sept. 14, 2015, 5:39 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> ---
> 
> (Updated Sept. 14, 2015, 5:39 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> First API draft for MESOS-3366.
> 
> 1) Only supports resources for now, we can add another hook for attributes 
> with a very similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct 
> a new Resources object.
> 3) If there is multiple callbacks, each callback will see the changes made by 
> previous callbacks and are free to override or merge the detected resources 
> as they see fit.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp d90bacc 
>   src/examples/test_hook_module.cpp bc13a8a 
>   src/hook/manager.hpp 30d8321 
>   src/hook/manager.cpp 754c238 
>   src/slave/slave.cpp 5e5522e 
> 
> Diff: https://reviews.apache.org/r/38279/diff/
> 
> 
> Testing
> ---
> 
> make clean && make && make check
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
---



docs/maintenance.md (line 25)


s/adds/add/.



docs/maintenance.md (line 27)


Did the notion of an operator not exist before Maintenance Primitives were 
introduced? I would rephrase the sentence above to say that we're definining 
terms for the puropse of this doc.



docs/maintenance.md (line 35)


s/in/during/
s/may not be/may become/



docs/maintenance.md (line 36)


s/about the/about the availability of the/



docs/maintenance.md (line 40)


s/will have unavailability info attached/will contain unavailability 
information/



docs/maintenance.md (lines 72 - 73)


Please add anchors to links so that the relevant parts of the .proto file 
in each case are highlighted.



docs/maintenance.md (line 75)


s/the schedule is/the schedule must be/



docs/maintenance.md (lines 91 - 92)


Can they also specify seconds? If not, we should definitely add a JIRA for 
that (as a syntactic sugar for the interface). Please mention somewhere that 
start is the nanoseconds since epoch.



docs/maintenance.md (line 107)


s/this schedule/the schedule/



docs/maintenance.md (line 118)


s/if, say, a faulty machine launches agents on boot./to, say, prevent a 
faulty machine from launching an agent on boot./



docs/maintenance.md (line 120)


What does this mean for the person reading this? Should they supply extra 
options through the agent command line? Should they make sure that their 
/etc/hosts is sane? This is currently not actionable, but it has to be.



docs/maintenance.md (line 127)


What if one or several of the checks fail?



docs/maintenance.md (line 133)


Isn't this one obvious?



docs/maintenance.md (line 134)


What does this mean? What if they aren't?



docs/maintenance.md (line 135)


Please explain a recommended workflow for updating maintenance schedule, 
and canceling it.



docs/maintenance.md (lines 144 - 145)


Does this potentially mean a mass task restart across the nodes that are 
undergoing maintenance?



docs/maintenance.md (line 190)


a link to .proto would be helpful here too.



docs/maintenance.md (line 203)


Again, not clear what happens if one of these conditions fails.



docs/maintenance.md (line 224)


s/maintenance starts/maintenance is triggered by the operator/.



docs/maintenance.md (line 235)


Link to .proto, please?



docs/maintenance.md (line 249)


s/guess/a best effort guess/


- Artem Harutyunyan


On Sept. 18, 2015, 12:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 12:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> 

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/
---

(Updated Sept. 19, 2015, 12:51 a.m.)


Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.


Changes
---

Address comments


Bugs: MESOS-3340
https://issues.apache.org/jira/browse/MESOS-3340


Repository: mesos


Description
---

Currently, it appears that re-defining a flag on the command-line that was 
already defined via a OS Env var (MESOS_*) causes the Master to fail with a not 
very helpful message.

For example, if one has MESOS_QUORUM defined, this happens:

$ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
--hostname=192.168.1.4 --ip=192.168.1.4
Duplicate flag 'quorum' on command line

which is not very helpful.

Current solution is to throw error if any duplication; over-write may make user 
confused about the result.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 43c09f3 

Diff: https://reviews.apache.org/r/38259/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99640
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated 九月 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38347/#review99641
---


Patch looks great!

Reviews applied: [38347]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 10:43 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38347/
> ---
> 
> (Updated Sept. 18, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3419
> https://issues.apache.org/jira/browse/MESOS-3419
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add HELP Message for Reserve/Unreserve endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 8bb59355e3852617faccad8cc65e1f9dbd7988b4 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
> 
> Diff: https://reviews.apache.org/r/38347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 18, 2015, 12:51 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Update json examples to match code changes.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38497/#review99590
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38497/
> ---
> 
> (Updated Sept. 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a stub endpoint on Agent. As of now, it doesn't do 
> much except validating the `Content-Type`, `Accept` headers among other 
> trivial validations. Most of the functionality already existed in 
> `src/master/http.cpp`
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e 
>   src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
> 
> Diff: https://reviews.apache.org/r/38497/diff/
> 
> 
> Testing
> ---
> 
> make check + tests in r38499
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 38516: Changed quiesceOffers to SuppressOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.


Diffs
-

  include/mesos/master/allocator.hpp 2dc631242bca8d5e1d536126770f5bcbab2fefed 
  include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
d8acc4fe92fc8dfbd582b165fba24dac492c28d4 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
de88463da2f6833633542442a0d66370507c4018 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
ba4bc58f57b01ad3705438e1172bf6663e2a2446 
  src/master/allocator/mesos/allocator.hpp 
86f6c5572f831b19a3eb006456320df2a445df45 
  src/master/allocator/mesos/hierarchical.hpp 
8f2232a13b6fa0cd01d0399460f9637858a8c6b8 
  src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
  src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf 
  src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988 
  src/python/interface/src/mesos/interface/__init__.py 
cd60ead6c6519d7347aec1fd9315735af0fa818a 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
04e3190949fba8e4675352636b0a649a033f702f 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
10208b176c9b45d5c9afc096564e27403dcde695 
  src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
  src/tests/master_tests.cpp a044286d10bf1ab0676c7d403af59e0b1fea 
  src/tests/mesos.hpp 760dcb7a224141d772098ccd1a7658b2d28f6e21 
  src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb 
  src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 

Diff: https://reviews.apache.org/r/38516/diff/


Testing
---


Thanks,

Guangya Liu

Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38514/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

A comment from Vinod: After some discussion with other committers,
most of them felt SUPPRESS is better than QUIESCE.


Diffs
-

  include/mesos/scheduler/scheduler.proto 
89ddc10d5873cdf09bf5084c4869bc7c29933eab 
  include/mesos/v1/scheduler/scheduler.proto 
bc19b8dfb2ded26a30a28e7370f06816e0fb1999 
  src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
  src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
  src/master/validation.cpp 0f3fc1a20b065a88712cceabab0ceffaec598533 
  src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
  src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 

Diff: https://reviews.apache.org/r/38514/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 38279: Enabled resources/attributes discovery

[Felix Abecassis]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/
---

(Updated Sept. 19, 2015, 12:51 a.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Changes
---

Added tests, changed the name of the hook.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

First API draft for MESOS-3366.

1) Only supports resources for now, we can add another hook for attributes with 
a very similar code.
2) The callback currently receives the full SlaveInfo structure and construct a 
new Resources object.
3) If there is multiple callbacks, each callback will see the changes made by 
previous callbacks and are free to override or merge the detected resources as 
they see fit.


Diffs (updated)
-

  include/mesos/hook.hpp 2353602 
  src/examples/test_hook_module.cpp 0dc74d6 
  src/hook/manager.hpp a517c05 
  src/hook/manager.cpp 691976e 
  src/slave/slave.cpp ad710d7 
  src/tests/hook_tests.cpp b23a587 

Diff: https://reviews.apache.org/r/38279/diff/


Testing
---

make clean && make && make check


Thanks,

Felix Abecassis

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

[Klaus Ma]

> On Sept. 18, 2015, 8:03 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 240-241
> > 
> >
> > How about we remove this, inline the string literal at the 2 callsites 
> > below for now, and we'll remove the duplication when we do the refactor of 
> > the very-similar `load` function definitions?

Addresses; and MESOS-3454 is also logged to trace duplicated code in 
Flags::load.


> On Sept. 18, 2015, 8:03 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, lines 426-427
> > 
> >
> > Let's not test for specific error strings. Simply checking for the 
> > error is good enough for now. Once we get to introducing typed errors, 
> > we'll be able to capture it better within the type system.

Addressed; MESOS-3469 is logged to trace "typed error system", add `TODO` to 
highlight the plan.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/#review99588
---


On Sept. 13, 2015, 5:30 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38259/
> ---
> 
> (Updated Sept. 13, 2015, 5:30 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3340
> https://issues.apache.org/jira/browse/MESOS-3340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, it appears that re-defining a flag on the command-line that was 
> already defined via a OS Env var (MESOS_*) causes the Master to fail with a 
> not very helpful message.
> 
> For example, if one has MESOS_QUORUM defined, this happens:
> 
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> 
> which is not very helpful.
> 
> Current solution is to throw error if any duplication; over-write may make 
> user confused about the result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ebf8cd6 
> 
> Diff: https://reviews.apache.org/r/38259/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38279: Enabled resources/attributes discovery

[Felix Abecassis]

> On Sept. 14, 2015, 6:12 p.m., Connor Doyle wrote:
> > src/hook/manager.cpp, line 261
> > 
> >
> > Please also add a test that verifies that the hooks are executed in the 
> > expected order.  For example, have two hooks that both modify the `cpus` 
> > resource and verify that the second value is indeed retained.

Postponed for now.


- Felix


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review98886
---


On Sept. 19, 2015, 12:51 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> ---
> 
> (Updated Sept. 19, 2015, 12:51 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> First API draft for MESOS-3366.
> 
> 1) Only supports resources for now, we can add another hook for attributes 
> with a very similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct 
> a new Resources object.
> 3) If there is multiple callbacks, each callback will see the changes made by 
> previous callbacks and are free to override or merge the detected resources 
> as they see fit.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602 
>   src/examples/test_hook_module.cpp 0dc74d6 
>   src/hook/manager.hpp a517c05 
>   src/hook/manager.cpp 691976e 
>   src/slave/slave.cpp ad710d7 
>   src/tests/hook_tests.cpp b23a587 
> 
> Diff: https://reviews.apache.org/r/38279/diff/
> 
> 
> Testing
> ---
> 
> make clean && make && make check
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Review Request 38517: Make attributes.hpp public

[Felix Abecassis]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38517/
---

Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

This is required in order to enable callback hooks that can modify attributes 
of a slave during initialization.


Diffs
-

  include/mesos/attributes.hpp PRE-CREATION 
  src/Makefile.am 834f69a 
  src/common/attributes.hpp 2a7efbd 
  src/common/attributes.cpp f713bb5 
  src/common/http.hpp 058baa6 
  src/common/http.cpp aaef10b 
  src/common/type_utils.cpp 22118b4 
  src/master/http.cpp 8bde4c7 
  src/slave/http.cpp 101aa06 
  src/slave/slave.hpp 32e1830 
  src/tests/attributes_tests.cpp ded6120 
  src/tests/registrar_tests.cpp aa49c86 

Diff: https://reviews.apache.org/r/38517/diff/


Testing
---


Thanks,

Felix Abecassis

Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
---

(Updated Sept. 19, 2015, 1:27 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.


Diffs (updated)
-

  include/mesos/master/allocator.hpp 2dc631242bca8d5e1d536126770f5bcbab2fefed 
  include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
d8acc4fe92fc8dfbd582b165fba24dac492c28d4 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
de88463da2f6833633542442a0d66370507c4018 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
ba4bc58f57b01ad3705438e1172bf6663e2a2446 
  src/master/allocator/mesos/allocator.hpp 
86f6c5572f831b19a3eb006456320df2a445df45 
  src/master/allocator/mesos/hierarchical.hpp 
8f2232a13b6fa0cd01d0399460f9637858a8c6b8 
  src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
  src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf 
  src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988 
  src/python/interface/src/mesos/interface/__init__.py 
cd60ead6c6519d7347aec1fd9315735af0fa818a 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
04e3190949fba8e4675352636b0a649a033f702f 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
10208b176c9b45d5c9afc096564e27403dcde695 
  src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
  src/tests/master_tests.cpp a044286d10bf1ab0676c7d403af59e0b1fea 
  src/tests/mesos.hpp 760dcb7a224141d772098ccd1a7658b2d28f6e21 
  src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb 
  src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 

Diff: https://reviews.apache.org/r/38516/diff/


Testing (updated)
---

Platform: Ubuntu:14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---

(Updated Sept. 18, 2015, 6:27 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, and Vinod Kone.


Changes
---

Addressed most of Artem's comments.


Bugs: MESOS-2083
https://issues.apache.org/jira/browse/MESOS-2083


Repository: mesos


Description
---

Heavily based on the design doc 
(https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).

Includes a diagram of the maintenance mode transitions.


Diffs (updated)
-

  docs/images/maintenance-primitives-modes.png PRE-CREATION 
  docs/maintenance.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37585/diff/


Testing
---

Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.


File Attachments


Same as the image in the binary diff. (Uploaded for reviewer convenience.)
  
https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png


Thanks,

Joseph Wu

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38251/#review99632
---


Thanks for fixing this @gyliu ! Just a minor comment about a alternate simple 
approach that would allow us to not duplicate the same log messages twice. I 
commented only on the HTTP workflow but the same comment also applies to the 
PID based workflow.


src/master/master.cpp (line 1959)


I wonder if we can simply do this instead of duplicating the log messages 
twice. What do you think ? ( Don't copy my suggested comments in the 
code-snippet though :-) )

```
if (framework->connected && !subscribe.force()) {
 FrameworkErrorMessage message;
 ... blah blah
 http.close();
 return;
}

// It's now safe to update the framework fields since the request is now 
gurranteed to be successful.

LOG(INFO) << "Updating info for framework " << framework->id();

framework->updateFrameworkInfo(frameworkInfo);
allocator->updateFramework(framework->id(),  framework->info);

framework->reregisteredTime = Clock::now();

if (subscribe.force()) {
  // already existing logic blah blah.
} else {
  // already existing logic blah blah.
}
```


- Anand Mazumdar


On Sept. 14, 2015, 2:19 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38251/
> ---
> 
> (Updated Sept. 14, 2015, 2:19 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-3169
> https://issues.apache.org/jira/browse/MESOS-3169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FrameworkInfo should only be updated if the re-registration is valid
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 4b60e637b19e749e27c4a8eb9b0a95c7e9305c5f 
> 
> Diff: https://reviews.apache.org/r/38251/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38514/
---

(Updated Sept. 19, 2015, 1:27 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

A comment from Vinod: After some discussion with other committers,
most of them felt SUPPRESS is better than QUIESCE.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
89ddc10d5873cdf09bf5084c4869bc7c29933eab 
  include/mesos/v1/scheduler/scheduler.proto 
bc19b8dfb2ded26a30a28e7370f06816e0fb1999 
  src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
  src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
  src/master/validation.cpp 0f3fc1a20b065a88712cceabab0ceffaec598533 
  src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
  src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 

Diff: https://reviews.apache.org/r/38514/diff/


Testing (updated)
---

Platform: Ubuntu:14.04
make
make check


Thanks,

Guangya Liu

Review Request 38519: Change function quiesce() to suppressRes()

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

The reason that I was not using suppress() is because suppress is
already defined in
3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp


Diffs
-

  src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
  src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e 
  src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 

Diff: https://reviews.apache.org/r/38519/diff/


Testing
---

Platform: Ubuntu:14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joseph Wu]

> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 27
> > 
> >
> > Did the notion of an operator not exist before Maintenance Primitives 
> > were introduced? I would rephrase the sentence above to say that we're 
> > definining terms for the puropse of this doc.

Moved to the top of the section.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 91-92
> > 
> >
> > Can they also specify seconds? If not, we should definitely add a JIRA 
> > for that (as a syntactic sugar for the interface). Please mention somewhere 
> > that start is the nanoseconds since epoch.

Added a note.

However, any seconds-based usage might be kind of weird (we removed it before 
because it's simpler this way).


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 134
> > 
> >
> > What does this mean? What if they aren't?

Added extra sentences.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 135
> > 
> >
> > Please explain a recommended workflow for updating maintenance 
> > schedule, and canceling it.

Added two sentences at the end of this section.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
---


On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 38481: Fix UUID::random compile error in OSX.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/
---

Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
Park.


Bugs: MESOS-3046
https://issues.apache.org/jira/browse/MESOS-3046


Repository: mesos


Description
---

Fix UUID::random compile error in OSX.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
67f1984e4f800cb82797f2cc71596e7c153c2641 

Diff: https://reviews.apache.org/r/38481/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/
---

(Updated Sept. 18, 2015, 7:15 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864


Repository: mesos


Description
---

Only update the task status when its old status is not terminal.


Diffs (updated)
-

  src/master/master.cpp 1c4e7af 

Diff: https://reviews.apache.org/r/38051/diff/


Testing
---

UT:

1. make successfully!
2. make check successfully!
3. Run test framework successfully!


Thanks,

Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Yong Qiao Wang]

> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote:
> > Can you write a test for this?

I find the code changes in this patch does not be tested with an end-to-end 
case except to check the error log messages of master, so my test strategy are:

1. Change the python test executor to send the TASK_FINASHED with two times;
2. Check the error log message of maser;

Test passwd!

Vinod, I am not familiar with current test framework of mesos, cloud you 
provide some similar test code, and I can refer to write my test case for this. 
Thanks!


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review99453
---


On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> ---
> 
> (Updated Sept. 18, 2015, 7:15 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38481: Fix UUID::random compile error in OSX.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99510
---

Ship it!


Assuming the mix of `thread local` and `static` work as advertised, this is a 
clean and elegant solution.


3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 34)


Add empty line here.


- Alexander Rojas


On Sept. 18, 2015, 11:02 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38481: Fix UUID::random compile error in OSX.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/
---

(Updated Sept. 18, 2015, 9:25 a.m.)


Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
Park.


Changes
---

Update according @Alexander Rojas reviews.


Bugs: MESOS-3046
https://issues.apache.org/jira/browse/MESOS-3046


Repository: mesos


Description
---

Fix UUID::random compile error in OSX.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
67f1984e4f800cb82797f2cc71596e7c153c2641 

Diff: https://reviews.apache.org/r/38481/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review99508
---


Patch looks great!

Reviews applied: [38051]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> ---
> 
> (Updated Sept. 18, 2015, 7:15 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38499: Tests for executor endpoint on agent

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99584
---


Patch looks great!

Reviews applied: [38496, 38497, 38499]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> ---
> 
> (Updated Sept. 18, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic validation tests for the Executor HTTP endpoint 
> on Agent.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
>   src/tests/executor_http_api_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99596
---


Patch looks great!

Reviews applied: [37585]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 7:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 18, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/#review99588
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 240 - 
241)


How about we remove this, inline the string literal at the 2 callsites 
below for now, and we'll remove the duplication when we do the refactor of the 
very-similar `load` function definitions?



3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (lines 426 - 427)


Let's not test for specific error strings. Simply checking for the error is 
good enough for now. Once we get to introducing typed errors, we'll be able to 
capture it better within the type system.


- Michael Park


On Sept. 13, 2015, 5:30 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38259/
> ---
> 
> (Updated Sept. 13, 2015, 5:30 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3340
> https://issues.apache.org/jira/browse/MESOS-3340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, it appears that re-defining a flag on the command-line that was 
> already defined via a OS Env var (MESOS_*) causes the Master to fail with a 
> not very helpful message.
> 
> For example, if one has MESOS_QUORUM defined, this happens:
> 
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> 
> which is not very helpful.
> 
> Current solution is to throw error if any duplication; over-write may make 
> user confused about the result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ebf8cd6 
> 
> Diff: https://reviews.apache.org/r/38259/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38470/#review99587
---

Ship it!


Fixed before committing.


src/tests/master_maintenance_tests.cpp (lines 1019 - 1023)


We can overload `CreateMasterFlags()` to turn this off in our tests. This 
will be applicable in the other tests as well.



src/tests/master_maintenance_tests.cpp (line 1031)


``DRAINING``



src/tests/master_maintenance_tests.cpp (lines 1214 - 1252)


As discussed offline, ;et's leave this part out for now. The complication 
is that we send out inverse offers to any framework that has:
(1) tasks running
(2) reserved resources
(3) offered resources


- Joris Van Remoortere


On Sept. 18, 2015, 8:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38470/
> ---
> 
> (Updated Sept. 18, 2015, 8:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3458
> https://issues.apache.org/jira/browse/MESOS-3458
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add regression test.  Note that the test may be slow until inverse offers 
> filters are actually implemented.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
> 
> Diff: https://reviews.apache.org/r/38470/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38347/#review99585
---


Bad patch!

Reviews applied: [38347]

Failed command: ./support/apply-review.sh -n -r 38347

Error:
 2015-09-18 19:11:34 URL:https://reviews.apache.org/r/38347/diff/raw/ 
[2739/2739] -> "38347.patch" [1]
error: patch failed: src/master/master.cpp:783
error: src/master/master.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 15, 2015, 1:04 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38347/
> ---
> 
> (Updated Sept. 15, 2015, 1:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3419
> https://issues.apache.org/jira/browse/MESOS-3419
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add HELP Message for Reserve/Unreserve endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
> 
> Diff: https://reviews.apache.org/r/38347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38470/#review99572
---


Patch looks great!

Reviews applied: [38470]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 5:06 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38470/
> ---
> 
> (Updated Sept. 18, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add regression test.  Note that the test may be slow until inverse offers 
> filters are actually implemented.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
> 
> Diff: https://reviews.apache.org/r/38470/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38347/#review99574
---



src/master/http.cpp (line 669)


How about: `Reserve resources dynamically on a specific slave.`?



src/master/http.cpp (line 671)


How about: `s/if dynamic reserve resource successfully/if resource 
reservation was successful.`?



src/master/http.cpp (line 1788)


Same as above.



src/master/http.cpp (line 1790)


Same as above.



src/master/http.cpp (line 1792)


We should keep this consistent with above, as in: `s/resources going to 
be/resources to be/`


- Michael Park


On Sept. 15, 2015, 1:04 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38347/
> ---
> 
> (Updated Sept. 15, 2015, 1:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3419
> https://issues.apache.org/jira/browse/MESOS-3419
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add HELP Message for Reserve/Unreserve endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
> 
> Diff: https://reviews.apache.org/r/38347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99589
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated Sept. 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38517: Make attributes.hpp public

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38517/#review99652
---


Patch looks great!

Reviews applied: [38517]

All tests passed.

- Mesos ReviewBot


On Sept. 19, 2015, 12:59 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38517/
> ---
> 
> (Updated Sept. 19, 2015, 12:59 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is required in order to enable callback hooks that can modify attributes 
> of a slave during initialization.
> 
> 
> Diffs
> -
> 
>   include/mesos/attributes.hpp PRE-CREATION 
>   src/Makefile.am 834f69a 
>   src/common/attributes.hpp 2a7efbd 
>   src/common/attributes.cpp f713bb5 
>   src/common/http.hpp 058baa6 
>   src/common/http.cpp aaef10b 
>   src/common/type_utils.cpp 22118b4 
>   src/master/http.cpp 8bde4c7 
>   src/slave/http.cpp 101aa06 
>   src/slave/slave.hpp 32e1830 
>   src/tests/attributes_tests.cpp ded6120 
>   src/tests/registrar_tests.cpp aa49c86 
> 
> Diff: https://reviews.apache.org/r/38517/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/#review99646
---


Patch looks great!

Reviews applied: [38259]

All tests passed.

- Mesos ReviewBot


On Sept. 19, 2015, 12:51 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38259/
> ---
> 
> (Updated Sept. 19, 2015, 12:51 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3340
> https://issues.apache.org/jira/browse/MESOS-3340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, it appears that re-defining a flag on the command-line that was 
> already defined via a OS Env var (MESOS_*) causes the Master to fail with a 
> not very helpful message.
> 
> For example, if one has MESOS_QUORUM defined, this happens:
> 
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> 
> which is not very helpful.
> 
> Current solution is to throw error if any duplication; over-write may make 
> user confused about the result.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 43c09f3 
> 
> Diff: https://reviews.apache.org/r/38259/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99644
---


Patch looks great!

Reviews applied: [38511]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> ---
> 
> (Updated Sept. 18, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - We should investigate how to resolve these implications or 
> disable/discourage the use of this backend in production after the overlay 
> backend is committed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 10d9aee8c69e29e0cc9848fc5bde9919d0732b09 
> 
> Diff: https://reviews.apache.org/r/38511/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38279: Enabled resources/attributes discovery

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review99647
---


Patch looks great!

Reviews applied: [38279]

All tests passed.

- Mesos ReviewBot


On Sept. 19, 2015, 12:51 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> ---
> 
> (Updated Sept. 19, 2015, 12:51 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> First API draft for MESOS-3366.
> 
> 1) Only supports resources for now, we can add another hook for attributes 
> with a very similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct 
> a new Resources object.
> 3) If there is multiple callbacks, each callback will see the changes made by 
> previous callbacks and are free to override or merge the detected resources 
> as they see fit.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602 
>   src/examples/test_hook_module.cpp 0dc74d6 
>   src/hook/manager.hpp a517c05 
>   src/hook/manager.cpp 691976e 
>   src/slave/slave.cpp ad710d7 
>   src/tests/hook_tests.cpp b23a587 
> 
> Diff: https://reviews.apache.org/r/38279/diff/
> 
> 
> Testing
> ---
> 
> make clean && make && make check
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38473: Add flag to disable hostname lookup.

[Guangya Liu]

> On 九月 18, 2015, 10:57 p.m., Cong Wang wrote:
> > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway 
> > need to provide a flag?

I also have the same question with Cong, @Marco, can you please show more 
detail for why not using the solution as above? What is the benefit of this 
compared to using --host_name=$LIBPROCESS_IP? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/#review99628
---


On 九月 19, 2015, 1:25 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38473/
> ---
> 
> (Updated 九月 19, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.
> 
> 
> Bugs: MESOS-3457
> https://issues.apache.org/jira/browse/MESOS-3457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain circumstances, dynamic lookup of hostname, while
> successful, provides undesirable results; we would also like, in
> those circumstances, be able to just set the hostname to the chosen
> IP address (possibly set via the --ip_discovery_command method).
> 
> The flag we add here, --[no]-hostname_lookup is `true` by default
> (which is the existing behavior) and will work under most
> circumstances: however, by disabling lookup (using, for example,
> --no_hostname_lookup) the hostname used will be the same as the
> one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.
> 
> This change affects both Master/Agent nodes.
> 
> WARNING - the `Address::hostname()` method always does a dynamic
> hostname lookup, which may in fact return inconsistent results
> wrt the Master's configuration (this is *not* affected by
> this change) and should be avoided; use instead
> `Master::info()::hostname()` which is always consistent with
> the Master's configuration.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
>   src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
>   src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38473/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

[Jiang Yan Xu]

> On Sept. 18, 2015, 10:22 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioner/backends/copy.hpp, line 38
> > 
> >
> > most of the comments makes sense.
> > however what do you mean by writing to root is not accounted for? what 
> > kind of accounting are you referring to?

The disk space it takes. Our current DiskIsolator doesn't count disk space 
outside the sandbox and it's not straightforward to just count the provisioned 
rootfs either because the user/task doesn't ask for it to be copied, the 
slave/operator decided it. Make sense?

I will update point 2) to make it more clear.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99653
---


On Sept. 18, 2015, 3:13 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> ---
> 
> (Updated Sept. 18, 2015, 3:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - We should investigate how to resolve these implications or 
> disable/discourage the use of this backend in production after the overlay 
> backend is committed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 10d9aee8c69e29e0cc9848fc5bde9919d0732b09 
> 
> Diff: https://reviews.apache.org/r/38511/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38246/#review99649
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38246/
> ---
> 
> (Updated 九月 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38246/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38244: Renamed Filter to OfferFilter.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38244/#review99650
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38244/
> ---
> 
> (Updated 九月 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
> 
> Diff: https://reviews.apache.org/r/38244/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Guangya Liu]

> On 九月 17, 2015, 9:42 p.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, line 1608
> > 
> >
> > Needs a test for the scheduler driver. I've only see one for the http 
> > scheduler library.
> > 
> > Also, can you send a review for CHANGELOG and upgrades.md updates for 
> > 0.25.0? feel free to send that after this chain gets committed, to avoid 
> > making this chain even bigger.

Vinod, I see that the CHANGELOG is now using 0.24.1 in release notes, so I need 
to udpate QuiesceOffer to 0.24.1 CHANGELOG? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99450
---


On 九月 18, 2015, 3:55 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated 九月 18, 2015, 3:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99653
---



src/slave/containerizer/provisioner/backends/copy.hpp (line 38)


most of the comments makes sense.
however what do you mean by writing to root is not accounted for? what kind 
of accounting are you referring to?


- Timothy Chen


On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> ---
> 
> (Updated Sept. 18, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - We should investigate how to resolve these implications or 
> disable/discourage the use of this backend in production after the overlay 
> backend is committed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 10d9aee8c69e29e0cc9848fc5bde9919d0732b09 
> 
> Diff: https://reviews.apache.org/r/38511/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 37541: Add trace event API

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37541/
---

(Updated Sept. 18, 2015, 10:12 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.


Changes
---

Rebase and cleanup


Bugs: MESOS-2769
https://issues.apache.org/jira/browse/MESOS-2769


Repository: mesos


Description
---

Based on the PerfEvent API's, add API for Linux kernel trace events, especially 
the schedule trace events.


Diffs (updated)
-

  src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
  src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
  src/tests/containerizer/cgroups_tests.cpp 
75a3bc0009c037dc18ce319db2eb44630f083e8c 
  src/tests/containerizer/perf_tests.cpp 
ed5212ee31b8aa47339b8b8fab184bbdf85be82a 

Diff: https://reviews.apache.org/r/37541/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 38473: Add flag to disable hostname lookup.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/#review99628
---


Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway need 
to provide a flag?

- Cong Wang


On Sept. 18, 2015, 9:53 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38473/
> ---
> 
> (Updated Sept. 18, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.
> 
> 
> Bugs: MESOS-3457
> https://issues.apache.org/jira/browse/MESOS-3457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain circumstances, dynamic lookup of hostname, while
> successful, provides undesirable results; we would also like, in
> those circumstances, be able to just set the hostname to the chosen
> IP address (possibly set via the --ip_discovery_command method).
> 
> The flag we add here, --[no]-hostname_lookup is `true` by default
> (which is the existing behavior) and will work under most
> circumstances: however, by disabling lookup (using, for example,
> --no_hostname_lookup) the hostname used will be the same as the
> one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.
> 
> This change affects both Master/Agent nodes.
> 
> WARNING - the `Address::hostname()` method always does a dynamic
> hostname lookup, which may in fact return inconsistent results
> wrt the Master's configuration (this is *not* affected by
> this change) and should be avoided; use instead
> `Master::info()::hostname()` which is always consistent with
> the Master's configuration.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
>   src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
>   src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38473/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38457/#review99599
---


You should consider adding a CMake macro to make this more maintainable.

A macro that does something like:
```
mkdir -p ${INPUT_SRC}-lib/lib 
&& cp -r ${INPUT_SRC}-build/lib/.libs/. ${INPUT_SRC}-lib/lib
```


3rdparty/libprocess/3rdparty/CMakeLists.txt (line 68)


This is more of a "see MESOS-3250" than a "MESOS-3250 will fix this" right?

(Can you reword a bit?)



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 72)


Delete the ":" ?


- Joseph Wu


On Sept. 17, 2015, 3:03 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38457/
> ---
> 
> (Updated Sept. 17, 2015, 3:03 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A few third-party libraries (libev, gmock) do not have `make install`
> commands available, so below we have to add our own "install" commands.
> 
> The reason is: if we do not, we get runtime library load problems on OS
> X. In particular, `dydl` will look for these libraries at the prefix we
> passed to `configure` (or in `/usr/local` if we did not pass a prefix
> in), but since they don't have a `make install` step, they never get
> placed in the prefix folder.
> 
> Our solution is to:
>   (1) make a lib directory inside the Mesos folder for each of the
>   libraries that has no install step, and
>   (2) copy all such libraries into their respective directories.
> 
> (Note that step (1) is not only convenient, but important: make will add
> a `lib` to the end of your prefix path when linking, and since the built
> libraries end up in a `.libs` folder, it's not enough to simply pass the
> build directory into `configure` as a prefix; so if we're going to move
> the libraries, we might as well move them to a library folder.)
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> d13ba666740b4f2e382a0b1852724cfd519f8f64 
> 
> Diff: https://reviews.apache.org/r/38457/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

[Joseph Wu]

> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote:
> > Looks good.

Any updates on this?  (Haven't come across this test failure recently, but it's 
still nice to have.)


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
---


On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> ---
> 
> (Updated Aug. 26, 2015, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f 
> 
> Diff: https://reviews.apache.org/r/37813/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX, where the bug showed up.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99614
---

Ship it!


Ship It!

- Isabel Jimenez


On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated Sept. 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38511: Added a warning comment to the copy provisioner backend.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99625
---

Ship it!


Ship It!

- Jie Yu


On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> ---
> 
> (Updated Sept. 18, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - We should investigate how to resolve these implications or 
> disable/discourage the use of this backend in production after the overlay 
> backend is committed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/backends/copy.hpp 
> 10d9aee8c69e29e0cc9848fc5bde9919d0732b09 
> 
> Diff: https://reviews.apache.org/r/38511/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

[Guangya Liu]

> On 九月 18, 2015, 9:06 p.m., Vinod Kone wrote:
> > i'm going to commit this chain now. after talking some other committers, 
> > SUPPRESS name is still preferablet o QUIESCE. so lets see if you or I can 
> > make that work (after this chain gets committed).

Thanks Vinod. I can work on the following tasks after this chain committed.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99600
---


On 九月 18, 2015, 3:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 九月 18, 2015, 3:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 38511: Added a warning comment to the copy provisioner backend.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/
---

Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

- We should investigate how to resolve these implications or disable/discourage 
the use of this backend in production after the overlay backend is committed.


Diffs
-

  src/slave/containerizer/provisioner/backends/copy.hpp 
10d9aee8c69e29e0cc9848fc5bde9919d0732b09 

Diff: https://reviews.apache.org/r/38511/diff/


Testing
---

N/A.


Thanks,

Jiang Yan Xu

Re: Review Request 38074: Calculate schedule latency with trace events

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38074/
---

(Updated Sept. 18, 2015, 10:13 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.


Changes
---

Rebase and cleanup


Bugs: MESOS-2769
https://issues.apache.org/jira/browse/MESOS-2769


Repository: mesos


Description
---

Finally, calculate schedule latency with the sched trace events, and add it to 
our statistics


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 
1f722ef3ef7ab7fce5542d4affae961d6cec2406 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp 
03035dfbfb84470ba39ed9ecfd1eb73890e3f784 
  src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
  src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 

Diff: https://reviews.apache.org/r/38074/diff/


Testing
---

manual tests


Thanks,

Cong Wang

Re: Review Request 38473: Add flag to disable hostname lookup.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/
---

(Updated Sept. 18, 2015, 9:53 p.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.


Changes
---

Addressed comments + minor cosmetic changes.


Bugs: MESOS-3457
https://issues.apache.org/jira/browse/MESOS-3457


Repository: mesos


Description
---

Under certain circumstances, dynamic lookup of hostname, while
successful, provides undesirable results; we would also like, in
those circumstances, be able to just set the hostname to the chosen
IP address (possibly set via the --ip_discovery_command method).

The flag we add here, --[no]-hostname_lookup is `true` by default
(which is the existing behavior) and will work under most
circumstances: however, by disabling lookup (using, for example,
--no_hostname_lookup) the hostname used will be the same as the
one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.

This change affects both Master/Agent nodes.

WARNING - the `Address::hostname()` method always does a dynamic
hostname lookup, which may in fact return inconsistent results
wrt the Master's configuration (this is *not* affected by
this change) and should be avoided; use instead
`Master::info()::hostname()` which is always consistent with
the Master's configuration.


Diffs (updated)
-

  docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
  src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
  src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
  src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
  src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
  src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
  src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
  src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
  src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
  src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 

Diff: https://reviews.apache.org/r/38473/diff/


Testing
---

make check


Thanks,

Marco Massenzio

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/
---

(Updated Sept. 18, 2015, 3 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Update a TODO.  Add some minor comments.


Repository: mesos


Description
---

Checks that filters change which inverse offer is sent when.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
9892bc329ff850f638e9f5e79d047efaf2fcb037 

Diff: https://reviews.apache.org/r/38475/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38246/
---

(Updated Sept. 18, 2015, 3:55 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
  src/master/allocator/mesos/allocator.hpp 
171548b2017a0b97124f052c21345668e274d117 
  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 
  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 

Diff: https://reviews.apache.org/r/38246/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan

Re: Review Request 38244: Renamed Filter to OfferFilter.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38244/
---

(Updated Sept. 18, 2015, 3:55 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 

Diff: https://reviews.apache.org/r/38244/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 38324: Added support for setting accept and decline filters on inverse offers.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38324/
---

(Updated Sept. 18, 2015, 3:55 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
  src/master/allocator/mesos/allocator.hpp 
171548b2017a0b97124f052c21345668e274d117 
  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 
  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 

Diff: https://reviews.apache.org/r/38324/diff/


Testing
---

Test in the next review.


Thanks,

Artem Harutyunyan

Re: Review Request 38051: Only update the task status when its old status is not terminal.

[Vinod Kone]

> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote:
> > Can you write a test for this?
> 
> Yong Qiao Wang wrote:
> I find the code changes in this patch does not be tested with an 
> end-to-end case except to check the error log messages of master, so my test 
> strategy are:
> 
> 1. Change the python test executor to send the TASK_FINASHED with two 
> times;
> 2. Check the error log message of maser;
> 
> Test passwd!
> 
> Vinod, I am not familiar with current test framework of mesos, cloud you 
> provide some similar test code, and I can refer to write my test case for 
> this. Thanks!

Instaed of updating python executor, write a self-contained unit test. Take a 
look at "UnacknowledgedTerminalTask" and 
"ReleaseResourcesForTerminalTaskWithPendingUpdates" in 
src/tests/master_tests.cpp for inspiration on how to write such a test.

Also, instead of sending TASK_FINISHED multiple times, have the executor send 
TASK_FINISHED followed by a TASK_KILLED. That way you can check that the status 
of the task hasn't changed in the master.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review99453
---


On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> ---
> 
> (Updated Sept. 18, 2015, 7:15 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38473: Add flag to disable hostname lookup.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/#review99616
---

Ship it!


Ship It!

- Neil Conway


On Sept. 18, 2015, 9:53 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38473/
> ---
> 
> (Updated Sept. 18, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.
> 
> 
> Bugs: MESOS-3457
> https://issues.apache.org/jira/browse/MESOS-3457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain circumstances, dynamic lookup of hostname, while
> successful, provides undesirable results; we would also like, in
> those circumstances, be able to just set the hostname to the chosen
> IP address (possibly set via the --ip_discovery_command method).
> 
> The flag we add here, --[no]-hostname_lookup is `true` by default
> (which is the existing behavior) and will work under most
> circumstances: however, by disabling lookup (using, for example,
> --no_hostname_lookup) the hostname used will be the same as the
> one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.
> 
> This change affects both Master/Agent nodes.
> 
> WARNING - the `Address::hostname()` method always does a dynamic
> hostname lookup, which may in fact return inconsistent results
> wrt the Master's configuration (this is *not* affected by
> this change) and should be avoided; use instead
> `Master::info()::hostname()` which is always consistent with
> the Master's configuration.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
>   src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
>   src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38473/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 38158: Refactored Value::Ranges coalesce().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review99500
---


Patch looks great!

Reviews applied: [38158]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 6:39 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
> 
> (Updated Sept. 18, 2015, 6:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The goal of this refactoring was to reuse the Ranges objects as much as 
> possible, as prior there was substantial time spend in allocation/destruction 
> (MESOS-3051).
> 
> 
> Diffs
> -
> 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/38158/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38481: Fix UUID::random compile error in OSX.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99528
---

Ship it!


Ship It!

- Klaus Ma


On Sept. 18, 2015, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99555
---

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 15, 2015, 12:10 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> ---
> 
> (Updated Sept. 15, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38011: Maintenance Primitives: Use the parse<RepeatedPtrField> helper instead of a plural MachineID protobuf.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38011/#review99579
---

Ship it!


Fixed inline.


src/tests/master_maintenance_tests.cpp (line 100)


new line



src/tests/registrar_tests.cpp (lines 535 - 536)


Fits on 1 line.



src/tests/registrar_tests.cpp (lines 624 - 625)


Fits on 1 line.


- Joris Van Remoortere


On Sept. 16, 2015, 7:38 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38011/
> ---
> 
> (Updated Sept. 16, 2015, 7:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem 
> Harutyunyan, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This removes the MachineIDs protobuf and changes it to instead use the 
> RepeatedFieldPtr.
> This also changes the maintenance primitives (alpha) API for /machine/up and 
> /machine/down, which both take an array instead of an object now.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da 
>   src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0 
>   src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955 
> 
> Diff: https://reviews.apache.org/r/38011/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38470/
---

(Updated Sept. 18, 2015, 1:29 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Bugs: MESOS-3458
https://issues.apache.org/jira/browse/MESOS-3458


Repository: mesos


Description
---

Add regression test.  Note that the test may be slow until inverse offers 
filters are actually implemented.


Diffs
-

  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/tests/master_maintenance_tests.cpp 
44785057f129a3e6a69f399f7d6db59d9d5c2e91 

Diff: https://reviews.apache.org/r/38470/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 38481: Fix UUID::random compile error in OSX.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99542
---

Ship it!


Ship It!

- Ben Mahler


On Sept. 18, 2015, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38491: Logged requests related to dynamic reservations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38491/#review99537
---


Patch looks great!

Reviews applied: [38491]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 2:37 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38491/
> ---
> 
> (Updated Sept. 18, 2015, 2:37 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
> 
> Diff: https://reviews.apache.org/r/38491/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38470: Maintenance Primitives: Fix error in master's Accept/Decline for inverse offers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38470/
---

(Updated Sept. 18, 2015, 10:06 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Rebase.  (Patch didn't apply)


Repository: mesos


Description
---

Add regression test.  Note that the test may be slow until inverse offers 
filters are actually implemented.


Diffs (updated)
-

  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/tests/master_maintenance_tests.cpp 
44785057f129a3e6a69f399f7d6db59d9d5c2e91 

Diff: https://reviews.apache.org/r/38470/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Review Request 38496: Added devolve operation for V1 Executor Protobuf

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/
---

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change adds a trivial devolve call for V1 Executor Protobuf -> unversioned 
protobuf that can be used internally.


Diffs
-

  src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
  src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 

Diff: https://reviews.apache.org/r/38496/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 38497: Introduced Executor HTTP endpoint on Agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38497/
---

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change introduces a stub endpoint on Agent. As of now, it doesn't do much 
except validating the `Content-Type`, `Accept` headers among other trivial 
validations. Most of the functionality already existed in `src/master/http.cpp`


Diffs
-

  src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e 
  src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721 
  src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 

Diff: https://reviews.apache.org/r/38497/diff/


Testing
---

make check + tests in r38499


Thanks,

Anand Mazumdar

Review Request 38499: Tests for executor endpoint on agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
---

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change introduces basic validation tests for the Executor HTTP endpoint on 
Agent.


Diffs
-

  src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
  src/tests/executor_http_api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38499/diff/


Testing
---

make check


Thanks,

Anand Mazumdar